From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5B7CFC4332F for ; Tue, 15 Nov 2022 13:22:14 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id DDA8A409F9; Tue, 15 Nov 2022 13:22:13 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org DDA8A409F9 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jaRBJfDZ0FjQ; Tue, 15 Nov 2022 13:22:13 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp2.osuosl.org (Postfix) with ESMTP id 2B35C403B3; Tue, 15 Nov 2022 13:22:12 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 2B35C403B3 Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id 8C1941BF319 for ; Tue, 15 Nov 2022 13:22:10 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 66F57403B3 for ; Tue, 15 Nov 2022 13:22:10 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 66F57403B3 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id uBRSErW26don for ; Tue, 15 Nov 2022 13:22:09 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 6C5E9401F1 Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [217.70.183.196]) by smtp2.osuosl.org (Postfix) with ESMTPS id 6C5E9401F1 for ; Tue, 15 Nov 2022 13:22:09 +0000 (UTC) Received: (Authenticated sender: peter@korsgaard.com) by mail.gandi.net (Postfix) with ESMTPSA id 10D82E000C; Tue, 15 Nov 2022 13:22:06 +0000 (UTC) Received: from peko by dell.be.48ers.dk with local (Exim 4.94.2) (envelope-from ) id 1ouvt8-008fWP-3L; Tue, 15 Nov 2022 14:22:06 +0100 From: Peter Korsgaard To: Thomas Petazzoni via buildroot References: <20221111215759.358116-1-thomas.petazzoni@bootlin.com> Date: Tue, 15 Nov 2022 14:22:06 +0100 In-Reply-To: <20221111215759.358116-1-thomas.petazzoni@bootlin.com> (Thomas Petazzoni via buildroot's message of "Fri, 11 Nov 2022 22:57:58 +0100") Message-ID: <87h6z0fj41.fsf@dell.be.48ers.dk> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Subject: Re: [Buildroot] [PATCH 1/2] arch/arch.mk.xtensa: relax check on overlay file to apply only to internal toolchains X-BeenThere: buildroot@buildroot.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Romain Naour , "Yann E. MORIN" , Thomas Petazzoni Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: buildroot-bounces@buildroot.org Sender: "buildroot" >>>>> "Thomas" == Thomas Petazzoni via buildroot writes: > Commit 4cbf7336914f25478aea943456ba7dc3c892c21a ("arch/xtensa: custom > configuration requires an overlay") added a check in > arch/arch.mk.xtensa to bail out if a custom Xtensa core is selected > but not overlay file is provided. While this is indeed a perfectly > valid check to make when building an internal toolchain, with an > external toolchain it's entirely possible to build with no overlay > file: the toolchain already exists, and there's no overlay to be > applied in the context of the Buildroot build. > And indeed commit 4cbf7336914f25478aea943456ba7dc3c892c21a broke some > of the runtime test cases that use a custom Xtensa core configuration, > with no overlay, to test the toolchains.bootlin.com Xtensa external > toolchain. By relaxing the check to only apply to internal toolchain > configurations, we fix those test cases. > Fixes: > https://gitlab.com/buildroot.org/buildroot/-/jobs/3282261966 > https://gitlab.com/buildroot.org/buildroot/-/jobs/3282261963 > Signed-off-by: Thomas Petazzoni Committed to 2022.08.x and 2022.02.x, thanks. -- Bye, Peter Korsgaard _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot