Re: [PATCH] docs/devel: remove incorrect claim about git send-email

[Alyssa Ross <hi@alyssa.is>]

[-- Attachment #1: Type: text/plain, Size: 1230 bytes --]

Linus Heckemann <git@sphalerite.org> writes:

> Alyssa Ross <hi@alyssa.is> writes:
>
>> Alyssa Ross <hi@alyssa.is> writes:
>>
>>> Linus Heckemann <git@sphalerite.org> writes:
>>>
>>>> While it's unclear to me what git send-email actually does with the
>>>> -v2 parameter (it is not documented, but also not rejected), it does
>>>> not add a v2 tag to the email's subject, which is what led to the
>>>> mishap in [1].
>>>>
>>>> [1]: https://lists.nongnu.org/archive/html/qemu-devel/2022-09/msg00679.html
>>>
>>> It does for me!
>>>
>>> Tested with:
>>>
>>>        git send-email -v2 --to hi@alyssa.is HEAD~
>>>
>>> X-Mailer: git-send-email 2.37.1
>>
>> I wouldn't be surprised if it only adds it when it's generating the
>> patch though.  Did you perhaps run git format-patch first to generate a
>> patch file, and then use git send-email to send it?
>
> Yes! I didn't realise that git send-email can be used without the
> intermediate format-patch step. I guess it's a git bug that git
> send-email will silently ignore -v when used with a patch file. I'll
> have a look at fixing that.

Yeah, that sounds like the best way to go.  I think it'll swallow /any/
format-patch options when used that way.  Would be nice if it warned.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]