From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D33D8ECAAD3 for ; Fri, 9 Sep 2022 04:25:22 +0000 (UTC) Received: from localhost ([::1]:50546 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oWVZy-00009r-14 for qemu-devel@archiver.kernel.org; Fri, 09 Sep 2022 00:25:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41162) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oWVZ6-0007u6-Ix for qemu-devel@nongnu.org; Fri, 09 Sep 2022 00:24:29 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:39507) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oWVZ3-0003yt-53 for qemu-devel@nongnu.org; Fri, 09 Sep 2022 00:24:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1662697464; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PcILEiy6q9YgqkFoiMLhvTGsTam40LOPEOZu+SXVdGI=; b=FJsrUIdXbdmDpbyNlbA2xvao/313cFO4l/qJOPY97J+oRqqRpb2wbGkO02r94p+EM700xy 3Mez9RKk/aOM74h1DGUlfbO8+JFRX2ZJH02Ox7S535+y1kFC9w2CYAXKnwZ/buTMWpRCK/ CQMxKpnReGG+yhSleIqr/alUMOVfvmQ= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-557-uATh8eyMPrWML5ziFydfIQ-1; Fri, 09 Sep 2022 00:24:23 -0400 X-MC-Unique: uATh8eyMPrWML5ziFydfIQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id AD80C294EDF2; Fri, 9 Sep 2022 04:24:22 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.39.193.166]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 88B1E1410F38; Fri, 9 Sep 2022 04:24:22 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 69BA721E6900; Fri, 9 Sep 2022 06:24:21 +0200 (CEST) From: Markus Armbruster To: Peter Maydell Cc: Patrick Venture , QEMU Developers , Peter Foley Subject: Re: Seeing qtest assertion failure with 7.1 References: Date: Fri, 09 Sep 2022 06:24:21 +0200 In-Reply-To: (Peter Maydell's message of "Thu, 8 Sep 2022 17:00:26 +0100") Message-ID: <87h71h18ga.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.85 on 10.11.54.7 Received-SPF: pass client-ip=170.10.129.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Peter Maydell writes: > On Thu, 8 Sept 2022 at 16:54, Patrick Venture wrote: >> On Wed, Sep 7, 2022 at 10:40 AM Peter Maydell wrote: >>> Have a look in the source at what exactly the assertion >>> failure in libqtest.c is checking for -- IIRC it's a pretty >>> basic "did we open a socket fd" one. I think sometimes I >>> used to see something like this if there's an old stale socket >>> lying around in the test directory and the randomly generated >>> socket filename happens to clash with it. > >> Thanks for the debugging tip! I can't reproduce it at this point. I >> saw it 2-3 times, and now not at all. So more than likely it's >> exactly what you're describing. > > Mmm. We do clean up the socket after ourselves in the test > harness, but I think what can happen is that if a test case > crashes then the cleanup doesn't happen. Then there's a stale > file left in the build tree, and then you only hit it if you > get unlucky with PID allocation on a future run... Yes, and that's bad behavior. I think we should run each test in its own directory, which we delete afterwards. That way anything the test creates there will be cleaned up whether it succeeds or fails.