From: Cornelia Huck <cohuck@redhat.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
Diana Craciun <diana.craciun@oss.nxp.com>,
Alex Williamson <alex.williamson@redhat.com>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
kvm@vger.kernel.org
Subject: Re: [PATCH] vfio/fsl-mc: Fix a typo in a comment
Date: Mon, 08 Aug 2022 11:57:05 +0200 [thread overview]
Message-ID: <87h72ndpn2.fsf@redhat.com> (raw)
In-Reply-To: <2b65bf8d2b4d940cafbafcede07c23c35f042f5a.1659815764.git.christophe.jaillet@wanadoo.fr>
On Sat, Aug 06 2022, Christophe JAILLET <christophe.jaillet@wanadoo.fr> wrote:
$SUBJECT: s/comment/message/
> L and S are swapped/
> s/VFIO_FLS_MC/VFIO_FSL_MC/
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> All the dev_ logging functions in the file have the "VFIO_FSL_MC: "
> prefix.
> As they are dev_ function, the driver should already be displayed.
>
> So, does it make sense or could they be all removed?
From a quick glance, there seem to be messages for when the device is
_not_ bound to the fsl-mc driver (e.g. in vfio_fsl_mc_bus_notifier());
I'd just fix the typo for now.
> ---
> drivers/vfio/fsl-mc/vfio_fsl_mc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Acked-by: Cornelia Huck <cohuck@redhat.com>
next prev parent reply other threads:[~2022-08-08 9:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-06 19:56 [PATCH] vfio/fsl-mc: Fix a typo in a comment Christophe JAILLET
2022-08-08 9:57 ` Cornelia Huck [this message]
2022-08-09 16:20 ` Jason Gunthorpe
2022-08-16 15:00 ` Christophe JAILLET
2022-08-16 15:08 ` Jason Gunthorpe
2022-08-22 9:14 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h72ndpn2.fsf@redhat.com \
--to=cohuck@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=diana.craciun@oss.nxp.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.