From: Kalle Valo <kvalo@kernel.org>
To: Ping-Ke Shih <pkshih@realtek.com>
Cc: <johannes@sipsolutions.net>, <linux-wireless@vger.kernel.org>,
<echuang@realtek.com>, <phhuang@realtek.com>
Subject: Re: [PATCH 1/3] ieee80211: add trigger frame definition
Date: Wed, 08 Jun 2022 11:06:51 +0300 [thread overview]
Message-ID: <87h74vshno.fsf@kernel.org> (raw)
In-Reply-To: <20220601013917.18814-2-pkshih@realtek.com> (Ping-Ke Shih's message of "Wed, 1 Jun 2022 09:39:15 +0800")
Ping-Ke Shih <pkshih@realtek.com> writes:
> From: Po Hao Huang <phhuang@realtek.com>
>
> Define trigger stype of control frame, and its checking function, struct
> and trigger type within common_info of trigger.
>
> Signed-off-by: Po Hao Huang <phhuang@realtek.com>
> Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
> ---
> include/linux/ieee80211.h | 31 +++++++++++++++++++++++++++++++
> 1 file changed, 31 insertions(+)
>
> diff --git a/include/linux/ieee80211.h b/include/linux/ieee80211.h
> index 75d40acb60c1c..f3b2d5b56d643 100644
> --- a/include/linux/ieee80211.h
> +++ b/include/linux/ieee80211.h
> @@ -76,6 +76,7 @@
> #define IEEE80211_STYPE_ACTION 0x00D0
>
> /* control */
> +#define IEEE80211_STYPE_TRIGGER 0x0020
> #define IEEE80211_STYPE_CTL_EXT 0x0060
> #define IEEE80211_STYPE_BACK_REQ 0x0080
> #define IEEE80211_STYPE_BACK 0x0090
> @@ -295,6 +296,17 @@ static inline u16 ieee80211_sn_sub(u16 sn1, u16 sn2)
>
> #define IEEE80211_HT_CTL_LEN 4
>
> +/* trigger type within common_info of trigger frame */
> +#define IEEE80211_TRIGGER_TYPE_MASK 0xfULL
> +#define IEEE80211_TRIGGER_TYPE_BASIC 0x0
> +#define IEEE80211_TRIGGER_TYPE_BFRP 0x1
> +#define IEEE80211_TRIGGER_TYPE_MU_BAR 0x2
> +#define IEEE80211_TRIGGER_TYPE_MU_RTS 0x3
> +#define IEEE80211_TRIGGER_TYPE_BSRP 0x4
> +#define IEEE80211_TRIGGER_TYPE_GCR_MU_BAR 0x5
> +#define IEEE80211_TRIGGER_TYPE_BQRP 0x6
> +#define IEEE80211_TRIGGER_TYPE_NFRP 0x7
Why ULL in the mask? I don't see it used anywhere else in the file.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2022-06-08 8:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-01 1:39 [PATCH 0/3] rtw89: use count of trigger frames as a clue to accelerate CFO tracking Ping-Ke Shih
2022-06-01 1:39 ` [PATCH 1/3] ieee80211: add trigger frame definition Ping-Ke Shih
2022-06-08 8:06 ` Kalle Valo [this message]
2022-06-08 8:13 ` Ping-Ke Shih
2022-06-08 8:14 ` Johannes Berg
2022-06-01 1:39 ` [PATCH 2/3] rtw89: 8852c: add trigger frame counter Ping-Ke Shih
2022-06-01 1:39 ` [PATCH 3/3] rtw89: add new state to CFO state machine for UL-OFDMA Ping-Ke Shih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h74vshno.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=echuang@realtek.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=phhuang@realtek.com \
--cc=pkshih@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.