All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: huangwenhui <huangwenhuia@uniontech.com>
Cc: alsa-devel@alsa-project.org, kailang@realtek.com,
	tanureal@opensource.cirrus.com, jeremy.szu@canonical.com,
	linux-kernel@vger.kernel.org, tiwai@suse.com,
	wse@tuxedocomputers.com, hui.wang@canonical.com, sami@loone.fi,
	cam@neo-zeon.de
Subject: Re: [PATCH] ALSA: hda/realtek - Add HW8326 support
Date: Tue, 07 Jun 2022 11:09:45 +0200	[thread overview]
Message-ID: <87h74won52.wl-tiwai@suse.de> (raw)
In-Reply-To: <20220607084109.29120-1-huangwenhuia@uniontech.com>

On Tue, 07 Jun 2022 10:41:09 +0200,
huangwenhui wrote:
> 
> Added the support of new Huawei codec HW8326.
> 

It'd be appreciated if you describe about the hardware a bit more.
It looks like a compatible chip with some other Realtek codecs
(ALC256?).

> @@ -11479,6 +11492,7 @@ static const struct hda_device_id snd_hda_id_realtek[] = {
>  	HDA_CODEC_ENTRY(0x10ec0236, "ALC236", patch_alc269),
>  	HDA_CODEC_ENTRY(0x10ec0245, "ALC245", patch_alc269),
>  	HDA_CODEC_ENTRY(0x10ec0255, "ALC255", patch_alc269),
> +	HDA_CODEC_ENTRY(0x19e58326, "HW8326", patch_alc269),
>  	HDA_CODEC_ENTRY(0x10ec0256, "ALC256", patch_alc269),
>  	HDA_CODEC_ENTRY(0x10ec0257, "ALC257", patch_alc269),
>  	HDA_CODEC_ENTRY(0x10ec0260, "ALC260", patch_alc260),

This table is sorted in the codec ID order.  Please put at the
appropriate place (at the last), instead.


thanks,

Takashi

WARNING: multiple messages have this Message-ID (diff)
From: Takashi Iwai <tiwai@suse.de>
To: huangwenhui <huangwenhuia@uniontech.com>
Cc: perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org,
	kailang@realtek.com, tanureal@opensource.cirrus.com,
	jeremy.szu@canonical.com, linux-kernel@vger.kernel.org,
	wse@tuxedocomputers.com, hui.wang@canonical.com, sami@loone.fi,
	cam@neo-zeon.de
Subject: Re: [PATCH] ALSA: hda/realtek - Add HW8326 support
Date: Tue, 07 Jun 2022 11:09:45 +0200	[thread overview]
Message-ID: <87h74won52.wl-tiwai@suse.de> (raw)
In-Reply-To: <20220607084109.29120-1-huangwenhuia@uniontech.com>

On Tue, 07 Jun 2022 10:41:09 +0200,
huangwenhui wrote:
> 
> Added the support of new Huawei codec HW8326.
> 

It'd be appreciated if you describe about the hardware a bit more.
It looks like a compatible chip with some other Realtek codecs
(ALC256?).

> @@ -11479,6 +11492,7 @@ static const struct hda_device_id snd_hda_id_realtek[] = {
>  	HDA_CODEC_ENTRY(0x10ec0236, "ALC236", patch_alc269),
>  	HDA_CODEC_ENTRY(0x10ec0245, "ALC245", patch_alc269),
>  	HDA_CODEC_ENTRY(0x10ec0255, "ALC255", patch_alc269),
> +	HDA_CODEC_ENTRY(0x19e58326, "HW8326", patch_alc269),
>  	HDA_CODEC_ENTRY(0x10ec0256, "ALC256", patch_alc269),
>  	HDA_CODEC_ENTRY(0x10ec0257, "ALC257", patch_alc269),
>  	HDA_CODEC_ENTRY(0x10ec0260, "ALC260", patch_alc260),

This table is sorted in the codec ID order.  Please put at the
appropriate place (at the last), instead.


thanks,

Takashi

  reply	other threads:[~2022-06-07  9:10 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-07  8:41 [PATCH] ALSA: hda/realtek - Add HW8326 support huangwenhui
2022-06-07  8:41 ` huangwenhui
2022-06-07  9:09 ` Takashi Iwai [this message]
2022-06-07  9:09   ` Takashi Iwai
2022-06-07  9:32   ` huangwenhui
  -- strict thread matches above, loose matches on Subject: below --
2022-06-08  1:12 huangwenhui
2022-06-08  1:12 ` huangwenhui
2022-06-08  5:39 ` Takashi Iwai
2022-06-08  5:39   ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h74won52.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=cam@neo-zeon.de \
    --cc=huangwenhuia@uniontech.com \
    --cc=hui.wang@canonical.com \
    --cc=jeremy.szu@canonical.com \
    --cc=kailang@realtek.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sami@loone.fi \
    --cc=tanureal@opensource.cirrus.com \
    --cc=tiwai@suse.com \
    --cc=wse@tuxedocomputers.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.