All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: Sol Bekic via buildroot <buildroot@buildroot.org>
Cc: Sol Bekic <s+removethis@s-ol.nu>,
	"Yann E . MORIN" <yann.morin.1998@free.fr>
Subject: Re: [Buildroot] [PATCH v2 1/1] package/usb_modeswitch: fix installation of systemd unit file
Date: Sun, 29 May 2022 10:20:48 +0200	[thread overview]
Message-ID: <87h7587nrz.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20220514142659.70948-1-s+removethis@s-ol.nu> (Sol Bekic via buildroot's message of "Sat, 14 May 2022 16:26:59 +0200")

>>>>> "Sol" == Sol Bekic via buildroot <buildroot@buildroot.org> writes:

 > From: s-ol <s+removethis@s-ol.nu>
 > The upstream Makefile failed to detect systemd being present in some (maybe all)
 > builds, resulting in the unit file not being installed. Without the unit file,
 > the udev rules in usb_modeswitch-data don't work as expected (no modeswitch is
 > performed).

 > This commit adds a patch that modifies the Makefile to include
 > '$(PREFIX)/bin/systemctl' in the list of paths checked, which makes the
 > installation phase work as intended. I will also submit this patch upstream.

 > Signed-off-by: Sol Bekic <s+removethis@s-ol.nu>
 > ---
 > As requested by Yann E. Morin, both this patch and the patch-file it adds
 > are commented and signed off with my full name.

Committed to 2022.02.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      parent reply	other threads:[~2022-05-29  8:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-14 12:42 [Buildroot] [PATCH 1/1] package/usb_modeswitch: fix installation of systemd unit file s-ol via buildroot
2022-05-14 13:14 ` Yann E. MORIN
2022-05-14 14:26   ` [Buildroot] [PATCH v2 " Sol Bekic via buildroot
2022-05-14 21:53     ` Yann E. MORIN
2022-05-29  8:20     ` Peter Korsgaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h7587nrz.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@buildroot.org \
    --cc=s+removethis@s-ol.nu \
    --cc=yann.morin.1998@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.