All of lore.kernel.org
 help / color / mirror / Atom feed
From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To: Chung-Chiang Cheng <cccheng@synology.com>
Cc: linux-kernel@vger.kernel.org, kernel@cccheng.net, shepjeng@gmail.com
Subject: Re: [PATCH v3 3/3] fat: report creation time in statx
Date: Fri, 15 Apr 2022 22:17:21 +0900	[thread overview]
Message-ID: <87h76utrj2.fsf@mail.parknet.co.jp> (raw)
In-Reply-To: <20220415094518.380543-3-cccheng@synology.com> (Chung-Chiang Cheng's message of "Fri, 15 Apr 2022 17:45:18 +0800")

Chung-Chiang Cheng <cccheng@synology.com> writes:

> @@ -568,10 +568,14 @@ int fat_fill_inode(struct inode *inode, struct msdos_dir_entry *de)
>  
>  	fat_time_fat2unix(sbi, &inode->i_mtime, de->time, de->date, 0);
>  	inode->i_ctime = inode->i_mtime;
> -	if (sbi->options.isvfat)
> +	if (sbi->options.isvfat) {
>  		fat_time_fat2unix(sbi, &inode->i_atime, 0, de->adate, 0);
> -	else
> +		fat_time_fat2unix(sbi, &MSDOS_I(inode)->i_crtime, de->ctime,
> +				  de->cdate, de->ctime_cs);
> +	} else {
>  		fat_truncate_atime(sbi, &inode->i_mtime, &inode->i_atime);
> +		fat_truncate_crtime(sbi, &inode->i_mtime, &MSDOS_I(inode)->i_crtime);
> +	}

Probably, nothing worth to update i_crtime here, right?

Thanks.
-- 
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>

  reply	other threads:[~2022-04-15 13:17 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-15  9:45 [PATCH v3 1/3] fat: split fat_truncate_time() into separate functions Chung-Chiang Cheng
2022-04-15  9:45 ` [PATCH v3 2/3] fat: make ctime and mtime identical explicitly Chung-Chiang Cheng
2022-04-15 13:28   ` OGAWA Hirofumi
2022-04-22  8:24     ` Chung-Chiang Cheng
2022-04-15  9:45 ` [PATCH v3 3/3] fat: report creation time in statx Chung-Chiang Cheng
2022-04-15 13:17   ` OGAWA Hirofumi [this message]
2022-04-22  8:20     ` Chung-Chiang Cheng
2022-04-22 12:06       ` OGAWA Hirofumi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h76utrj2.fsf@mail.parknet.co.jp \
    --to=hirofumi@mail.parknet.co.jp \
    --cc=cccheng@synology.com \
    --cc=kernel@cccheng.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=shepjeng@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.