From: "Toke Høiland-Jørgensen" <toke@toke.dk>
To: Yang Li <yang.lee@linux.alibaba.com>, kvalo@kernel.org
Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
loic.poulain@linaro.org, wcn36xx@lists.infradead.org,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
Yang Li <yang.lee@linux.alibaba.com>,
Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH -next 2/2] ath9k: Remove unnecessary print function dev_err()
Date: Fri, 08 Apr 2022 13:53:35 +0200 [thread overview]
Message-ID: <87h77394g0.fsf@toke.dk> (raw)
In-Reply-To: <20220408000113.129906-2-yang.lee@linux.alibaba.com>
Yang Li <yang.lee@linux.alibaba.com> writes:
> The print function dev_err() is redundant because
> platform_get_irq_byname() already prints an error.
>
> Eliminate the follow coccicheck warning:
> ./drivers/net/wireless/ath/ath9k/ahb.c:103:2-9: line 103 is redundant
> because platform_get_irq() already prints an error
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Heh, so I was the one originally insisting on keeping that err print,
but looking a bit closer now it does really appear to be redundant, so:
Acked-by: Toke Høiland-Jørgensen <toke@toke.dk>
next prev parent reply other threads:[~2022-04-08 11:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-08 0:01 [PATCH -next 1/2] wcn36xx: clean up some inconsistent indenting Yang Li
2022-04-08 0:01 ` [PATCH -next 2/2] ath9k: Remove unnecessary print function dev_err() Yang Li
2022-04-08 11:53 ` Toke Høiland-Jørgensen [this message]
2022-04-12 13:13 ` Kalle Valo
2022-04-08 6:42 ` [PATCH -next 1/2] wcn36xx: clean up some inconsistent indenting Loic Poulain
2022-04-12 13:13 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h77394g0.fsf@toke.dk \
--to=toke@toke.dk \
--cc=abaci@linux.alibaba.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=wcn36xx@lists.infradead.org \
--cc=yang.lee@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.