Re: [igt-dev] [PATCH i-g-t 2/2] tests/i915/gem_spin_batch: Removing context persistence

["Dixit, Ashutosh" <ashutosh.dixit@intel.com>]

On Fri, 18 Feb 2022 17:32:15 -0800, Jasmine Newsome wrote:
>
> diff --git a/tests/i915/gem_spin_batch.c b/tests/i915/gem_spin_batch.c
> index 653812c7..707d69b6 100644
> --- a/tests/i915/gem_spin_batch.c
> +++ b/tests/i915/gem_spin_batch.c
> @@ -161,8 +161,6 @@ static void spin_all(int i915, const intel_ctx_t *ctx, unsigned int flags)
>				    .engine = e->flags,
>				    .flags = (IGT_SPIN_POLL_RUN |
>					      IGT_SPIN_NO_PREEMPTION));
> -		if (flags & PARALLEL_SPIN_NEW_CTX)
> -			intel_ctx_destroy(i915, ctx);
>
>		igt_spin_busywait_until_started(spin);
>		igt_list_move(&spin->link, &list);
> @@ -172,6 +170,8 @@ static void spin_all(int i915, const intel_ctx_t *ctx, unsigned int flags)
>		igt_assert(gem_bo_busy(i915, spin->handle));
>		ahnd = spin->ahnd;
>		igt_spin_end(spin);
> +		if (flags & PARALLEL_SPIN_NEW_CTX)
> +			intel_ctx_destroy(i915, spin->opts.ctx);

To be safe I think we should move this after gem_sync(). Anyway I am fine
with the patches now. Let's see if anyone else has comments/objections,
otherwise I can fix this up before merging.

>		gem_sync(i915, spin->handle);
>		igt_spin_free(i915, spin);
>		put_ahnd(ahnd);
> --
> 2.25.1
>