From: Kalle Valo <kvalo@kernel.org>
To: Phil Elwell <phil@raspberrypi.com>
Cc: Arend van Spriel <aspriel@gmail.com>,
Chung-hsien Hsu <chung-hsien.hsu@infineon.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
linux-wireless@vger.kernel.org,
brcm80211-dev-list.pdl@broadcom.com,
SHA-cyfmac-dev-list@infineon.com
Subject: Re: [PATCH] brcmfmac: firmware: Fix crash in brcm_alt_fw_path
Date: Wed, 19 Jan 2022 08:01:08 +0200 [thread overview]
Message-ID: <87h7a0gt7f.fsf@kernel.org> (raw)
In-Reply-To: <20220118154514.3245524-1-phil@raspberrypi.com> (Phil Elwell's message of "Tue, 18 Jan 2022 15:45:14 +0000")
Phil Elwell <phil@raspberrypi.com> writes:
> The call to brcm_alt_fw_path in brcmf_fw_get_firmwares is not protected
> by a check to the validity of the fwctx->req->board_type pointer. This
> results in a crash in strlcat when, for example, the WLAN chip is found
> in a USB dongle.
>
> Prevent the crash by adding the necessary check.
>
> See: https://github.com/raspberrypi/linux/issues/4833
>
> Fixes: 5ff013914c62 ("brcmfmac: firmware: Allow per-board firmware binaries")
> Signed-off-by: Phil Elwell <phil@raspberrypi.com>
I think this should go to v5.17.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2022-01-19 6:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-18 15:45 [PATCH] brcmfmac: firmware: Fix crash in brcm_alt_fw_path Phil Elwell
2022-01-19 6:01 ` Kalle Valo [this message]
2022-01-19 8:53 ` Phil Elwell
2022-01-19 10:00 ` Kalle Valo
2022-01-19 15:48 ` Arend van Spriel
2022-01-27 12:08 ` Kalle Valo
2022-01-27 12:59 ` Arend van Spriel
2022-01-27 13:17 ` Kalle Valo
2022-01-27 14:30 ` Arend van Spriel
2022-01-27 15:36 ` Kalle Valo
2022-01-27 16:22 ` Arend van Spriel
2022-01-28 14:07 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h7a0gt7f.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=SHA-cyfmac-dev-list@infineon.com \
--cc=aspriel@gmail.com \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=chung-hsien.hsu@infineon.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-wireless@vger.kernel.org \
--cc=phil@raspberrypi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.