From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:ac2:5544:0:0:0:0:0 with SMTP id l4csp5965843lfk; Wed, 1 Dec 2021 04:28:32 -0800 (PST) X-Google-Smtp-Source: ABdhPJzbq9UyOMgtLdJp+QgRmlhrWpdYaH0/gMnHKQo32Qj83ONCADmvVy3tNQtmwO6CdUBGpTlQ X-Received: by 2002:a05:622a:346:: with SMTP id r6mr6324305qtw.78.1638361712729; Wed, 01 Dec 2021 04:28:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1638361712; cv=none; d=google.com; s=arc-20160816; b=pfh5803NJpmj2xajphQ7wgCvg1pUwAGyCxUDoD1/VW/i8GOdyu+tQk5Nc+QiKwiLye mzFoDTvcVwtiq4jAaZ3lI4ieI0Ct1n5AjyIYsF+cEWDB0BfyFnUb8rbZOiIAkEmjt3U/ 4HHWQqwd5wGBwHxTsShTUnCG3fgalJcj2fihyQRecHgkSDziPpYfsEvmpnxdBuen1qvD v+ujwHStmSo5WyNXyyV7cu+qbvICuhMs8inWhzbnww6nmHAn2cGq/PdAtNckX/6YXc0I 4K80d1jyL8KeBx6U328zE2jmeDy3BdpFBT8njSs+kjI7kDsn3xHOJmkg6CQSBM+NvIy8 hoVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:mime-version:user-agent :references:in-reply-to:subject:to:from:message-id:date; bh=SKTYE4hNs+AHsZWWmP/eEdxWBiYyWXqucQmTmFbfi60=; b=uiWFiobUrVovtKRLWuyTrOnz5poM8JUyRqX+oh8TpCtHYnO+6kZ9I5CnBmrPZyXXKC lm16MVmMch2j/UEkBw/KjC1rrN++4GD8g0+EAjOCYWYWO0EkN3qTjD3pOdkwXBADa+u9 YM8NRxK1u99VTVyEWuZ4KiAK0mU+MfFk6JdHgJLA7hInffetB4LiWbe9plgSs4hToVG3 AtHRer7A6trQyYfeZ7phCzELxs71iMGSRXZWGL5KsKQgYxXFI0lzxxSWdgrZCdoWW1Kk GJGhT95R00ZLeDFANMofj3NZXiIsdcTlC+v67HPXofnU5sLoWFNNjYk9dvf1DZ1rUbBw x5Kw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org" Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id d10si11440994vsk.121.2021.12.01.04.28.32 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 01 Dec 2021 04:28:32 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org" Received: from localhost ([::1]:53160 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1msOiu-0008OT-23 for alex.bennee@linaro.org; Wed, 01 Dec 2021 07:28:32 -0500 Received: from eggs.gnu.org ([209.51.188.92]:50840) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1msOgw-0007Z6-Mp; Wed, 01 Dec 2021 07:26:30 -0500 Received: from mail08.asahi-net.or.jp ([202.224.55.48]:35216) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1msOgu-0004g2-Cc; Wed, 01 Dec 2021 07:26:30 -0500 Received: from sakura.ysato.name (ik1-413-38519.vs.sakura.ne.jp [153.127.30.23]) (Authenticated sender: PQ4Y-STU) by mail08.asahi-net.or.jp (Postfix) with ESMTPA id A4C8421781; Wed, 1 Dec 2021 21:26:23 +0900 (JST) Received: from SIOS1075.ysato.ml (al142214.dynamic.ppp.asahi-net.or.jp [111.234.142.214]) by sakura.ysato.name (Postfix) with ESMTPSA id BBEF91C0123; Wed, 1 Dec 2021 21:26:22 +0900 (JST) Date: Wed, 01 Dec 2021 21:26:22 +0900 Message-ID: <87h7bsa4up.wl-ysato@users.sourceforge.jp> From: Yoshinori Sato To: Peter Maydell Subject: Re: [PATCH for-7.0 3/4] target/rx/cpu.h: Don't include qemu-common.h In-Reply-To: <20211129200510.1233037-4-peter.maydell@linaro.org> References: <20211129200510.1233037-1-peter.maydell@linaro.org> <20211129200510.1233037-4-peter.maydell@linaro.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Received-SPF: softfail client-ip=202.224.55.48; envelope-from=ysato@users.sourceforge.jp; helo=mail08.asahi-net.or.jp X-Spam_score_int: -11 X-Spam_score: -1.2 X-Spam_bar: - X-Spam_report: (-1.2 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_SOFTFAIL=0.665 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , Taylor Simpson , qemu-arm@nongnu.org, qemu-devel@nongnu.org, Sergio Lopez Errors-To: qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org Sender: "Qemu-devel" X-TUID: SVWTxXJ6DiVt On Tue, 30 Nov 2021 05:05:09 +0900, Peter Maydell wrote: > > The qemu-common.h header is not supposed to be included from any > other header files, only from .c files (as documented in a comment at > the start of it). > > Nothing actually relies on target/rx/cpu.h including it, so we can > just drop the include. > > Signed-off-by: Peter Maydell Reviewed-by: Yoshinori Sato > --- > target/rx/cpu.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/target/rx/cpu.h b/target/rx/cpu.h > index 4ac71aec370..657db84ef0a 100644 > --- a/target/rx/cpu.h > +++ b/target/rx/cpu.h > @@ -20,7 +20,6 @@ > #define RX_CPU_H > > #include "qemu/bitops.h" > -#include "qemu-common.h" > #include "hw/registerfields.h" > #include "cpu-qom.h" > > -- > 2.25.1 > >