Re: [igt-dev] [PATCH] [i-g-t] tests/i915: Remove I915_CACHING_NONE

["Dixit, Ashutosh" <ashutosh.dixit@intel.com>]

On Sun, 18 Apr 2021 23:42:54 -0700, Dixit, Ashutosh wrote:
>
> On Sun, 18 Apr 2021 23:09:28 -0700, <viswax.krishna.raveendra.talabattula@intel.com> wrote:
> >
> > From: Viswa Krishna Raveendra Talabattula <viswax.krishna.raveendra.talabattula@intel.com>
> >
> > The userptr memory does not support I915_CACHING_NONE(no caching) level
> > as per the below commit related to i915 in the kernel
> >
> > drm/i915: Reject more ioctls for userptr, v2.
> >
> > Hence removing the cache level of I915_CACHING_NONE from the test case
>
> Instead of dropping the test should we check for -ENXIO return?

Because setting I915_CACHING_NONE on a userptr is not an unreasonable
operation, if it is not supported IMO IGT should check for an -ENXIO return
if someone tries to set I915_CACHING_NONE.

The only complication here is that this is a ABI change. So if IGT runs on
an older kernel set_caching() will return 0 whereas it will return -ENXIO
with a new kernel. There seems to be no way of determining a priori what
the expected return is.

I am copying Petri too. Checking for both 0 and -ENXIO would sort of defeat
the purpose. Also, having the IGT fail on older kernels is also probably
unacceptable.

>
> > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> > Signed-off-by: Viswa Krishna Raveendra Talabattula <viswax.krishna.raveendra.talabattula@intel.com>
> > ---
> >  tests/i915/gem_userptr_blits.c | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/tests/i915/gem_userptr_blits.c b/tests/i915/gem_userptr_blits.c
> > index aad5f141..f0c63535 100644
> > --- a/tests/i915/gem_userptr_blits.c
> > +++ b/tests/i915/gem_userptr_blits.c
> > @@ -2011,7 +2011,6 @@ static void test_sd_probe(int i915)
> >  static void test_set_caching(int i915)
> >  {
> >	const int levels[] = {
> > -		I915_CACHING_NONE,
> >		I915_CACHING_CACHED,
> >	};
> >	uint32_t handle;
> > --
> > 2.30.0
> >
> > _______________________________________________
> > igt-dev mailing list
> > igt-dev@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/igt-dev
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev