From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============6733615383544360835==" MIME-Version: 1.0 From: Michael Ellerman To: kbuild-all@lists.01.org Subject: Re: [linuxppc:next-test 150/209] arch/powerpc/mm/book3s64/radix_pgtable.c:183:6: error: no previous prototype for 'radix__change_memory_range' Date: Tue, 13 Apr 2021 23:53:51 +1000 Message-ID: <87h7kas32o.fsf@mpe.ellerman.id.au> In-Reply-To: <202104130238.fSbOYsC6-lkp@intel.com> List-Id: --===============6733615383544360835== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable kernel test robot writes: > tree: https://github.com/linuxppc/linux next-test > head: 7626ae32a84371a7790955cc086d1f570b2e14ba > commit: bd573a81312fd9d6520b1cc81a88fd29e670e1ff [150/209] powerpc/mm/64s= : Allow STRICT_KERNEL_RWX again > config: powerpc-skiroot_defconfig (attached as .config) > compiler: powerpc64le-linux-gcc (GCC) 9.3.0 > reproduce (this is a W=3D1 build): ^^^^^^^^^^^^^^^^^^^ I spent a while scratching my head over this one, before noticing this little message that this is a W=3D1 build. Do you think you could make it more obvious that it's a W=3D1 build? Ideally it would be in the subject, though maybe there's no space for it there. If not having it split out from the rest of the text might help, it's kind of lost there with all the SHAs and so on. Or I could just learn to read emails from top to bottom rather than skimming them :) cheers > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbi= n/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # https://github.com/linuxppc/linux/commit/bd573a81312fd9d6520b1c= c81a88fd29e670e1ff > git remote add linuxppc https://github.com/linuxppc/linux > git fetch --no-tags linuxppc next-test > git checkout bd573a81312fd9d6520b1cc81a88fd29e670e1ff > # save the attached .config to linux build tree > COMPILER_INSTALL_PATH=3D$HOME/0day COMPILER=3Dgcc-9.3.0 make.cros= s ARCH=3Dpowerpc = > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot > > All errors (new ones prefixed by >>): > >>> arch/powerpc/mm/book3s64/radix_pgtable.c:183:6: error: no previous prot= otype for 'radix__change_memory_range' [-Werror=3Dmissing-prototypes] > 183 | void radix__change_memory_range(unsigned long start, unsigned = long end, > | ^~~~~~~~~~~~~~~~~~~~~~~~~~ > cc1: all warnings being treated as errors > > > vim +/radix__change_memory_range +183 arch/powerpc/mm/book3s64/radix_pgta= ble.c > > 2ad452ffaaa8d2 arch/powerpc/mm/pgtable-radix.c Nicholas Piggin = 2018-02-14 181 = > 7614ff3272a115 arch/powerpc/mm/pgtable-radix.c Balbir Singh = 2017-06-29 182 #ifdef CONFIG_STRICT_KERNEL_RWX > b134bd90286dc9 arch/powerpc/mm/pgtable-radix.c Michael Ellerman = 2017-07-14 @183 void radix__change_memory_range(unsigned long start, unsig= ned long end, > b134bd90286dc9 arch/powerpc/mm/pgtable-radix.c Michael Ellerman = 2017-07-14 184 unsigned long clear) > 7614ff3272a115 arch/powerpc/mm/pgtable-radix.c Balbir Singh = 2017-06-29 185 { > 7614ff3272a115 arch/powerpc/mm/pgtable-radix.c Balbir Singh = 2017-06-29 186 unsigned long idx; > 7614ff3272a115 arch/powerpc/mm/pgtable-radix.c Balbir Singh = 2017-06-29 187 pgd_t *pgdp; > 2fb4706057bcf8 arch/powerpc/mm/book3s64/radix_pgtable.c Mike Rapoport = 2020-06-04 188 p4d_t *p4dp; > 7614ff3272a115 arch/powerpc/mm/pgtable-radix.c Balbir Singh = 2017-06-29 189 pud_t *pudp; > 7614ff3272a115 arch/powerpc/mm/pgtable-radix.c Balbir Singh = 2017-06-29 190 pmd_t *pmdp; > 7614ff3272a115 arch/powerpc/mm/pgtable-radix.c Balbir Singh = 2017-06-29 191 pte_t *ptep; > 7614ff3272a115 arch/powerpc/mm/pgtable-radix.c Balbir Singh = 2017-06-29 192 = > 7614ff3272a115 arch/powerpc/mm/pgtable-radix.c Balbir Singh = 2017-06-29 193 start =3D ALIGN_DOWN(start, PAGE_SIZE); > 7614ff3272a115 arch/powerpc/mm/pgtable-radix.c Balbir Singh = 2017-06-29 194 end =3D PAGE_ALIGN(end); // aligns up > 7614ff3272a115 arch/powerpc/mm/pgtable-radix.c Balbir Singh = 2017-06-29 195 = > b134bd90286dc9 arch/powerpc/mm/pgtable-radix.c Michael Ellerman = 2017-07-14 196 pr_debug("Changing flags on range %lx-%lx removing 0x%lx\= n", > b134bd90286dc9 arch/powerpc/mm/pgtable-radix.c Michael Ellerman = 2017-07-14 197 start, end, clear); > 7614ff3272a115 arch/powerpc/mm/pgtable-radix.c Balbir Singh = 2017-06-29 198 = > 7614ff3272a115 arch/powerpc/mm/pgtable-radix.c Balbir Singh = 2017-06-29 199 for (idx =3D start; idx < end; idx +=3D PAGE_SIZE) { > 7614ff3272a115 arch/powerpc/mm/pgtable-radix.c Balbir Singh = 2017-06-29 200 pgdp =3D pgd_offset_k(idx); > 2fb4706057bcf8 arch/powerpc/mm/book3s64/radix_pgtable.c Mike Rapoport = 2020-06-04 201 p4dp =3D p4d_offset(pgdp, idx); > 2fb4706057bcf8 arch/powerpc/mm/book3s64/radix_pgtable.c Mike Rapoport = 2020-06-04 202 pudp =3D pud_alloc(&init_mm, p4dp, idx); > 7614ff3272a115 arch/powerpc/mm/pgtable-radix.c Balbir Singh = 2017-06-29 203 if (!pudp) > 7614ff3272a115 arch/powerpc/mm/pgtable-radix.c Balbir Singh = 2017-06-29 204 continue; > d6eacedd1f0ebf arch/powerpc/mm/book3s64/radix_pgtable.c Aneesh Kumar K.V = 2019-05-14 205 if (pud_is_leaf(*pudp)) { > 7614ff3272a115 arch/powerpc/mm/pgtable-radix.c Balbir Singh = 2017-06-29 206 ptep =3D (pte_t *)pudp; > 7614ff3272a115 arch/powerpc/mm/pgtable-radix.c Balbir Singh = 2017-06-29 207 goto update_the_pte; > 7614ff3272a115 arch/powerpc/mm/pgtable-radix.c Balbir Singh = 2017-06-29 208 } > 7614ff3272a115 arch/powerpc/mm/pgtable-radix.c Balbir Singh = 2017-06-29 209 pmdp =3D pmd_alloc(&init_mm, pudp, idx); > 7614ff3272a115 arch/powerpc/mm/pgtable-radix.c Balbir Singh = 2017-06-29 210 if (!pmdp) > 7614ff3272a115 arch/powerpc/mm/pgtable-radix.c Balbir Singh = 2017-06-29 211 continue; > d6eacedd1f0ebf arch/powerpc/mm/book3s64/radix_pgtable.c Aneesh Kumar K.V = 2019-05-14 212 if (pmd_is_leaf(*pmdp)) { > 7614ff3272a115 arch/powerpc/mm/pgtable-radix.c Balbir Singh = 2017-06-29 213 ptep =3D pmdp_ptep(pmdp); > 7614ff3272a115 arch/powerpc/mm/pgtable-radix.c Balbir Singh = 2017-06-29 214 goto update_the_pte; > 7614ff3272a115 arch/powerpc/mm/pgtable-radix.c Balbir Singh = 2017-06-29 215 } > 7614ff3272a115 arch/powerpc/mm/pgtable-radix.c Balbir Singh = 2017-06-29 216 ptep =3D pte_alloc_kernel(pmdp, idx); > 7614ff3272a115 arch/powerpc/mm/pgtable-radix.c Balbir Singh = 2017-06-29 217 if (!ptep) > 7614ff3272a115 arch/powerpc/mm/pgtable-radix.c Balbir Singh = 2017-06-29 218 continue; > 7614ff3272a115 arch/powerpc/mm/pgtable-radix.c Balbir Singh = 2017-06-29 219 update_the_pte: > b134bd90286dc9 arch/powerpc/mm/pgtable-radix.c Michael Ellerman = 2017-07-14 220 radix__pte_update(&init_mm, idx, ptep, clear, 0, 0); > 7614ff3272a115 arch/powerpc/mm/pgtable-radix.c Balbir Singh = 2017-06-29 221 } > 7614ff3272a115 arch/powerpc/mm/pgtable-radix.c Balbir Singh = 2017-06-29 222 = > 7614ff3272a115 arch/powerpc/mm/pgtable-radix.c Balbir Singh = 2017-06-29 223 radix__flush_tlb_kernel_range(start, end); > 7614ff3272a115 arch/powerpc/mm/pgtable-radix.c Balbir Singh = 2017-06-29 224 } > b134bd90286dc9 arch/powerpc/mm/pgtable-radix.c Michael Ellerman = 2017-07-14 225 = > > :::::: The code at line 183 was first introduced by commit > :::::: b134bd90286dc9f2952c35a91ab405474ca9374c powerpc/mm/radix: Refacto= r radix__mark_rodata_ro() > > :::::: TO: Michael Ellerman > :::::: CC: Michael Ellerman > > --- > 0-DAY CI Kernel Test Service, Intel Corporation > https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org --===============6733615383544360835==--