From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF264C433B4 for ; Tue, 6 Apr 2021 15:59:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 969EE61177 for ; Tue, 6 Apr 2021 15:59:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239645AbhDFP7j (ORCPT ); Tue, 6 Apr 2021 11:59:39 -0400 Received: from foss.arm.com ([217.140.110.172]:45270 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231787AbhDFP7i (ORCPT ); Tue, 6 Apr 2021 11:59:38 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8F71F1063; Tue, 6 Apr 2021 08:59:30 -0700 (PDT) Received: from e113632-lin (e113632-lin.cambridge.arm.com [10.1.194.46]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 220913F792; Tue, 6 Apr 2021 08:59:29 -0700 (PDT) From: Valentin Schneider To: Dietmar Eggemann , linux-kernel@vger.kernel.org Cc: Qais Yousef , Lingutla Chandrasekhar , Peter Zijlstra , Ingo Molnar , Vincent Guittot , Morten Rasmussen , Quentin Perret , Pavan Kondeti , Rik van Riel Subject: Re: [PATCH v4 3/3] sched/fair: Introduce a CPU capacity comparison helper In-Reply-To: References: <20210401193006.3392788-1-valentin.schneider@arm.com> <20210401193006.3392788-4-valentin.schneider@arm.com> Date: Tue, 06 Apr 2021 16:59:26 +0100 Message-ID: <87h7kjo141.mognet@arm.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/04/21 17:37, Dietmar Eggemann wrote: > On 01/04/2021 21:30, Valentin Schneider wrote: >> While at it, replace group_smaller_{min, max}_cpu_capacity() with >> comparisons of the source group's min/max capacity and the destination >> CPU's capacity. > > IMHO, you haven't mentioned why you replace local sched group with dst > CPU. I can see that only the capacity of the dst CPU makes really sense > here. Might be worth mentioning in the patch header why. There is some > of it in v3 6/7 but that's a different change. > Right, some of it got lost in the shuffling. This was a separate change in v1 (4/8). I can reuse that changelog into: """ Also note that comparing capacity extrema of local and source sched_group's doesn't make much sense when at the day of the day the imbalance will be pulled by a known env->dst_cpu, whose capacity can be anywhere within the local group's capacity extrema. While at it, replace group_smaller_{min, max}_cpu_capacity() with comparisons of the source group's min/max capacity and the destination CPU's capacity. """ > Reviewed-by: Dietmar Eggemann > > [...]