From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a19:690d:0:0:0:0:0 with SMTP id e13csp577924lfc; Sun, 7 Feb 2021 10:20:39 -0800 (PST) X-Google-Smtp-Source: ABdhPJxnHAJozoSqsQCZZAJmXVR4S1yiOeHWOw9EcbdJo2d1hpIkQ5MGnusZK1BCS2lxdkYa3Iqg X-Received: by 2002:a25:d4c7:: with SMTP id m190mr20545890ybf.174.1612722039111; Sun, 07 Feb 2021 10:20:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612722039; cv=none; d=google.com; s=arc-20160816; b=aUDVddy1A9TlWF2FD0pvPTPAMao2h4ytFKjqXnjyKnOGlA+mIPzziHsmrs6nSASFLU ogoV6VrdD7AL4I1iZnbVksF2VP/ii+PVifAQ8WnzhClqUN9IPFJY+Au9uhJAh+TE9lXR Wl5sz06/ayEYxZjvdu495fG4yRzFUIgxf0T77V+hqbXoK6/ILb2E095/81IO4W0B1w5t tDKgA7H5MzWO8kCCHItjzqNqJpvtDkDkyPujbilTt7YNOxnLtZUsZAcbUjZcQEKctFdj PI+3OMQOFUN/ta/ljfVGr+5BBeeDIbhnaGrMegky4LHlccMX0Feb7tdF5hThZqiNxqGE 2n7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:mime-version:message-id:date :references:in-reply-to:subject:to:from:dkim-signature; bh=Yzm2ZezDCsTtBxsoXfX3fPy21+VG1rAeGqrB/lS/s60=; b=OmXr0zAsNlTbuSl3KgdF10/G/ImvObBjJoW3yQUZ6uy1rL9k1d6L/RuI1eClcHWf6x Zq7DI2mSgoLeShZ/jyCe5EyKzxnKDFpkO8dSZ7KiaOpiiIYJe+h5sV2VpS9Xozt8s/Po 5CwHajeEr2gDS1wfH45/h1imiLKtrzFSrczW/GTEXul+MwW9vFhRetgaexiwfF5hrrOM ndyjdK6k2W26eH2VJY5TlcN3nAn8mi5DiS1GAkmIKlWmawkx9s92R0W6pC/12uzmsDR+ epxouSrjyrXwJATyCotAcsMHBIZfuHvCBWO8awk8TiySF1oonzAcp+ZFTTnikDl0ogDH sMyQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mutex.one header.s=default header.b=KR4iZygl; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org" Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id n5si16158123ybo.226.2021.02.07.10.20.38 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sun, 07 Feb 2021 10:20:39 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@mutex.one header.s=default header.b=KR4iZygl; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org" Received: from localhost ([::1]:57876 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l8ofm-0003dB-CB for alex.bennee@linaro.org; Sun, 07 Feb 2021 13:20:38 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:54072) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l8off-0003bK-5X; Sun, 07 Feb 2021 13:20:31 -0500 Received: from mail.mutex.one ([62.77.152.124]:47078) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l8ofd-0002qg-Ju; Sun, 07 Feb 2021 13:20:30 -0500 Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.mutex.one (Postfix) with ESMTP id 3C8B4BF441E3; Sun, 7 Feb 2021 20:20:25 +0200 (EET) X-Virus-Scanned: Debian amavisd-new at mail.mutex.one Received: from mail.mutex.one ([127.0.0.1]) by localhost (mail.mutex.one [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id NRUtSAJ81Slr; Sun, 7 Feb 2021 20:20:24 +0200 (EET) Received: [127.0.0.1] (localhost [127.0.0.1])nknown [79.112.103.255]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mutex.one (Postfix) with ESMTPSA id 7CD0BBF441E2; Sun, 7 Feb 2021 20:20:24 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=mutex.one; s=default; t=1612722024; bh=693iw3gbALaml7e0wrgJtTtezq/JTq5YEQaiIrvzsBI=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=KR4iZygl7T51qvE3oM4697+fBxAd95K8QoPDrMgog+13tyKEFDHEvrdlTcize02s7 NePXnkVYUaPVH3mzqtYopc61CPHt0E5rSbZIrRDVMQPp3n1UqFh3G4Ad+9VUyj1tyo SO4qprBojlpiQR69/kZ4TAbb6nB/T7iV54LES194= From: Marian Postevca To: "Michael S. Tsirkin" Subject: Re: [PATCH v4 2/5] acpi: Permit OEM ID and OEM table ID fields to be changed In-Reply-To: <20210205082049-mutt-send-email-mst@kernel.org> References: <20210119003216.17637-1-posteuca@mutex.one> <20210119003216.17637-3-posteuca@mutex.one> <20210205082049-mutt-send-email-mst@kernel.org> Date: Sun, 07 Feb 2021 20:23:33 +0200 Message-ID: <87h7mnzqhm.fsf@mutex.one> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=62.77.152.124; envelope-from=posteuca@mutex.one; helo=mail.mutex.one X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Sergio Lopez , Eduardo Habkost , Ben Warren , Richard Henderson , qemu-devel@nongnu.org, Dongjiu Geng , Shannon Zhao , Xiang Zheng , qemu-arm@nongnu.org, Marcel Apfelbaum , Igor Mammedov , Paolo Bonzini , Xiao Guangrong Errors-To: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Sender: "Qemu-arm" X-TUID: NOI9jMnviyxv "Michael S. Tsirkin" writes: > > > I queued this but there's a lot of code duplication with this. > Further, the use of g_strdup adds unnecessary dynamic memory > management where it's not needed. > I'd prefer > - a new struct AcpiBuildOem including the correct strings > - use sizeof of fields in above instead of 8/6 > - move shared strings and code into a common header > So how should I approach this since the patches are queued? A new patch with the suggested changes, or resending the original patches? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D75FFC433DB for ; Sun, 7 Feb 2021 18:21:27 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 29DE464DD4 for ; Sun, 7 Feb 2021 18:21:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 29DE464DD4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mutex.one Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:59944 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l8ogY-0004Vs-7z for qemu-devel@archiver.kernel.org; Sun, 07 Feb 2021 13:21:26 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:54072) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l8off-0003bK-5X; Sun, 07 Feb 2021 13:20:31 -0500 Received: from mail.mutex.one ([62.77.152.124]:47078) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l8ofd-0002qg-Ju; Sun, 07 Feb 2021 13:20:30 -0500 Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.mutex.one (Postfix) with ESMTP id 3C8B4BF441E3; Sun, 7 Feb 2021 20:20:25 +0200 (EET) X-Virus-Scanned: Debian amavisd-new at mail.mutex.one Received: from mail.mutex.one ([127.0.0.1]) by localhost (mail.mutex.one [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id NRUtSAJ81Slr; Sun, 7 Feb 2021 20:20:24 +0200 (EET) Received: [127.0.0.1] (localhost [127.0.0.1])nknown [79.112.103.255]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mutex.one (Postfix) with ESMTPSA id 7CD0BBF441E2; Sun, 7 Feb 2021 20:20:24 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=mutex.one; s=default; t=1612722024; bh=693iw3gbALaml7e0wrgJtTtezq/JTq5YEQaiIrvzsBI=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=KR4iZygl7T51qvE3oM4697+fBxAd95K8QoPDrMgog+13tyKEFDHEvrdlTcize02s7 NePXnkVYUaPVH3mzqtYopc61CPHt0E5rSbZIrRDVMQPp3n1UqFh3G4Ad+9VUyj1tyo SO4qprBojlpiQR69/kZ4TAbb6nB/T7iV54LES194= From: Marian Postevca To: "Michael S. Tsirkin" Subject: Re: [PATCH v4 2/5] acpi: Permit OEM ID and OEM table ID fields to be changed In-Reply-To: <20210205082049-mutt-send-email-mst@kernel.org> References: <20210119003216.17637-1-posteuca@mutex.one> <20210119003216.17637-3-posteuca@mutex.one> <20210205082049-mutt-send-email-mst@kernel.org> Date: Sun, 07 Feb 2021 20:23:33 +0200 Message-ID: <87h7mnzqhm.fsf@mutex.one> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=62.77.152.124; envelope-from=posteuca@mutex.one; helo=mail.mutex.one X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Sergio Lopez , Eduardo Habkost , Ben Warren , Richard Henderson , qemu-devel@nongnu.org, Dongjiu Geng , Shannon Zhao , Xiang Zheng , qemu-arm@nongnu.org, Igor Mammedov , Paolo Bonzini , Xiao Guangrong Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" "Michael S. Tsirkin" writes: > > > I queued this but there's a lot of code duplication with this. > Further, the use of g_strdup adds unnecessary dynamic memory > management where it's not needed. > I'd prefer > - a new struct AcpiBuildOem including the correct strings > - use sizeof of fields in above instead of 8/6 > - move shared strings and code into a common header > So how should I approach this since the patches are queued? A new patch with the suggested changes, or resending the original patches?