From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1l6XJI-0000Bp-E8 for mharc-qemu-riscv@gnu.org; Mon, 01 Feb 2021 06:24:00 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:46356) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l6XJG-00006F-AO for qemu-riscv@nongnu.org; Mon, 01 Feb 2021 06:23:58 -0500 Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]:37991) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l6XJD-0005nR-6m for qemu-riscv@nongnu.org; Mon, 01 Feb 2021 06:23:58 -0500 Received: by mail-wr1-x436.google.com with SMTP id s7so13162304wru.5 for ; Mon, 01 Feb 2021 03:23:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=references:user-agent:from:to:cc:subject:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=VG2MkLTxQ8I9Lh2My8ckgoRpl+QGsj89Svq3u+71jtM=; b=uqhLBTJXxZ3pjNuqmMtA4g6zVtYAgI0jUn7/LjW/N48ZRU4eCupg9bC33xdJH2i8CE e7yDcvj2QjqJ5I/8q/kf+1ZetXr1n3KGJCDF3+Ka3xe+mzSUMtFQnNtb8XPce19Xlc86 HYM11n4fpVvF0zvgYDZ0/ZtK17aGEFhJnR+PsuZ9mOwiwGbp/aBfFrAgcs85MF4wn4Un W21I7UZf8KuwQv34WkxUhdFHVRclbshgEjn9vchDsiPo4G16RAwicRUN+ZTEMjLvtjBm lUSCreb+RTcmu7mYiij77Yr5dU3xJBK+eiEtmZV/TW59KEjAOePru1kTchhQw400YQ16 BsGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject:date :in-reply-to:message-id:mime-version:content-transfer-encoding; bh=VG2MkLTxQ8I9Lh2My8ckgoRpl+QGsj89Svq3u+71jtM=; b=ohB4G/WsnMtxZLTHkt+xUsJjUF+6YCW2OL3oeaDg6DVt6ND8c9w168kG3+rGxPq2fK JLKmApv01tTgw2fOcud+Lrk9WMbsiLbFLOp4H/3qMPvHLbH0E1/2RHNVKxQ7s6b7jXn8 50AmL5ndfCNa4nY2dyxyiyzCBSjO5bvsTsVMiNw1J++vLRIcHHP2RSCh3kl/ioRCOh3D QYmr7aTJZpqqcbWbb+xHeNnkwPLKsyTQ5ZkDsA3mCyQi9cjWNlqGnrD8FChPPwvSN//R H8/7+/w5MOu613c3lFkQra0itPPE8vSIBVz5QfJlUiMfoM0hzxmR8NKsnXwaB6cqHZLW XqjQ== X-Gm-Message-State: AOAM533QfQDHK0RrESskU+JKZdt4oHIkzQ1AvYlgH+yaqyIjHA+28QCR bMs0AOpNewt8h0RUYrz+w19Duw== X-Google-Smtp-Source: ABdhPJw6TPMyi3QFNqPL/uipqnujiOz6+tjmGAeo8OnvCOHoEflC3JwnExynghCm0BKPzq5/PNm5AA== X-Received: by 2002:adf:dd92:: with SMTP id x18mr17893772wrl.4.1612178633587; Mon, 01 Feb 2021 03:23:53 -0800 (PST) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id u3sm28397960wre.54.2021.02.01.03.23.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Feb 2021 03:23:52 -0800 (PST) Received: from zen (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 93CBE1FF7E; Mon, 1 Feb 2021 11:23:51 +0000 (GMT) References: <20210131111316.232778-1-f4bug@amsat.org> <20210131111316.232778-7-f4bug@amsat.org> User-agent: mu4e 1.5.7; emacs 28.0.50 From: Alex =?utf-8?Q?Benn=C3=A9e?= To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Cc: qemu-devel@nongnu.org, Paolo Bonzini , Sarah Harris , Max Filippov , qemu-block@nongnu.org, "Michael S. Tsirkin" , Eduardo Habkost , Laurent Vivier , Yoshinori Sato , qemu-s390x@nongnu.org, Richard Henderson , Anthony Green , Kevin Wolf , Max Reitz , Chris Wulff , Guan Xuetao , qemu-riscv@nongnu.org, David Hildenbrand , qemu-arm@nongnu.org, Marcel Apfelbaum , Mark Cave-Ayland , Michael Walle , Greg Kurz , qemu-ppc@nongnu.org, Peter Maydell , Stafford Horne , Cornelia Huck , Marek Vasut , Aleksandar Rikalo , Sagar Karandikar , Bastian Koppelmann , Jiaxun Yang , "Edgar E. Iglesias" , Thomas Huth , Artyom Tarasenko , =?utf-8?Q?Mar?= =?utf-8?Q?c-Andr=C3=A9?= Lureau , Palmer Dabbelt , Michael Rolnik , Aurelien Jarno , Alistair Francis , David Gibson Subject: Re: [PATCH 06/10] target/i386: Move SEV feature to target Kconfig Date: Mon, 01 Feb 2021 11:20:31 +0000 In-reply-to: <20210131111316.232778-7-f4bug@amsat.org> Message-ID: <87h7mwvxo8.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::436; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x436.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-riscv@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Feb 2021 11:23:58 -0000 Philippe Mathieu-Daud=C3=A9 writes: > SEV is an architecture feature, move its declaration to target/i386/. In docs/devel/kconfig.rst we make the distinction between: **subsystems**, of which **buses** are a special case **devices** **device groups** **boards** **internal elements** Are we treating architecture features as internal elements or should we add some additional words to the kconfig document before we starting to move stuff there. In fact I realise this is better directed at 5/10 so for this patch: Reviewed-by: Alex Benn=C3=A9e > > Signed-off-by: Philippe Mathieu-Daud=C3=A9 > --- > hw/i386/Kconfig | 4 ---- > target/i386/Kconfig | 4 ++++ > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/hw/i386/Kconfig b/hw/i386/Kconfig > index 7f91f30877f..3d67c172dab 100644 > --- a/hw/i386/Kconfig > +++ b/hw/i386/Kconfig > @@ -1,7 +1,3 @@ > -config SEV > - bool > - depends on KVM > - > config PC > bool > imply APPLESMC > diff --git a/target/i386/Kconfig b/target/i386/Kconfig > index ce6968906ee..27c76c554c7 100644 > --- a/target/i386/Kconfig > +++ b/target/i386/Kconfig > @@ -3,3 +3,7 @@ config I386 >=20=20 > config X86_64 > bool > + > +config SEV > + bool > + depends on KVM && I386 --=20 Alex Benn=C3=A9e From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F9FDC433DB for ; Mon, 1 Feb 2021 11:24:58 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AEAD464DA5 for ; Mon, 1 Feb 2021 11:24:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AEAD464DA5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:42132 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l6XKC-0001GL-8T for qemu-devel@archiver.kernel.org; Mon, 01 Feb 2021 06:24:56 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:46310) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l6XJE-0008Uq-VY for qemu-devel@nongnu.org; Mon, 01 Feb 2021 06:23:57 -0500 Received: from mail-wr1-x435.google.com ([2a00:1450:4864:20::435]:40686) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l6XJD-0005nT-2b for qemu-devel@nongnu.org; Mon, 01 Feb 2021 06:23:56 -0500 Received: by mail-wr1-x435.google.com with SMTP id c12so16155901wrc.7 for ; Mon, 01 Feb 2021 03:23:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=references:user-agent:from:to:cc:subject:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=VG2MkLTxQ8I9Lh2My8ckgoRpl+QGsj89Svq3u+71jtM=; b=uqhLBTJXxZ3pjNuqmMtA4g6zVtYAgI0jUn7/LjW/N48ZRU4eCupg9bC33xdJH2i8CE e7yDcvj2QjqJ5I/8q/kf+1ZetXr1n3KGJCDF3+Ka3xe+mzSUMtFQnNtb8XPce19Xlc86 HYM11n4fpVvF0zvgYDZ0/ZtK17aGEFhJnR+PsuZ9mOwiwGbp/aBfFrAgcs85MF4wn4Un W21I7UZf8KuwQv34WkxUhdFHVRclbshgEjn9vchDsiPo4G16RAwicRUN+ZTEMjLvtjBm lUSCreb+RTcmu7mYiij77Yr5dU3xJBK+eiEtmZV/TW59KEjAOePru1kTchhQw400YQ16 BsGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject:date :in-reply-to:message-id:mime-version:content-transfer-encoding; bh=VG2MkLTxQ8I9Lh2My8ckgoRpl+QGsj89Svq3u+71jtM=; b=iQ7Eyg5vASeJmbmO8twKr1dTeOal7IWk44Ywhb2qAYVi/X3+rCfv7xcVgTCzwEpif8 m2BbmYjzre5+ur7B77V6Zkyla3YQ0C32JSPOw1ZdVPwX9gumFLR08JjBsfB2J4d/zvcU OxAbaKu6vn4KEJAAI8UBTFqhQ0efD0cnv/xHISgEwoaXIbzUmjXT5/T4v+PtY3heFPnz sFk4/SatEhE6caPfieo4ckWcJseRjGu8CVExNon4MiOMH03V2EF1xnxhgBylmggxVldv iJs9I3wImQGdc2XLQT1mL79p+Mr41sThxyup3xisWLN7j+vaqNF2W95Sweug0JskZA1U Bvaw== X-Gm-Message-State: AOAM5322678bQzj2fRead6+izrAxLiY8ZclNkjgn2Drbx8psbi+rKPl+ e5ci2SUaM+Hh2uFBG9ry85TWmw== X-Google-Smtp-Source: ABdhPJw6TPMyi3QFNqPL/uipqnujiOz6+tjmGAeo8OnvCOHoEflC3JwnExynghCm0BKPzq5/PNm5AA== X-Received: by 2002:adf:dd92:: with SMTP id x18mr17893772wrl.4.1612178633587; Mon, 01 Feb 2021 03:23:53 -0800 (PST) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id u3sm28397960wre.54.2021.02.01.03.23.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Feb 2021 03:23:52 -0800 (PST) Received: from zen (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 93CBE1FF7E; Mon, 1 Feb 2021 11:23:51 +0000 (GMT) References: <20210131111316.232778-1-f4bug@amsat.org> <20210131111316.232778-7-f4bug@amsat.org> User-agent: mu4e 1.5.7; emacs 28.0.50 From: Alex =?utf-8?Q?Benn=C3=A9e?= To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Subject: Re: [PATCH 06/10] target/i386: Move SEV feature to target Kconfig Date: Mon, 01 Feb 2021 11:20:31 +0000 In-reply-to: <20210131111316.232778-7-f4bug@amsat.org> Message-ID: <87h7mwvxo8.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::435; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x435.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Sarah Harris , Cornelia Huck , Sagar Karandikar , "Michael S. Tsirkin" , Anthony Green , Mark Cave-Ayland , qemu-devel@nongnu.org, Max Filippov , Alistair Francis , "Edgar E. Iglesias" , Guan Xuetao , Marek Vasut , qemu-block@nongnu.org, David Hildenbrand , Thomas Huth , =?utf-8?Q?Mar?= =?utf-8?Q?c-Andr=C3=A9?= Lureau , Artyom Tarasenko , Aleksandar Rikalo , Eduardo Habkost , Richard Henderson , Greg Kurz , qemu-s390x@nongnu.org, qemu-arm@nongnu.org, Michael Rolnik , Stafford Horne , Palmer Dabbelt , David Gibson , Kevin Wolf , qemu-riscv@nongnu.org, Yoshinori Sato , Bastian Koppelmann , Chris Wulff , Laurent Vivier , Max Reitz , Michael Walle , qemu-ppc@nongnu.org, Paolo Bonzini , Aurelien Jarno Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Philippe Mathieu-Daud=C3=A9 writes: > SEV is an architecture feature, move its declaration to target/i386/. In docs/devel/kconfig.rst we make the distinction between: **subsystems**, of which **buses** are a special case **devices** **device groups** **boards** **internal elements** Are we treating architecture features as internal elements or should we add some additional words to the kconfig document before we starting to move stuff there. In fact I realise this is better directed at 5/10 so for this patch: Reviewed-by: Alex Benn=C3=A9e > > Signed-off-by: Philippe Mathieu-Daud=C3=A9 > --- > hw/i386/Kconfig | 4 ---- > target/i386/Kconfig | 4 ++++ > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/hw/i386/Kconfig b/hw/i386/Kconfig > index 7f91f30877f..3d67c172dab 100644 > --- a/hw/i386/Kconfig > +++ b/hw/i386/Kconfig > @@ -1,7 +1,3 @@ > -config SEV > - bool > - depends on KVM > - > config PC > bool > imply APPLESMC > diff --git a/target/i386/Kconfig b/target/i386/Kconfig > index ce6968906ee..27c76c554c7 100644 > --- a/target/i386/Kconfig > +++ b/target/i386/Kconfig > @@ -3,3 +3,7 @@ config I386 >=20=20 > config X86_64 > bool > + > +config SEV > + bool > + depends on KVM && I386 --=20 Alex Benn=C3=A9e