From: Jani Nikula <jani.nikula@linux.intel.com>
To: Jason Gunthorpe <jgg@ziepe.ca>
Cc: Saeed Mahameed <saeedm@mellanox.com>,
Masahiro Yamada <masahiroy@kernel.org>,
linux-kbuild@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
Nicolas Pitre <nico@fluxnic.net>,
narmstrong@baylibre.com, Laurent.pinchart@ideasonboard.com,
leon@kernel.org, kieran.bingham+renesas@ideasonboard.com,
jonas@kwiboo.se, airlied@linux.ie, jernej.skrabec@siol.net,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
linux-rdma@vger.kernel.org, Andrzej Hajda <a.hajda@samsung.com>
Subject: Re: [RFC PATCH 1/2] Kconfig: Introduce "uses" keyword
Date: Fri, 17 Apr 2020 17:01:18 +0300 [thread overview]
Message-ID: <87h7xi2oup.fsf@intel.com> (raw)
In-Reply-To: <20200417122827.GD5100@ziepe.ca>
On Fri, 17 Apr 2020, Jason Gunthorpe <jgg@ziepe.ca> wrote:
> On Fri, Apr 17, 2020 at 09:23:59AM +0300, Jani Nikula wrote:
>
>> Which means that would have to split up to two. Not ideal, but
>> doable.
>
> Why is this not ideal?
>
> I think the one per line is easier to maintain (eg for merge
> conflicts) and easier to read than a giant && expression.
>
> I would not complicate things further by extending the boolean
> language..
Fair enough. I only found one instance where the patch at hand does not
cut it:
drivers/hwmon/Kconfig: depends on !OF || IIO=n || IIO
That can of course be left as it is.
As to the bikeshedding topic, I think I'm now leaning towards Andrzej's
suggestion:
optionally depends on FOO
in [1]. But I reserve my right to change my mind. ;)
BR,
Jani.
[1] http://lore.kernel.org/r/01f964ae-9c32-7531-1f07-2687616b6a71@samsung.com
--
Jani Nikula, Intel Open Source Graphics Center
next prev parent reply other threads:[~2020-04-17 14:01 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-17 1:11 [RFC PATCH 1/2] Kconfig: Introduce "uses" keyword Saeed Mahameed
2020-04-17 1:11 ` [RFC PATCH 2/2] net/mlx5: Kconfig: Use "uses" instead of "imply" Saeed Mahameed
2020-04-17 8:08 ` Arnd Bergmann
2020-04-17 6:23 ` [RFC PATCH 1/2] Kconfig: Introduce "uses" keyword Jani Nikula
2020-04-17 6:23 ` Jani Nikula
2020-04-17 12:28 ` Jason Gunthorpe
2020-04-17 14:01 ` Jani Nikula [this message]
2020-04-17 14:07 ` Jason Gunthorpe
2020-04-17 10:24 ` Arnd Bergmann
2020-04-17 11:35 ` Saeed Mahameed
2020-04-18 19:00 ` Masahiro Yamada
2020-04-18 19:11 ` Nicolas Pitre
2020-04-18 20:07 ` Masahiro Yamada
2020-04-20 8:43 ` Jani Nikula
2020-04-20 18:42 ` Jakub Kicinski
2020-04-21 4:24 ` Saeed Mahameed
2020-04-21 13:58 ` Nicolas Pitre
2020-04-21 16:30 ` Saeed Mahameed
2020-04-21 18:23 ` Nicolas Pitre
2020-04-22 8:51 ` Jani Nikula
2020-04-22 8:51 ` Jani Nikula
2020-04-22 21:13 ` Nicolas Pitre
2020-04-22 22:37 ` Randy Dunlap
2020-04-23 15:01 ` Nicolas Pitre
2020-04-23 15:05 ` Jason Gunthorpe
2020-04-23 15:11 ` Nicolas Pitre
2020-04-23 15:16 ` Jason Gunthorpe
2020-04-23 15:28 ` Arnd Bergmann
2020-04-23 15:33 ` Nicolas Pitre
2020-04-23 18:30 ` Jason Gunthorpe
2020-04-23 18:52 ` Nicolas Pitre
2020-04-20 13:53 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h7xi2oup.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=a.hajda@samsung.com \
--cc=airlied@linux.ie \
--cc=arnd@arndb.de \
--cc=jernej.skrabec@siol.net \
--cc=jgg@ziepe.ca \
--cc=jonas@kwiboo.se \
--cc=kieran.bingham+renesas@ideasonboard.com \
--cc=leon@kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=narmstrong@baylibre.com \
--cc=netdev@vger.kernel.org \
--cc=nico@fluxnic.net \
--cc=saeedm@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.