All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: "Marc-André Lureau" <marcandre.lureau@redhat.com>
Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org,
	samuel.thibault@ens-lyon.org
Subject: Re: [PULL v3 1/1] slirp: update submodule to v4.2.0+
Date: Mon, 23 Mar 2020 11:39:39 +0000	[thread overview]
Message-ID: <87h7yfb8qs.fsf@linaro.org> (raw)
In-Reply-To: <20200322171635.678219-2-marcandre.lureau@redhat.com>


Marc-André Lureau <marcandre.lureau@redhat.com> writes:

> git shortlog
> 126c04acbabd7ad32c2b018fe10dfac2a3bc1210..55ab21c9a36852915b81f1b41ebaf3b6509dd8ba
>
<snip>
>       build-sys: make libslirp-version.h depend on Makefile

FWIW I ran into a build error when I updated to the latest tree. It was
failing while building version.o. In the end I tracked it down to a
duplicate of slirp/src/libslirp-version.h (one in the build tree and one
in the src tree). I didn't spot it for a while because git was telling
me the tree was clean because of .gitignore:

  /src/libslirp-version.h

Is this stale now? Is slirp always built out of tree?

-- 
Alex Bennée


  reply	other threads:[~2020-03-23 11:40 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-22 17:16 [PULL v3 0/1] Slirp patches Marc-André Lureau
2020-03-22 17:16 ` [PULL v3 1/1] slirp: update submodule to v4.2.0+ Marc-André Lureau
2020-03-23 11:39   ` Alex Bennée [this message]
2020-03-23 11:49     ` Marc-André Lureau
2020-03-23  8:55 ` [PULL v3 0/1] Slirp patches Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h7yfb8qs.fsf@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=marcandre.lureau@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=samuel.thibault@ens-lyon.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.