All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: Cleber Rosa <crosa@redhat.com>
Cc: "Fam Zheng" <fam@euphon.net>,
	"Peter Maydell" <peter.maydell@linaro.org>,
	"Thomas Huth" <thuth@redhat.com>,
	"Beraldo Leal" <bleal@redhat.com>,
	"Erik Skultety" <eskultet@redhat.com>,
	"Wainer Moschetta" <wmoschet@redhat.com>,
	qemu-devel@nongnu.org,
	"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
	"Willian Rampazzo" <wrampazz@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>,
	"Eduardo Habkost" <ehabkost@redhat.com>
Subject: Re: [PATCH 2/5] tests/docker: make "buildah bud" output similar to "docker build"
Date: Sat, 14 Mar 2020 15:26:57 +0000	[thread overview]
Message-ID: <87h7yrneim.fsf@linaro.org> (raw)
In-Reply-To: <20200312193616.438922-3-crosa@redhat.com>


Cleber Rosa <crosa@redhat.com> writes:

> Podman users will most often be using buildah to build containers.
> Among the differences between "buildah bud|build-using-dockerfile" and
> a traditional "docker build" is that buildah does not run a container
> during build.
>
> To the best of my knowledge and experiments, this means that runtime
> variables, such as ENV from one base image will not propagate into
> another.  The end result is that the location for the cross compiler
> binaries, defined in the base "qemu/debian9-mxe" image, are not passed
> through this image.  Consequently, the cross compilers are not on PATH
> and the build fails.
>
> Signed-off-by: Cleber Rosa <crosa@redhat.com>

Acked-by: Alex Bennée <alex.bennee@linaro.org>

> ---
>  tests/docker/dockerfiles/debian-win32-cross.docker | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/docker/dockerfiles/debian-win32-cross.docker b/tests/docker/dockerfiles/debian-win32-cross.docker
> index 9d7053e59d..d16d6431bc 100644
> --- a/tests/docker/dockerfiles/debian-win32-cross.docker
> +++ b/tests/docker/dockerfiles/debian-win32-cross.docker
> @@ -9,7 +9,7 @@ MAINTAINER Philippe Mathieu-Daudé <f4bug@amsat.org>
>  
>  ENV TARGET i686
>  
> -ENV PATH $PATH:/usr/lib/mxe/usr/$TARGET-w64-mingw32.shared/bin
> +ENV PATH $PATH:/usr/lib/mxe/usr/bin:/usr/lib/mxe/usr/$TARGET-w64-mingw32.shared/bin
>  
>  ENV PKG_CONFIG_PATH \
>      $PKG_CONFIG_PATH:/usr/lib/mxe/usr/$TARGET-w64-mingw32.shared/lib/pkgconfig


-- 
Alex Bennée


  reply	other threads:[~2020-03-14 15:27 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-12 19:36 [PATCH 0/5] QEMU Gating CI Cleber Rosa
2020-03-12 19:36 ` [PATCH 1/5] tests/docker: add CentOS 8 Dockerfile Cleber Rosa
2020-03-13  8:46   ` Erik Skultety
2020-03-13 14:06     ` Alex Bennée
2020-03-13 14:59     ` Cleber Rosa
2020-03-13 14:07   ` Alex Bennée
2020-03-12 19:36 ` [PATCH 2/5] tests/docker: make "buildah bud" output similar to "docker build" Cleber Rosa
2020-03-14 15:26   ` Alex Bennée [this message]
2020-03-12 19:36 ` [PATCH 3/5] GitLab CI: avoid calling before_scripts on unintended jobs Cleber Rosa
2020-03-12 19:36 ` [PATCH 4/5] GitLab Gating CI: introduce pipeline-status contrib script Cleber Rosa
2020-03-13 13:56   ` Peter Maydell
2020-03-13 15:01     ` Cleber Rosa
2020-06-18 11:45   ` Daniel P. Berrangé
2020-06-22 14:20     ` Cleber Rosa
2020-06-23 17:59       ` Cleber Rosa
2020-07-02  8:55         ` Philippe Mathieu-Daudé
2020-03-12 19:36 ` [PATCH 5/5] GitLab Gating CI: initial set of jobs, documentation and scripts Cleber Rosa
2020-03-12 22:00 ` [PATCH 0/5] QEMU Gating CI Peter Maydell
2020-03-12 22:16   ` Cleber Rosa
2020-03-13 13:55     ` Peter Maydell
2020-03-13 14:58       ` Cleber Rosa
2020-03-16 11:57     ` Peter Maydell
2020-03-16 12:04       ` Cleber Rosa
2020-03-16 12:12         ` Peter Maydell
2020-03-16 12:26           ` Cleber Rosa
2020-03-16 12:30             ` Cleber Rosa
2020-03-16 14:57             ` Peter Maydell
2020-03-17  4:59               ` Cleber Rosa
2020-03-17  9:29                 ` Peter Maydell
2020-03-17 14:12                   ` Cleber Rosa
2020-03-17 14:24                     ` Peter Maydell
2020-03-19 16:33                       ` Markus Armbruster
2020-03-19 23:53                         ` Cleber Rosa
2020-04-21 12:53                         ` Peter Maydell
2020-04-23 17:04                           ` Cleber Rosa
2020-04-23 17:13                             ` Daniel P. Berrangé
2020-04-23 17:36                               ` Cleber Rosa
2020-04-23 17:50                                 ` Peter Maydell
2020-04-27  4:43                                   ` Cleber Rosa
2020-04-24  9:30                                 ` Daniel P. Berrangé
2020-04-24  9:39                                   ` Philippe Mathieu-Daudé
2020-04-27  5:36                                   ` Cleber Rosa
2020-04-23 21:28                               ` Philippe Mathieu-Daudé
2020-04-24  6:57                                 ` Erik Skultety
2020-04-27  5:24                                   ` Cleber Rosa
2020-04-27  8:51                                     ` Andrea Bolognani
2020-04-27  5:12                                 ` Cleber Rosa
2020-04-27 10:51                                   ` Philippe Mathieu-Daudé
2020-04-27 14:28                                     ` Cleber Rosa
2020-04-27 14:41                                       ` Philippe Mathieu-Daudé
2020-04-27 15:19                                         ` Cleber Rosa
2020-04-27 15:20                                         ` Daniel P. Berrangé
2020-06-16  1:27                             ` Cleber Rosa
2020-03-16 12:38 ` Daniel P. Berrangé
2020-03-16 12:46   ` Cleber Rosa
2020-03-16 13:11   ` Alex Bennée
2020-03-16 15:38     ` Aleksandar Markovic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h7yrneim.fsf@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=bleal@redhat.com \
    --cc=crosa@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=eskultet@redhat.com \
    --cc=fam@euphon.net \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    --cc=wainersm@redhat.com \
    --cc=wmoschet@redhat.com \
    --cc=wrampazz@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.