From: Baruch Siach <baruch@tkos.co.il>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/fail2ban: The (host-python3) 2to3 utility needs to be present
Date: Wed, 26 Feb 2020 10:41:59 +0200 [thread overview]
Message-ID: <87h7zdoi3s.fsf@tarshish> (raw)
In-Reply-To: <20200226082818.5066-1-p.debruijn@unilogic.nl>
Hi Pascal,
On Wed, Feb 26 2020, Pascal de Bruijn wrote:
> During _POST_PATCH_HOOKS _DEPENDANCIES aren't guaranteed to be built,
> however during _PRE_CONFIGURE_HOOKS they should be built.
>
> Should fix:
> http://autobuild.buildroot.net/results/dd8e225e2a49cfa6735bed11459007003a37c137/
> http://autobuild.buildroot.net/results/e688c3652bd474ac682984e2e5947701942f0f57/
Thanks for following up on this.
> Cc: Baruch Siach <baruch@tkos.co.il>
> Signed-off-by: Pascal de Bruijn <p.debruijn@unilogic.nl>
> ---
> package/fail2ban/fail2ban.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/fail2ban/fail2ban.mk b/package/fail2ban/fail2ban.mk
> index 6f023b48a1..6cb77c2514 100644
> --- a/package/fail2ban/fail2ban.mk
> +++ b/package/fail2ban/fail2ban.mk
> @@ -15,7 +15,7 @@ define FAIL2BAN_PYTHON_2TO3
> $(HOST_DIR)/bin/2to3 --write --nobackups --no-diffs $(@D)/bin/* $(@D)/fail2ban
> endef
> FAIL2BAN_DEPENDENCIES += host-python3
> -FAIL2BAN_POST_PATCH_HOOKS += FAIL2BAN_PYTHON_2TO3
> +FAIL2BAN_PRE_CONFIGURE_HOOKS += FAIL2BAN_PYTHON_2TO3
As Thomas suggested please add a comment here. Something like:
# We can't use _POST_PATCH_HOOKS because dependencies are not guaranteed
# to build and install before _POST_PATCH_HOOKS run.
baruch
> endif
>
> define FAIL2BAN_FIX_DEFAULT_CONFIG
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
next prev parent reply other threads:[~2020-02-26 8:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-26 8:28 [Buildroot] [PATCH] package/fail2ban: The (host-python3) 2to3 utility needs to be present Pascal de Bruijn
2020-02-26 8:41 ` Baruch Siach [this message]
2020-02-26 15:29 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h7zdoi3s.fsf@tarshish \
--to=baruch@tkos.co.il \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.