From: Vinicius Costa Gomes <vinicius.gomes@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH v2] igc: Fix the typo in comment
Date: Tue, 21 Jan 2020 14:26:55 -0800 [thread overview]
Message-ID: <87h80o30pc.fsf@linux.intel.com> (raw)
In-Reply-To: <20200120061758.25650-1-sasha.neftin@intel.com>
Hi Sasha,
Sasha Neftin <sasha.neftin@intel.com> writes:
> Fix the typo and comment to correspond to the i225 device
> v1->v2:
> Address community comment
>
> Signed-off-by: Sasha Neftin <sasha.neftin@intel.com>
> ---
> drivers/net/ethernet/intel/igc/igc.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/intel/igc/igc.h b/drivers/net/ethernet/intel/igc/igc.h
> index 5d38d0faeced..cb1362188c2a 100644
> --- a/drivers/net/ethernet/intel/igc/igc.h
> +++ b/drivers/net/ethernet/intel/igc/igc.h
> @@ -112,7 +112,7 @@ extern char igc_driver_version[];
> #define IGC_RX_HDR_LEN IGC_RXBUFFER_256
>
> /* Transmit and receive latency (for PTP timestamps) */
> -/* FIXME: These values were estimated using the ones that i210 has as
> +/* FIXME: These values were estimated using the ones that i225 has as
> * basis, they seem to provide good numbers with ptp4l/phc2sys, but we
> * need to confirm them.
> */
If you are sending this patch, it means that I couldn't explain myself
well enough. The idea of that comment was to point out that the
documentation doesn't provide an estimate of those values, so I used the
ones from the i210 datasheet.
Cheers,
--
Vinicius
prev parent reply other threads:[~2020-01-21 22:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-20 6:17 [Intel-wired-lan] [PATCH v2] igc: Fix the typo in comment Sasha Neftin
2020-01-21 22:26 ` Vinicius Costa Gomes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h80o30pc.fsf@linux.intel.com \
--to=vinicius.gomes@intel.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.