From: Juan Quintela <quintela@redhat.com>
To: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Cc: Laurent Vivier <lvivier@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Thomas Huth <thuth@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [PATCH 2/4] multifd: Make sure that we don't do any IO after an error
Date: Wed, 18 Dec 2019 15:15:19 +0100 [thread overview]
Message-ID: <87h81x67pk.fsf@trasno.org> (raw)
In-Reply-To: <20191218135754.GG3707@work-vm> (David Alan Gilbert's message of "Wed, 18 Dec 2019 13:57:54 +0000")
"Dr. David Alan Gilbert" <dgilbert@redhat.com> wrote:
> * Juan Quintela (quintela@redhat.com) wrote:
>> Signed-off-by: Juan Quintela <quintela@redhat.com>
>
> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
>
> I wonder if the fflush's should happen anyway?
No, that is the problem that I am really trying to fix. We tried to do
a write() after we knew that we have closed it (due to error or
cancel). And we get a nice error message on the screen:
Unable to write to socket()
And everybody gets scared about that message. When we really know that
we don't want it.
In an ideal world, we would just remove ->last_error() and make every
function return errors and check return codes. But this is qemu. This
is migration. And we don't do it. Sniff.
next prev parent reply other threads:[~2019-12-18 14:16 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-18 5:04 [PATCH 0/4] Fix multifd + cancel + multifd Juan Quintela
2019-12-18 5:04 ` [PATCH 1/4] qemu-file: Don't do IO after shutdown Juan Quintela
2019-12-18 12:27 ` Dr. David Alan Gilbert
2019-12-18 14:35 ` Juan Quintela
2019-12-18 15:24 ` Dr. David Alan Gilbert
2019-12-29 18:20 ` Juan Quintela
2020-01-08 9:49 ` Dr. David Alan Gilbert
2020-01-08 12:40 ` Juan Quintela
2020-01-16 10:04 ` Juan Quintela
2019-12-18 5:04 ` [PATCH 2/4] multifd: Make sure that we don't do any IO after an error Juan Quintela
2019-12-18 13:57 ` Dr. David Alan Gilbert
2019-12-18 14:15 ` Juan Quintela [this message]
2019-12-18 5:04 ` [PATCH 3/4] migration-test: Make sure that multifd and cancel works Juan Quintela
2019-12-18 16:25 ` Dr. David Alan Gilbert
2019-12-29 18:27 ` Juan Quintela
2019-12-18 5:04 ` [PATCH 4/4] migration: Make sure that we don't call write() in case of error Juan Quintela
2019-12-18 16:33 ` Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h81x67pk.fsf@trasno.org \
--to=quintela@redhat.com \
--cc=dgilbert@redhat.com \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.