From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B027DC2D0BF for ; Wed, 18 Dec 2019 22:13:14 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7F3562467B for ; Wed, 18 Dec 2019 22:13:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7F3562467B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=keithp.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:33148 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ihhZB-0002jB-Jw for qemu-devel@archiver.kernel.org; Wed, 18 Dec 2019 17:13:13 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:56289) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ihhYV-0002Cx-Mm for qemu-devel@nongnu.org; Wed, 18 Dec 2019 17:12:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ihhYO-0008ES-Nd for qemu-devel@nongnu.org; Wed, 18 Dec 2019 17:12:30 -0500 Received: from home.keithp.com ([63.227.221.253]:34876 helo=elaine.keithp.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ihhYO-0008BC-Hf for qemu-devel@nongnu.org; Wed, 18 Dec 2019 17:12:24 -0500 Received: from localhost (localhost [127.0.0.1]) by elaine.keithp.com (Postfix) with ESMTP id B0B513F2A0A6; Wed, 18 Dec 2019 14:12:12 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at keithp.com Received: from elaine.keithp.com ([127.0.0.1]) by localhost (elaine.keithp.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id ERxuSXDkITRp; Wed, 18 Dec 2019 14:12:12 -0800 (PST) Received: from keithp.com (koto.keithp.com [10.0.0.2]) by elaine.keithp.com (Postfix) with ESMTPSA id 4F9723F2A0A4; Wed, 18 Dec 2019 14:12:12 -0800 (PST) Received: by keithp.com (Postfix, from userid 1000) id 094161582169; Wed, 18 Dec 2019 14:12:12 -0800 (PST) From: "Keith Packard" To: Alex =?utf-8?Q?Benn=C3=A9e?= , qemu-devel@nongnu.org Subject: Re: [PATCH v1 0/4] semihosting read console support In-Reply-To: <20191218180029.6744-1-alex.bennee@linaro.org> References: <20191218180029.6744-1-alex.bennee@linaro.org> Date: Wed, 18 Dec 2019 14:12:11 -0800 Message-ID: <87h81xz3k4.fsf@keithp.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 63.227.221.253 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: pbonzini@redhat.com, Alex =?utf-8?Q?Benn=C3=A9e?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Alex Benn=C3=A9e writes: > Hi, > > This series introduces a new "blocking" console read function for > semihosting and plumbs it in to the ARM semihosting code. The main bit > of work is Keith's patch (with a few tweaks by me). The other > preparatory patches make sure the PC is updated after semihosting > succeeds and a little bit of clean-up. > > The following patches need review > 01 - target arm remove unused EXCP_SEMIHOST leg > 02 - target arm only update pc after semihosting compl > 04 - tests tcg add a dumb as bricks semihosting consol I've reviewed all four of these patches to the best of my (limited) ability. I've also tested this with picolibc's semihosting support for cortex-m3 Reviewed-by: Keith Packard Tested-by: Keith Packard Thanks much for the rework, definitely beyond my understanding of QEMU internals. =2D-=20 =2Dkeith --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEw4O3eCVWE9/bQJ2R2yIaaQAAABEFAl36pDsACgkQ2yIaaQAA ABH56Q/7B6cTe7VThnjjyW+LuuKgsdIBo7Ikigg8F6DBhoVIs8UdJJMsLRe/VYej k9eWwFs/btgzG26p6aL1LClCTo0iElHnkcMqaLq1V2zE4gdga0oWYUQ9qjtycACL 1kAUD8iluZbf91lmU+OO8bTEtaqZ894Ig6lah53glGDkfTfDX0q+skn3rhW97jvQ b12BMuFMahFt2QpOmv5XMpFPqhqoLjm4XSGdeykIVDsyke+0o0lJRPD9RKMAMlAI iixM3nERO5eho1BbgJHNS4Th7tOixxclRjy4NRUZOZvULbbshxpqtETRze+RvhEB Bv1caDSFX7ESFtVuhp/JzA9QXFvlp0hHXnbW5mGdp6ox4d84ArJYkd6Qz5mGG3Ls YXTIa4KGGWawC7KLHRgNqsodRd07Q8JTDBtLCmZJ0SvJBwaMRpXIgGjpYIYIpIif jPqqrTXvMfTyE/Wzsbp4SH4J+bn1EMo2kH2b2uklfWVw9imJ9DiqJcEeeZNkAFCN IA+g1qZz95biI5GMBlnafkCB58o0S38KypgY7hLtaykEzqEmSrTsn15RTVI6HQxu L4nYDBFUIvpucQeE5dj38dlic89XvurjNq6qsdgFu83Zloy0Bnz7/i/DsjfUK/w1 h5ABliSyIFsZFdfD+Jraww09HiatdP0iYCb1wZTS5xfkIlVUVk8= =wx7h -----END PGP SIGNATURE----- --=-=-=--