From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA30EC00454 for ; Tue, 10 Dec 2019 18:11:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9413A20836 for ; Tue, 10 Dec 2019 18:11:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="RuEA2k0x" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727707AbfLJSL2 (ORCPT ); Tue, 10 Dec 2019 13:11:28 -0500 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:21059 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727349AbfLJSL0 (ORCPT ); Tue, 10 Dec 2019 13:11:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1576001485; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Z5XSliwwrq9s/hk+XiIILzS+SOwRs74eCD9HtmMu754=; b=RuEA2k0xA+0nbeE/atc8FnZsLB7XWGPwHFWNzUJ4PhJVsc5fIV4o3IjgV8DAiUGLSudyO+ WC3CbNEaVIX+okdv8cPmNIoCN1i0FL20eY6XB4AQw9se9BGn0lFaIeSr1kP3pjq6zpaXEw GUc/52+WP8Eoz1BwYuMCHBnPLSTq7Ks= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-160-_PS3aU81PCqn6VayVSLfyg-1; Tue, 10 Dec 2019 13:11:22 -0500 Received: by mail-lf1-f71.google.com with SMTP id y4so4185651lfg.1 for ; Tue, 10 Dec 2019 10:11:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version:content-transfer-encoding; bh=Z5XSliwwrq9s/hk+XiIILzS+SOwRs74eCD9HtmMu754=; b=qhSAzgFtPhgaSgnbSPtc5UE5zDjD6IExa6X5Owl+VAF1ac3lmSBJNHGsvUnKWlKVXA rukKfbALPqU3ItMQkWBxpxDNVwyjzrDnjgNV2sh+M4BdFgpRqNV2G8hEfYM6M69eSjwI T8lr65OrzkcmsMeRLu7MswnZOO6eOqYscN7ZUyfJBgAqy3vfTM20Hra9h2/EKeuK9fXK rZNqNr6cvb0avLRtyanGW2KFEPZRvSEaIzM0g5Cctypcz5/OHyBQuE1y7nfocWGGg4VL zl+09vk/SWp6+HLDqycV0yH/8YdAw1FCS92X6xzmawogSM4Hm0PWsnXlS3Yp/Yw+97wl nqAA== X-Gm-Message-State: APjAAAUuB3uE0M66jCrVwwVkkvecW9qt2aR1nuswyV+Sfo7iQ6+uFjm3 EocDMCsi71YqaGhzTfXmwLBo5vSXlZJYljAsLH/aHgVmeBi5J9VCrtuwnJAp6rqorn3PL92RTMH WNGjkk9hDqDaz X-Received: by 2002:a19:7701:: with SMTP id s1mr18277017lfc.180.1576001481325; Tue, 10 Dec 2019 10:11:21 -0800 (PST) X-Google-Smtp-Source: APXvYqzlXgyj+NriSETPpZEMOad//9EBC6p8cMANluHa2HW2EzUm0HW2EBh2pLrV6RDm/kCCI3VsiA== X-Received: by 2002:a19:7701:: with SMTP id s1mr18276999lfc.180.1576001481132; Tue, 10 Dec 2019 10:11:21 -0800 (PST) Received: from alrua-x1.borgediget.toke.dk ([45.145.92.2]) by smtp.gmail.com with ESMTPSA id z26sm2004779lfq.69.2019.12.10.10.11.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Dec 2019 10:11:20 -0800 (PST) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id 42A66181AC8; Tue, 10 Dec 2019 19:11:18 +0100 (CET) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Martin Lau Cc: Daniel Borkmann , Alexei Starovoitov , "netdev\@vger.kernel.org" , "bpf\@vger.kernel.org" Subject: Re: [PATCH bpf] bpftool: Don't crash on missing jited insns or ksyms In-Reply-To: <20191210175915.wh7njnvt2xk64ski@kafai-mbp> References: <20191210143047.142347-1-toke@redhat.com> <20191210175915.wh7njnvt2xk64ski@kafai-mbp> X-Clacks-Overhead: GNU Terry Pratchett Date: Tue, 10 Dec 2019 19:11:18 +0100 Message-ID: <87h828giex.fsf@toke.dk> MIME-Version: 1.0 X-MC-Unique: _PS3aU81PCqn6VayVSLfyg-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org Martin Lau writes: > On Tue, Dec 10, 2019 at 03:30:47PM +0100, Toke H=C3=B8iland-J=C3=B8rgense= n wrote: >> When JIT hardening is turned on, the kernel can fail to return jited_ksy= ms > JIT hardening means net.core.bpf_jit_harden? > From the code, it happens on the bpf_dump_raw_ok() check which is > actually "kernel.kptr_restrict" instead? Ah, yeah, you're right. I was looking through the hardening patchset and the bpf_jit_harden setting was the first thing I hit upon; must admit I didn't check this too closely :) I'll send a v2 with an updated commit message... -Toke