From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Date: Fri, 29 Nov 2019 10:35:44 +0000 Subject: Re: [Intel-gfx] [PATCH v2 12/14] media: constify fb ops across all drivers Message-Id: <87h82nkm0v.fsf@intel.com> List-Id: References: <9cfc1a171d12a52dfbd5508d737681f2d89d21df.1575022735.git.jani.nikula@intel.com> In-Reply-To: <9cfc1a171d12a52dfbd5508d737681f2d89d21df.1575022735.git.jani.nikula@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org Cc: Andy Walls , Daniel Vetter , intel-gfx@lists.freedesktop.org, ivtv-devel@ivtvdriver.org, Hans Verkuil , linux-media@vger.kernel.org On Fri, 29 Nov 2019, Jani Nikula wrote: > Now that the fbops member of struct fb_info is const, we can start > making the ops const as well. > > Remove the redundant fbops assignments while at it. > > v2: > - actually add const in vivid > - fix typo (Christophe de Dinechin) > > Cc: Hans Verkuil > Cc: Andy Walls > Cc: linux-media@vger.kernel.org > Cc: ivtv-devel@ivtvdriver.org > Reviewed-by: Daniel Vetter > Signed-off-by: Jani Nikula > > fixup-to-media Rebase artefact, to be removed before applying... BR, Jani. > --- > drivers/media/pci/ivtv/ivtvfb.c | 3 +-- > drivers/media/platform/vivid/vivid-osd.c | 3 +-- > 2 files changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/media/pci/ivtv/ivtvfb.c b/drivers/media/pci/ivtv/ivtvfb.c > index 95a56cce9b65..f2922b554b09 100644 > --- a/drivers/media/pci/ivtv/ivtvfb.c > +++ b/drivers/media/pci/ivtv/ivtvfb.c > @@ -925,7 +925,7 @@ static int ivtvfb_blank(int blank_mode, struct fb_info *info) > return 0; > } > > -static struct fb_ops ivtvfb_ops = { > +static const struct fb_ops ivtvfb_ops = { > .owner = THIS_MODULE, > .fb_write = ivtvfb_write, > .fb_check_var = ivtvfb_check_var, > @@ -1049,7 +1049,6 @@ static int ivtvfb_init_vidmode(struct ivtv *itv) > > oi->ivtvfb_info.node = -1; > oi->ivtvfb_info.flags = FBINFO_FLAG_DEFAULT; > - oi->ivtvfb_info.fbops = &ivtvfb_ops; > oi->ivtvfb_info.par = itv; > oi->ivtvfb_info.var = oi->ivtvfb_defined; > oi->ivtvfb_info.fix = oi->ivtvfb_fix; > diff --git a/drivers/media/platform/vivid/vivid-osd.c b/drivers/media/platform/vivid/vivid-osd.c > index f2e789bdf4a6..fbaec8acc161 100644 > --- a/drivers/media/platform/vivid/vivid-osd.c > +++ b/drivers/media/platform/vivid/vivid-osd.c > @@ -244,7 +244,7 @@ static int vivid_fb_blank(int blank_mode, struct fb_info *info) > return 0; > } > > -static struct fb_ops vivid_fb_ops = { > +static const struct fb_ops vivid_fb_ops = { > .owner = THIS_MODULE, > .fb_check_var = vivid_fb_check_var, > .fb_set_par = vivid_fb_set_par, > @@ -311,7 +311,6 @@ static int vivid_fb_init_vidmode(struct vivid_dev *dev) > > dev->fb_info.node = -1; > dev->fb_info.flags = FBINFO_FLAG_DEFAULT; > - dev->fb_info.fbops = &vivid_fb_ops; > dev->fb_info.par = dev; > dev->fb_info.var = dev->fb_defined; > dev->fb_info.fix = dev->fb_fix; -- Jani Nikula, Intel Open Source Graphics Center From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [Intel-gfx] [PATCH v2 12/14] media: constify fb ops across all drivers Date: Fri, 29 Nov 2019 12:35:44 +0200 Message-ID: <87h82nkm0v.fsf@intel.com> References: <9cfc1a171d12a52dfbd5508d737681f2d89d21df.1575022735.git.jani.nikula@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <9cfc1a171d12a52dfbd5508d737681f2d89d21df.1575022735.git.jani.nikula@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org Cc: Andy Walls , Daniel Vetter , intel-gfx@lists.freedesktop.org, ivtv-devel@ivtvdriver.org, Hans Verkuil , linux-media@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org T24gRnJpLCAyOSBOb3YgMjAxOSwgSmFuaSBOaWt1bGEgPGphbmkubmlrdWxhQGludGVsLmNvbT4g d3JvdGU6Cj4gTm93IHRoYXQgdGhlIGZib3BzIG1lbWJlciBvZiBzdHJ1Y3QgZmJfaW5mbyBpcyBj b25zdCwgd2UgY2FuIHN0YXJ0Cj4gbWFraW5nIHRoZSBvcHMgY29uc3QgYXMgd2VsbC4KPgo+IFJl bW92ZSB0aGUgcmVkdW5kYW50IGZib3BzIGFzc2lnbm1lbnRzIHdoaWxlIGF0IGl0Lgo+Cj4gdjI6 Cj4gLSBhY3R1YWxseSBhZGQgY29uc3QgaW4gdml2aWQKPiAtIGZpeCB0eXBvIChDaHJpc3RvcGhl IGRlIERpbmVjaGluKQo+Cj4gQ2M6IEhhbnMgVmVya3VpbCA8aHZlcmt1aWxAeHM0YWxsLm5sPgo+ IENjOiBBbmR5IFdhbGxzIDxhd2FsbHNAbWQubWV0cm9jYXN0Lm5ldD4KPiBDYzogbGludXgtbWVk aWFAdmdlci5rZXJuZWwub3JnCj4gQ2M6IGl2dHYtZGV2ZWxAaXZ0dmRyaXZlci5vcmcKPiBSZXZp ZXdlZC1ieTogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBmZndsbC5jaD4KPiBTaWduZWQt b2ZmLWJ5OiBKYW5pIE5pa3VsYSA8amFuaS5uaWt1bGFAaW50ZWwuY29tPgo+Cj4gZml4dXAtdG8t bWVkaWEKClJlYmFzZSBhcnRlZmFjdCwgdG8gYmUgcmVtb3ZlZCBiZWZvcmUgYXBwbHlpbmcuLi4K CkJSLApKYW5pLgoKPiAtLS0KPiAgZHJpdmVycy9tZWRpYS9wY2kvaXZ0di9pdnR2ZmIuYyAgICAg ICAgICB8IDMgKy0tCj4gIGRyaXZlcnMvbWVkaWEvcGxhdGZvcm0vdml2aWQvdml2aWQtb3NkLmMg fCAzICstLQo+ICAyIGZpbGVzIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKSwgNCBkZWxldGlvbnMo LSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL21lZGlhL3BjaS9pdnR2L2l2dHZmYi5jIGIvZHJp dmVycy9tZWRpYS9wY2kvaXZ0di9pdnR2ZmIuYwo+IGluZGV4IDk1YTU2Y2NlOWI2NS4uZjI5MjJi NTU0YjA5IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvbWVkaWEvcGNpL2l2dHYvaXZ0dmZiLmMKPiAr KysgYi9kcml2ZXJzL21lZGlhL3BjaS9pdnR2L2l2dHZmYi5jCj4gQEAgLTkyNSw3ICs5MjUsNyBA QCBzdGF0aWMgaW50IGl2dHZmYl9ibGFuayhpbnQgYmxhbmtfbW9kZSwgc3RydWN0IGZiX2luZm8g KmluZm8pCj4gIAlyZXR1cm4gMDsKPiAgfQo+ICAKPiAtc3RhdGljIHN0cnVjdCBmYl9vcHMgaXZ0 dmZiX29wcyA9IHsKPiArc3RhdGljIGNvbnN0IHN0cnVjdCBmYl9vcHMgaXZ0dmZiX29wcyA9IHsK PiAgCS5vd25lciA9IFRISVNfTU9EVUxFLAo+ICAJLmZiX3dyaXRlICAgICAgID0gaXZ0dmZiX3dy aXRlLAo+ICAJLmZiX2NoZWNrX3ZhciAgID0gaXZ0dmZiX2NoZWNrX3ZhciwKPiBAQCAtMTA0OSw3 ICsxMDQ5LDYgQEAgc3RhdGljIGludCBpdnR2ZmJfaW5pdF92aWRtb2RlKHN0cnVjdCBpdnR2ICpp dHYpCj4gIAo+ICAJb2ktPml2dHZmYl9pbmZvLm5vZGUgPSAtMTsKPiAgCW9pLT5pdnR2ZmJfaW5m by5mbGFncyA9IEZCSU5GT19GTEFHX0RFRkFVTFQ7Cj4gLQlvaS0+aXZ0dmZiX2luZm8uZmJvcHMg PSAmaXZ0dmZiX29wczsKPiAgCW9pLT5pdnR2ZmJfaW5mby5wYXIgPSBpdHY7Cj4gIAlvaS0+aXZ0 dmZiX2luZm8udmFyID0gb2ktPml2dHZmYl9kZWZpbmVkOwo+ICAJb2ktPml2dHZmYl9pbmZvLmZp eCA9IG9pLT5pdnR2ZmJfZml4Owo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL21lZGlhL3BsYXRmb3Jt L3ZpdmlkL3ZpdmlkLW9zZC5jIGIvZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS92aXZpZC92aXZpZC1v c2QuYwo+IGluZGV4IGYyZTc4OWJkZjRhNi4uZmJhZWM4YWNjMTYxIDEwMDY0NAo+IC0tLSBhL2Ry aXZlcnMvbWVkaWEvcGxhdGZvcm0vdml2aWQvdml2aWQtb3NkLmMKPiArKysgYi9kcml2ZXJzL21l ZGlhL3BsYXRmb3JtL3ZpdmlkL3ZpdmlkLW9zZC5jCj4gQEAgLTI0NCw3ICsyNDQsNyBAQCBzdGF0 aWMgaW50IHZpdmlkX2ZiX2JsYW5rKGludCBibGFua19tb2RlLCBzdHJ1Y3QgZmJfaW5mbyAqaW5m bykKPiAgCXJldHVybiAwOwo+ICB9Cj4gIAo+IC1zdGF0aWMgc3RydWN0IGZiX29wcyB2aXZpZF9m Yl9vcHMgPSB7Cj4gK3N0YXRpYyBjb25zdCBzdHJ1Y3QgZmJfb3BzIHZpdmlkX2ZiX29wcyA9IHsK PiAgCS5vd25lciA9IFRISVNfTU9EVUxFLAo+ICAJLmZiX2NoZWNrX3ZhciAgID0gdml2aWRfZmJf Y2hlY2tfdmFyLAo+ICAJLmZiX3NldF9wYXIgICAgID0gdml2aWRfZmJfc2V0X3BhciwKPiBAQCAt MzExLDcgKzMxMSw2IEBAIHN0YXRpYyBpbnQgdml2aWRfZmJfaW5pdF92aWRtb2RlKHN0cnVjdCB2 aXZpZF9kZXYgKmRldikKPiAgCj4gIAlkZXYtPmZiX2luZm8ubm9kZSA9IC0xOwo+ICAJZGV2LT5m Yl9pbmZvLmZsYWdzID0gRkJJTkZPX0ZMQUdfREVGQVVMVDsKPiAtCWRldi0+ZmJfaW5mby5mYm9w cyA9ICZ2aXZpZF9mYl9vcHM7Cj4gIAlkZXYtPmZiX2luZm8ucGFyID0gZGV2Owo+ICAJZGV2LT5m Yl9pbmZvLnZhciA9IGRldi0+ZmJfZGVmaW5lZDsKPiAgCWRldi0+ZmJfaW5mby5maXggPSBkZXYt PmZiX2ZpeDsKCi0tIApKYW5pIE5pa3VsYSwgSW50ZWwgT3BlbiBTb3VyY2UgR3JhcGhpY3MgQ2Vu dGVyCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1k ZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczov L2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbA== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1FDDDC432C0 for ; Fri, 29 Nov 2019 10:36:01 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F3313215F1 for ; Fri, 29 Nov 2019 10:36:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F3313215F1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E44086E8D0; Fri, 29 Nov 2019 10:35:59 +0000 (UTC) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id 97EAF6E8CF; Fri, 29 Nov 2019 10:35:53 +0000 (UTC) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Nov 2019 02:35:53 -0800 X-IronPort-AV: E=Sophos;i="5.69,257,1571727600"; d="scan'208";a="212284321" Received: from jnikula-mobl3.fi.intel.com (HELO localhost) ([10.237.66.161]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Nov 2019 02:35:48 -0800 From: Jani Nikula To: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org In-Reply-To: <9cfc1a171d12a52dfbd5508d737681f2d89d21df.1575022735.git.jani.nikula@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <9cfc1a171d12a52dfbd5508d737681f2d89d21df.1575022735.git.jani.nikula@intel.com> Date: Fri, 29 Nov 2019 12:35:44 +0200 Message-ID: <87h82nkm0v.fsf@intel.com> MIME-Version: 1.0 Subject: Re: [Intel-gfx] [PATCH v2 12/14] media: constify fb ops across all drivers X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andy Walls , Daniel Vetter , intel-gfx@lists.freedesktop.org, ivtv-devel@ivtvdriver.org, Hans Verkuil , linux-media@vger.kernel.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Message-ID: <20191129103544.ZodeMPqBkyrwS18iBp8RR5ZQ_cJnhzoxEHq8h24IWBE@z> T24gRnJpLCAyOSBOb3YgMjAxOSwgSmFuaSBOaWt1bGEgPGphbmkubmlrdWxhQGludGVsLmNvbT4g d3JvdGU6Cj4gTm93IHRoYXQgdGhlIGZib3BzIG1lbWJlciBvZiBzdHJ1Y3QgZmJfaW5mbyBpcyBj b25zdCwgd2UgY2FuIHN0YXJ0Cj4gbWFraW5nIHRoZSBvcHMgY29uc3QgYXMgd2VsbC4KPgo+IFJl bW92ZSB0aGUgcmVkdW5kYW50IGZib3BzIGFzc2lnbm1lbnRzIHdoaWxlIGF0IGl0Lgo+Cj4gdjI6 Cj4gLSBhY3R1YWxseSBhZGQgY29uc3QgaW4gdml2aWQKPiAtIGZpeCB0eXBvIChDaHJpc3RvcGhl IGRlIERpbmVjaGluKQo+Cj4gQ2M6IEhhbnMgVmVya3VpbCA8aHZlcmt1aWxAeHM0YWxsLm5sPgo+ IENjOiBBbmR5IFdhbGxzIDxhd2FsbHNAbWQubWV0cm9jYXN0Lm5ldD4KPiBDYzogbGludXgtbWVk aWFAdmdlci5rZXJuZWwub3JnCj4gQ2M6IGl2dHYtZGV2ZWxAaXZ0dmRyaXZlci5vcmcKPiBSZXZp ZXdlZC1ieTogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBmZndsbC5jaD4KPiBTaWduZWQt b2ZmLWJ5OiBKYW5pIE5pa3VsYSA8amFuaS5uaWt1bGFAaW50ZWwuY29tPgo+Cj4gZml4dXAtdG8t bWVkaWEKClJlYmFzZSBhcnRlZmFjdCwgdG8gYmUgcmVtb3ZlZCBiZWZvcmUgYXBwbHlpbmcuLi4K CkJSLApKYW5pLgoKPiAtLS0KPiAgZHJpdmVycy9tZWRpYS9wY2kvaXZ0di9pdnR2ZmIuYyAgICAg ICAgICB8IDMgKy0tCj4gIGRyaXZlcnMvbWVkaWEvcGxhdGZvcm0vdml2aWQvdml2aWQtb3NkLmMg fCAzICstLQo+ICAyIGZpbGVzIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKSwgNCBkZWxldGlvbnMo LSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL21lZGlhL3BjaS9pdnR2L2l2dHZmYi5jIGIvZHJp dmVycy9tZWRpYS9wY2kvaXZ0di9pdnR2ZmIuYwo+IGluZGV4IDk1YTU2Y2NlOWI2NS4uZjI5MjJi NTU0YjA5IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvbWVkaWEvcGNpL2l2dHYvaXZ0dmZiLmMKPiAr KysgYi9kcml2ZXJzL21lZGlhL3BjaS9pdnR2L2l2dHZmYi5jCj4gQEAgLTkyNSw3ICs5MjUsNyBA QCBzdGF0aWMgaW50IGl2dHZmYl9ibGFuayhpbnQgYmxhbmtfbW9kZSwgc3RydWN0IGZiX2luZm8g KmluZm8pCj4gIAlyZXR1cm4gMDsKPiAgfQo+ICAKPiAtc3RhdGljIHN0cnVjdCBmYl9vcHMgaXZ0 dmZiX29wcyA9IHsKPiArc3RhdGljIGNvbnN0IHN0cnVjdCBmYl9vcHMgaXZ0dmZiX29wcyA9IHsK PiAgCS5vd25lciA9IFRISVNfTU9EVUxFLAo+ICAJLmZiX3dyaXRlICAgICAgID0gaXZ0dmZiX3dy aXRlLAo+ICAJLmZiX2NoZWNrX3ZhciAgID0gaXZ0dmZiX2NoZWNrX3ZhciwKPiBAQCAtMTA0OSw3 ICsxMDQ5LDYgQEAgc3RhdGljIGludCBpdnR2ZmJfaW5pdF92aWRtb2RlKHN0cnVjdCBpdnR2ICpp dHYpCj4gIAo+ICAJb2ktPml2dHZmYl9pbmZvLm5vZGUgPSAtMTsKPiAgCW9pLT5pdnR2ZmJfaW5m by5mbGFncyA9IEZCSU5GT19GTEFHX0RFRkFVTFQ7Cj4gLQlvaS0+aXZ0dmZiX2luZm8uZmJvcHMg PSAmaXZ0dmZiX29wczsKPiAgCW9pLT5pdnR2ZmJfaW5mby5wYXIgPSBpdHY7Cj4gIAlvaS0+aXZ0 dmZiX2luZm8udmFyID0gb2ktPml2dHZmYl9kZWZpbmVkOwo+ICAJb2ktPml2dHZmYl9pbmZvLmZp eCA9IG9pLT5pdnR2ZmJfZml4Owo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL21lZGlhL3BsYXRmb3Jt L3ZpdmlkL3ZpdmlkLW9zZC5jIGIvZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS92aXZpZC92aXZpZC1v c2QuYwo+IGluZGV4IGYyZTc4OWJkZjRhNi4uZmJhZWM4YWNjMTYxIDEwMDY0NAo+IC0tLSBhL2Ry aXZlcnMvbWVkaWEvcGxhdGZvcm0vdml2aWQvdml2aWQtb3NkLmMKPiArKysgYi9kcml2ZXJzL21l ZGlhL3BsYXRmb3JtL3ZpdmlkL3ZpdmlkLW9zZC5jCj4gQEAgLTI0NCw3ICsyNDQsNyBAQCBzdGF0 aWMgaW50IHZpdmlkX2ZiX2JsYW5rKGludCBibGFua19tb2RlLCBzdHJ1Y3QgZmJfaW5mbyAqaW5m bykKPiAgCXJldHVybiAwOwo+ICB9Cj4gIAo+IC1zdGF0aWMgc3RydWN0IGZiX29wcyB2aXZpZF9m Yl9vcHMgPSB7Cj4gK3N0YXRpYyBjb25zdCBzdHJ1Y3QgZmJfb3BzIHZpdmlkX2ZiX29wcyA9IHsK PiAgCS5vd25lciA9IFRISVNfTU9EVUxFLAo+ICAJLmZiX2NoZWNrX3ZhciAgID0gdml2aWRfZmJf Y2hlY2tfdmFyLAo+ICAJLmZiX3NldF9wYXIgICAgID0gdml2aWRfZmJfc2V0X3BhciwKPiBAQCAt MzExLDcgKzMxMSw2IEBAIHN0YXRpYyBpbnQgdml2aWRfZmJfaW5pdF92aWRtb2RlKHN0cnVjdCB2 aXZpZF9kZXYgKmRldikKPiAgCj4gIAlkZXYtPmZiX2luZm8ubm9kZSA9IC0xOwo+ICAJZGV2LT5m Yl9pbmZvLmZsYWdzID0gRkJJTkZPX0ZMQUdfREVGQVVMVDsKPiAtCWRldi0+ZmJfaW5mby5mYm9w cyA9ICZ2aXZpZF9mYl9vcHM7Cj4gIAlkZXYtPmZiX2luZm8ucGFyID0gZGV2Owo+ICAJZGV2LT5m Yl9pbmZvLnZhciA9IGRldi0+ZmJfZGVmaW5lZDsKPiAgCWRldi0+ZmJfaW5mby5maXggPSBkZXYt PmZiX2ZpeDsKCi0tIApKYW5pIE5pa3VsYSwgSW50ZWwgT3BlbiBTb3VyY2UgR3JhcGhpY3MgQ2Vu dGVyCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVs LWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczov L2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeA== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C11BC432C0 for ; Fri, 29 Nov 2019 10:35:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5A04E215F1 for ; Fri, 29 Nov 2019 10:35:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726791AbfK2Kfx (ORCPT ); Fri, 29 Nov 2019 05:35:53 -0500 Received: from mga17.intel.com ([192.55.52.151]:17471 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726215AbfK2Kfx (ORCPT ); Fri, 29 Nov 2019 05:35:53 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Nov 2019 02:35:53 -0800 X-IronPort-AV: E=Sophos;i="5.69,257,1571727600"; d="scan'208";a="212284321" Received: from jnikula-mobl3.fi.intel.com (HELO localhost) ([10.237.66.161]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Nov 2019 02:35:48 -0800 From: Jani Nikula To: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org Cc: Andy Walls , Daniel Vetter , intel-gfx@lists.freedesktop.org, ivtv-devel@ivtvdriver.org, Hans Verkuil , linux-media@vger.kernel.org Subject: Re: [Intel-gfx] [PATCH v2 12/14] media: constify fb ops across all drivers In-Reply-To: <9cfc1a171d12a52dfbd5508d737681f2d89d21df.1575022735.git.jani.nikula@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <9cfc1a171d12a52dfbd5508d737681f2d89d21df.1575022735.git.jani.nikula@intel.com> Date: Fri, 29 Nov 2019 12:35:44 +0200 Message-ID: <87h82nkm0v.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Fri, 29 Nov 2019, Jani Nikula wrote: > Now that the fbops member of struct fb_info is const, we can start > making the ops const as well. > > Remove the redundant fbops assignments while at it. > > v2: > - actually add const in vivid > - fix typo (Christophe de Dinechin) > > Cc: Hans Verkuil > Cc: Andy Walls > Cc: linux-media@vger.kernel.org > Cc: ivtv-devel@ivtvdriver.org > Reviewed-by: Daniel Vetter > Signed-off-by: Jani Nikula > > fixup-to-media Rebase artefact, to be removed before applying... BR, Jani. > --- > drivers/media/pci/ivtv/ivtvfb.c | 3 +-- > drivers/media/platform/vivid/vivid-osd.c | 3 +-- > 2 files changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/media/pci/ivtv/ivtvfb.c b/drivers/media/pci/ivtv/ivtvfb.c > index 95a56cce9b65..f2922b554b09 100644 > --- a/drivers/media/pci/ivtv/ivtvfb.c > +++ b/drivers/media/pci/ivtv/ivtvfb.c > @@ -925,7 +925,7 @@ static int ivtvfb_blank(int blank_mode, struct fb_info *info) > return 0; > } > > -static struct fb_ops ivtvfb_ops = { > +static const struct fb_ops ivtvfb_ops = { > .owner = THIS_MODULE, > .fb_write = ivtvfb_write, > .fb_check_var = ivtvfb_check_var, > @@ -1049,7 +1049,6 @@ static int ivtvfb_init_vidmode(struct ivtv *itv) > > oi->ivtvfb_info.node = -1; > oi->ivtvfb_info.flags = FBINFO_FLAG_DEFAULT; > - oi->ivtvfb_info.fbops = &ivtvfb_ops; > oi->ivtvfb_info.par = itv; > oi->ivtvfb_info.var = oi->ivtvfb_defined; > oi->ivtvfb_info.fix = oi->ivtvfb_fix; > diff --git a/drivers/media/platform/vivid/vivid-osd.c b/drivers/media/platform/vivid/vivid-osd.c > index f2e789bdf4a6..fbaec8acc161 100644 > --- a/drivers/media/platform/vivid/vivid-osd.c > +++ b/drivers/media/platform/vivid/vivid-osd.c > @@ -244,7 +244,7 @@ static int vivid_fb_blank(int blank_mode, struct fb_info *info) > return 0; > } > > -static struct fb_ops vivid_fb_ops = { > +static const struct fb_ops vivid_fb_ops = { > .owner = THIS_MODULE, > .fb_check_var = vivid_fb_check_var, > .fb_set_par = vivid_fb_set_par, > @@ -311,7 +311,6 @@ static int vivid_fb_init_vidmode(struct vivid_dev *dev) > > dev->fb_info.node = -1; > dev->fb_info.flags = FBINFO_FLAG_DEFAULT; > - dev->fb_info.fbops = &vivid_fb_ops; > dev->fb_info.par = dev; > dev->fb_info.var = dev->fb_defined; > dev->fb_info.fix = dev->fb_fix; -- Jani Nikula, Intel Open Source Graphics Center