From: Juan Quintela <quintela@redhat.com>
To: Wei Yang <richardw.yang@linux.intel.com>
Cc: dgilbert@redhat.com, qemu-devel@nongnu.org
Subject: Re: [PATCH 1/2] migration/multifd: clean pages after filling packet
Date: Tue, 19 Nov 2019 11:54:19 +0100 [thread overview]
Message-ID: <87h830gmqs.fsf@trasno.org> (raw)
In-Reply-To: <20191025232000.25857-2-richardw.yang@linux.intel.com> (Wei Yang's message of "Sat, 26 Oct 2019 07:19:59 +0800")
Wei Yang <richardw.yang@linux.intel.com> wrote:
> This is a preparation for the next patch:
>
> not use multifd during postcopy.
>
> Without enabling postcopy, everything looks good. While after enabling
> postcopy, migration may fail even not use multifd during postcopy. The
> reason is the pages is not properly cleared and *old* target page will
> continue to be transferred.
>
> After clean pages, migration succeeds.
>
> Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
I don't like asserts, but I understand why you put them there.
next prev parent reply other threads:[~2019-11-19 10:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-25 23:19 [PATCH 0/2] not use multifd during postcopy Wei Yang
2019-10-25 23:19 ` [PATCH 1/2] migration/multifd: clean pages after filling packet Wei Yang
2019-11-19 10:54 ` Juan Quintela [this message]
2019-10-25 23:20 ` [PATCH 2/2] migration/multifd: not use multifd during postcopy Wei Yang
2019-11-19 10:55 ` Juan Quintela
2019-11-20 0:35 ` Wei Yang
2019-11-18 1:48 ` [PATCH 0/2] " Wei Yang
2019-12-16 2:35 ` Wei Yang
2020-01-06 1:26 ` Wei Yang
2020-01-09 9:50 ` Juan Quintela
2020-01-10 2:31 ` Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h830gmqs.fsf@trasno.org \
--to=quintela@redhat.com \
--cc=dgilbert@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richardw.yang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.