From mboxrd@z Thu Jan 1 00:00:00 1970 From: Francisco Jerez Subject: Re: [PATCH v3 1/2] Revert "drm/i915/ehl: Update MOCS table for EHL" Date: Tue, 12 Nov 2019 15:15:28 -0800 Message-ID: <87h838znxr.fsf@riseup.net> References: <20191112224757.25116-1-matthew.d.roper@intel.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1201575050==" Return-path: Received: from mx1.riseup.net (mx1.riseup.net [198.252.153.129]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4410D6E02B for ; Tue, 12 Nov 2019 23:14:59 +0000 (UTC) In-Reply-To: <20191112224757.25116-1-matthew.d.roper@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Matt Roper , intel-gfx@lists.freedesktop.org Cc: Lucas De Marchi List-Id: intel-gfx@lists.freedesktop.org --===============1201575050== Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Matt Roper writes: > This reverts commit f4071997f1de016780ec6b79c63d90cd5886ee83. > > These extra EHL entries won't behave as expected without a bit more work > on the kernel side so let's drop them until that kernel work has had a > chance to land. Userspace trying to use these new entries won't get the > advantage of the new functionality these entries are meant to provide, > but at least it won't misbehave. > > When we do add these back in the future, we'll probably want to > explicitly use separate tables for ICL and EHL so that userspace > software that mistakenly uses these entries (which are undefined on ICL) > sees the same behavior it sees with all the other undefined entries. > > Cc: Francisco Jerez > Cc: Jon Bloomfield > Cc: Lucas De Marchi > Signed-off-by: Matt Roper I think f4071997f1de016780ec6b79c63d90cd5886ee83 has hit a few kernel releases already. Wouldn't it make sense to CC stable? Patch is: Reviewed-by: Francisco Jerez > --- > drivers/gpu/drm/i915/gt/intel_mocs.c | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/drivers/gpu/drm/i915/gt/intel_mocs.c b/drivers/gpu/drm/i915/= gt/intel_mocs.c > index 6e881c735b20..06e2adbf27be 100644 > --- a/drivers/gpu/drm/i915/gt/intel_mocs.c > +++ b/drivers/gpu/drm/i915/gt/intel_mocs.c > @@ -200,14 +200,6 @@ static const struct drm_i915_mocs_entry broxton_mocs= _table[] =3D { > MOCS_ENTRY(15, \ > LE_3_WB | LE_TC_1_LLC | LE_LRUM(2) | LE_AOM(1), \ > L3_3_WB), \ > - /* Bypass LLC - Uncached (EHL+) */ \ > - MOCS_ENTRY(16, \ > - LE_1_UC | LE_TC_1_LLC | LE_SCF(1), \ > - L3_1_UC), \ > - /* Bypass LLC - L3 (Read-Only) (EHL+) */ \ > - MOCS_ENTRY(17, \ > - LE_1_UC | LE_TC_1_LLC | LE_SCF(1), \ > - L3_3_WB), \ > /* Self-Snoop - L3 + LLC */ \ > MOCS_ENTRY(18, \ > LE_3_WB | LE_TC_1_LLC | LE_LRUM(3) | LE_SSE(3), \ > --=20 > 2.21.0 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEAREIAB0WIQST8OekYz69PM20/4aDmTidfVK/WwUCXcs9EAAKCRCDmTidfVK/ WwhcAQCeUIVr4XEJKJPRx/GdXudUJ9NKQvklqPJVxyOqvWxcagD7BQmS3FnlL3kX LpHcg65r5OoPVhnHoQIdVQ66wMUTPTM= =2ojo -----END PGP SIGNATURE----- --==-=-=-- --===============1201575050== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4 --===============1201575050==-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A44ECC43331 for ; Tue, 12 Nov 2019 23:15:00 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 79571214E0 for ; Tue, 12 Nov 2019 23:15:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 79571214E0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=riseup.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E4AB66E02B; Tue, 12 Nov 2019 23:14:59 +0000 (UTC) Received: from mx1.riseup.net (mx1.riseup.net [198.252.153.129]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4410D6E02B for ; Tue, 12 Nov 2019 23:14:59 +0000 (UTC) Received: from bell.riseup.net (bell-pn.riseup.net [10.0.1.178]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client CN "*.riseup.net", Issuer "Sectigo RSA Domain Validation Secure Server CA" (not verified)) by mx1.riseup.net (Postfix) with ESMTPS id 47CNr26lY2zDqX5; Tue, 12 Nov 2019 15:14:58 -0800 (PST) X-Riseup-User-ID: 16835BD9D91A203AD0E1AC66A4C006267B0B82E4A7E915AE9318FE84DDCCADAD Received: from [127.0.0.1] (localhost [127.0.0.1]) by bell.riseup.net (Postfix) with ESMTPSA id 47CNr23jFGzJqRq; Tue, 12 Nov 2019 15:14:58 -0800 (PST) From: Francisco Jerez To: Matt Roper , intel-gfx@lists.freedesktop.org In-Reply-To: <20191112224757.25116-1-matthew.d.roper@intel.com> References: <20191112224757.25116-1-matthew.d.roper@intel.com> Date: Tue, 12 Nov 2019 15:15:28 -0800 Message-ID: <87h838znxr.fsf@riseup.net> MIME-Version: 1.0 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=riseup.net; s=squak; t=1573600499; bh=mKohBKcB17DzFUh1LG8sdJKvqxWO/pjuOPV3LvYAI7E=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=F8LJhROpkOzmqmxJme85o7lvryv8jUhemeyVIiBTX8AH53X23HvdAyQBTQNWfTMaR oRlQuH/BFogf3jaQhx9S9l4MGbBjQmXSygbdpxaqps2ClLiFxoL/VyBTZ0qPt2u03b kOqO6siiYyEQMFGfvA4OivwnlM3z977YyYAVA4JY= Subject: Re: [Intel-gfx] [PATCH v3 1/2] Revert "drm/i915/ehl: Update MOCS table for EHL" X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lucas De Marchi Content-Type: multipart/mixed; boundary="===============1201575050==" Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Message-ID: <20191112231528.fcsKBHqJX5vBo4t86VumB6NkZY5u1LvMzwqOS1gsKtI@z> --===============1201575050== Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Matt Roper writes: > This reverts commit f4071997f1de016780ec6b79c63d90cd5886ee83. > > These extra EHL entries won't behave as expected without a bit more work > on the kernel side so let's drop them until that kernel work has had a > chance to land. Userspace trying to use these new entries won't get the > advantage of the new functionality these entries are meant to provide, > but at least it won't misbehave. > > When we do add these back in the future, we'll probably want to > explicitly use separate tables for ICL and EHL so that userspace > software that mistakenly uses these entries (which are undefined on ICL) > sees the same behavior it sees with all the other undefined entries. > > Cc: Francisco Jerez > Cc: Jon Bloomfield > Cc: Lucas De Marchi > Signed-off-by: Matt Roper I think f4071997f1de016780ec6b79c63d90cd5886ee83 has hit a few kernel releases already. Wouldn't it make sense to CC stable? Patch is: Reviewed-by: Francisco Jerez > --- > drivers/gpu/drm/i915/gt/intel_mocs.c | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/drivers/gpu/drm/i915/gt/intel_mocs.c b/drivers/gpu/drm/i915/= gt/intel_mocs.c > index 6e881c735b20..06e2adbf27be 100644 > --- a/drivers/gpu/drm/i915/gt/intel_mocs.c > +++ b/drivers/gpu/drm/i915/gt/intel_mocs.c > @@ -200,14 +200,6 @@ static const struct drm_i915_mocs_entry broxton_mocs= _table[] =3D { > MOCS_ENTRY(15, \ > LE_3_WB | LE_TC_1_LLC | LE_LRUM(2) | LE_AOM(1), \ > L3_3_WB), \ > - /* Bypass LLC - Uncached (EHL+) */ \ > - MOCS_ENTRY(16, \ > - LE_1_UC | LE_TC_1_LLC | LE_SCF(1), \ > - L3_1_UC), \ > - /* Bypass LLC - L3 (Read-Only) (EHL+) */ \ > - MOCS_ENTRY(17, \ > - LE_1_UC | LE_TC_1_LLC | LE_SCF(1), \ > - L3_3_WB), \ > /* Self-Snoop - L3 + LLC */ \ > MOCS_ENTRY(18, \ > LE_3_WB | LE_TC_1_LLC | LE_LRUM(3) | LE_SSE(3), \ > --=20 > 2.21.0 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEAREIAB0WIQST8OekYz69PM20/4aDmTidfVK/WwUCXcs9EAAKCRCDmTidfVK/ WwhcAQCeUIVr4XEJKJPRx/GdXudUJ9NKQvklqPJVxyOqvWxcagD7BQmS3FnlL3kX LpHcg65r5OoPVhnHoQIdVQ66wMUTPTM= =2ojo -----END PGP SIGNATURE----- --==-=-=-- --===============1201575050== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4 --===============1201575050==--