From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0DD16CA9EB9 for ; Wed, 23 Oct 2019 13:26:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E218B21925 for ; Wed, 23 Oct 2019 13:26:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391594AbfJWN0U (ORCPT ); Wed, 23 Oct 2019 09:26:20 -0400 Received: from mga14.intel.com ([192.55.52.115]:38480 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391495AbfJWN0U (ORCPT ); Wed, 23 Oct 2019 09:26:20 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Oct 2019 06:26:20 -0700 X-IronPort-AV: E=Sophos;i="5.68,221,1569308400"; d="scan'208";a="191828934" Received: from jnikula-mobl3.fi.intel.com (HELO localhost) ([10.237.66.161]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Oct 2019 06:26:16 -0700 From: Jani Nikula To: Rasmus Villemoes , linux-kernel@vger.kernel.org Cc: Joonas Lahtinen , Rodrigo Vivi , intel-gfx@lists.freedesktop.org, Vishal Kulkarni , netdev@vger.kernel.org, Greg Kroah-Hartman , linux-usb@vger.kernel.org, Andrew Morton , Julia Lawall Subject: Re: [PATCH v4] string-choice: add yesno(), onoff(), enableddisabled(), plural() helpers In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20191023131308.9420-1-jani.nikula@intel.com> Date: Wed, 23 Oct 2019 16:26:13 +0300 Message-ID: <87h83zegp6.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Wed, 23 Oct 2019, Rasmus Villemoes wrote: > On 23/10/2019 15.13, Jani Nikula wrote: >> The kernel has plenty of ternary operators to choose between constant >> strings, such as condition ? "yes" : "no", as well as value == 1 ? "" : >> "s": >> >> >> v4: Massaged commit message about space savings to make it less fluffy >> based on Rasmus' feedback. > > Thanks, it looks good to me. FWIW, > > Acked-by: Rasmus Villemoes Thanks. I think the question is, which tree to apply this to, who's going to pick it up? I'm fine with any route. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH v4] string-choice: add yesno(), onoff(), enableddisabled(), plural() helpers Date: Wed, 23 Oct 2019 16:26:13 +0300 Message-ID: <87h83zegp6.fsf@intel.com> References: <20191023131308.9420-1-jani.nikula@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id A8D4F6EAB0 for ; Wed, 23 Oct 2019 13:26:20 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Rasmus Villemoes , linux-kernel@vger.kernel.org Cc: linux-usb@vger.kernel.org, netdev@vger.kernel.org, intel-gfx@lists.freedesktop.org, Julia Lawall , Vishal Kulkarni , Greg Kroah-Hartman , Andrew Morton List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCAyMyBPY3QgMjAxOSwgUmFzbXVzIFZpbGxlbW9lcyA8bGludXhAcmFzbXVzdmlsbGVt b2VzLmRrPiB3cm90ZToKPiBPbiAyMy8xMC8yMDE5IDE1LjEzLCBKYW5pIE5pa3VsYSB3cm90ZToK Pj4gVGhlIGtlcm5lbCBoYXMgcGxlbnR5IG9mIHRlcm5hcnkgb3BlcmF0b3JzIHRvIGNob29zZSBi ZXR3ZWVuIGNvbnN0YW50Cj4+IHN0cmluZ3MsIHN1Y2ggYXMgY29uZGl0aW9uID8gInllcyIgOiAi bm8iLCBhcyB3ZWxsIGFzIHZhbHVlID09IDEgPyAiIiA6Cj4+ICJzIjoKPj4gCj4+IAo+PiB2NDog TWFzc2FnZWQgY29tbWl0IG1lc3NhZ2UgYWJvdXQgc3BhY2Ugc2F2aW5ncyB0byBtYWtlIGl0IGxl c3MgZmx1ZmZ5Cj4+IGJhc2VkIG9uIFJhc211cycgZmVlZGJhY2suCj4KPiBUaGFua3MsIGl0IGxv b2tzIGdvb2QgdG8gbWUuIEZXSVcsCj4KPiBBY2tlZC1ieTogUmFzbXVzIFZpbGxlbW9lcyA8bGlu dXhAcmFzbXVzdmlsbGVtb2VzLmRrPgoKVGhhbmtzLgoKSSB0aGluayB0aGUgcXVlc3Rpb24gaXMs IHdoaWNoIHRyZWUgdG8gYXBwbHkgdGhpcyB0bywgd2hvJ3MgZ29pbmcgdG8KcGljayBpdCB1cD8g SSdtIGZpbmUgd2l0aCBhbnkgcm91dGUuCgpCUiwKSmFuaS4KCgotLSAKSmFuaSBOaWt1bGEsIElu dGVsIE9wZW4gU291cmNlIEdyYXBoaWNzIENlbnRlcgpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBs aXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1h bi9saXN0aW5mby9pbnRlbC1nZng= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F13F6CA9EB9 for ; Wed, 23 Oct 2019 13:26:21 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D196A21925 for ; Wed, 23 Oct 2019 13:26:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D196A21925 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 817B36EAB0; Wed, 23 Oct 2019 13:26:21 +0000 (UTC) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id A8D4F6EAB0 for ; Wed, 23 Oct 2019 13:26:20 +0000 (UTC) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Oct 2019 06:26:19 -0700 X-IronPort-AV: E=Sophos;i="5.68,221,1569308400"; d="scan'208";a="191828934" Received: from jnikula-mobl3.fi.intel.com (HELO localhost) ([10.237.66.161]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Oct 2019 06:26:16 -0700 From: Jani Nikula To: Rasmus Villemoes , linux-kernel@vger.kernel.org In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20191023131308.9420-1-jani.nikula@intel.com> Date: Wed, 23 Oct 2019 16:26:13 +0300 Message-ID: <87h83zegp6.fsf@intel.com> MIME-Version: 1.0 Subject: Re: [Intel-gfx] [PATCH v4] string-choice: add yesno(), onoff(), enableddisabled(), plural() helpers X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-usb@vger.kernel.org, netdev@vger.kernel.org, intel-gfx@lists.freedesktop.org, Julia Lawall , Vishal Kulkarni , Greg Kroah-Hartman , Andrew Morton Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Message-ID: <20191023132613.0ytiiay2CJhdBEJbeMdpOEI8Fkjm-wIkNeGoecdTqCc@z> T24gV2VkLCAyMyBPY3QgMjAxOSwgUmFzbXVzIFZpbGxlbW9lcyA8bGludXhAcmFzbXVzdmlsbGVt b2VzLmRrPiB3cm90ZToKPiBPbiAyMy8xMC8yMDE5IDE1LjEzLCBKYW5pIE5pa3VsYSB3cm90ZToK Pj4gVGhlIGtlcm5lbCBoYXMgcGxlbnR5IG9mIHRlcm5hcnkgb3BlcmF0b3JzIHRvIGNob29zZSBi ZXR3ZWVuIGNvbnN0YW50Cj4+IHN0cmluZ3MsIHN1Y2ggYXMgY29uZGl0aW9uID8gInllcyIgOiAi bm8iLCBhcyB3ZWxsIGFzIHZhbHVlID09IDEgPyAiIiA6Cj4+ICJzIjoKPj4gCj4+IAo+PiB2NDog TWFzc2FnZWQgY29tbWl0IG1lc3NhZ2UgYWJvdXQgc3BhY2Ugc2F2aW5ncyB0byBtYWtlIGl0IGxl c3MgZmx1ZmZ5Cj4+IGJhc2VkIG9uIFJhc211cycgZmVlZGJhY2suCj4KPiBUaGFua3MsIGl0IGxv b2tzIGdvb2QgdG8gbWUuIEZXSVcsCj4KPiBBY2tlZC1ieTogUmFzbXVzIFZpbGxlbW9lcyA8bGlu dXhAcmFzbXVzdmlsbGVtb2VzLmRrPgoKVGhhbmtzLgoKSSB0aGluayB0aGUgcXVlc3Rpb24gaXMs IHdoaWNoIHRyZWUgdG8gYXBwbHkgdGhpcyB0bywgd2hvJ3MgZ29pbmcgdG8KcGljayBpdCB1cD8g SSdtIGZpbmUgd2l0aCBhbnkgcm91dGUuCgpCUiwKSmFuaS4KCgotLSAKSmFuaSBOaWt1bGEsIElu dGVsIE9wZW4gU291cmNlIEdyYXBoaWNzIENlbnRlcgpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBs aXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1h bi9saXN0aW5mby9pbnRlbC1nZng=