From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jani Nikula <jani.nikula@intel.com>
Subject: Re: [PATCH v8 04/10] drm/i915/dsb: Indexed register
 write function for DSB.
Date: Fri, 20 Sep 2019 12:06:16 +0300
Message-ID: <87h857uyk7.fsf@intel.com>
References: <20190920065626.3525-1-animesh.manna@intel.com>
 <20190920065626.3525-5-animesh.manna@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 215AF6FBF3
 for <intel-gfx@lists.freedesktop.org>; Fri, 20 Sep 2019 09:06:22 +0000 (UTC)
In-Reply-To: <20190920065626.3525-5-animesh.manna@intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Animesh Manna <animesh.manna@intel.com>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gRnJpLCAyMCBTZXAgMjAxOSwgQW5pbWVzaCBNYW5uYSA8YW5pbWVzaC5tYW5uYUBpbnRlbC5j
b20+IHdyb3RlOgo+IERTQiBjYW4gcHJvZ3JhbSBsYXJnZSBzZXQgb2YgZGF0YSB0aHJvdWdoIGlu
ZGV4ZWQgcmVnaXN0ZXIgd3JpdGUKPiAob3Bjb2RlIDB4OSkgaW4gb25lIHNob3QuIERTQiBmZWF0
dXJlIGNhbiBiZSB1c2VkIGZvciBidWxrIHJlZ2lzdGVyCj4gcHJvZ3JhbW1pbmcgZS5nLiBnYW1t
YSBsdXQgcHJvZ3JhbW1pbmcsIEhEUiBtZXRhIGRhdGEgcHJvZ3JhbW1pbmcuCj4KPiB2MTogaW5p
dGlhbCB2ZXJzaW9uLgo+IHYyOiBzaW1wbGlmaWVkIGNvZGUgYnkgdXNpbmcgQUxJR04oKS4gKENo
cmlzKQo+IHYzOiBhc2NpaSB0YWJsZSBhZGRlZCBhcyBjb2RlIGNvbW1lbnQuIChTaGFzaGFuaykK
PiB2NDogY29zbWV0aWMgY2hhbmdlcyBkb25lLiAoU2hhc2hhbmspCj4gdjU6IHJlc2V0IGluc19z
dGFydF9vZmZzZXQuIChKYW5pKQo+Cj4gQ2M6IFNoYXNoYW5rIFNoYXJtYSA8c2hhc2hhbmsuc2hh
cm1hQGludGVsLmNvbT4KPiBDYzogSW1yZSBEZWFrIDxpbXJlLmRlYWtAaW50ZWwuY29tPgo+IENj
OiBKYW5pIE5pa3VsYSA8amFuaS5uaWt1bGFAaW50ZWwuY29tPgo+IENjOiBSb2RyaWdvIFZpdmkg
PHJvZHJpZ28udml2aUBpbnRlbC5jb20+Cj4gUmV2aWV3ZWQtYnk6IFNoYXNoYW5rIFNoYXJtYSA8
c2hhc2hhbmsuc2hhcm1hQGludGVsLmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBBbmltZXNoIE1hbm5h
IDxhbmltZXNoLm1hbm5hQGludGVsLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUv
ZGlzcGxheS9pbnRlbF9kc2IuYyB8IDY3ICsrKysrKysrKysrKysrKysrKysrKysrKwo+ICBkcml2
ZXJzL2dwdS9kcm0vaTkxNS9kaXNwbGF5L2ludGVsX2RzYi5oIHwgIDggKysrCj4gIDIgZmlsZXMg
Y2hhbmdlZCwgNzUgaW5zZXJ0aW9ucygrKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2Ry
bS9pOTE1L2Rpc3BsYXkvaW50ZWxfZHNiLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNwbGF5
L2ludGVsX2RzYi5jCj4gaW5kZXggZjk0Y2Q2ZGM5OGI2Li4wYjUxMTkxMzVkNGQgMTAwNjQ0Cj4g
LS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pbnRlbF9kc2IuYwo+ICsrKyBiL2Ry
aXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxfZHNiLmMKPiBAQCAtMTIsOCArMTIsMTAg
QEAKPiAgLyogRFNCIG9wY29kZXMuICovCj4gICNkZWZpbmUgRFNCX09QQ09ERV9TSElGVAkJMjQK
PiAgI2RlZmluZSBEU0JfT1BDT0RFX01NSU9fV1JJVEUJCTB4MQo+ICsjZGVmaW5lIERTQl9PUENP
REVfSU5ERVhFRF9XUklURQkweDkKPiAgI2RlZmluZSBEU0JfQllURV9FTgkJCTB4Rgo+ICAjZGVm
aW5lIERTQl9CWVRFX0VOX1NISUZUCQkyMAo+ICsjZGVmaW5lIERTQl9SRUdfVkFMVUVfTUFTSwkJ
MHhmZmZmZgo+ICAKPiAgc3RydWN0IGludGVsX2RzYiAqCj4gIGludGVsX2RzYl9nZXQoc3RydWN0
IGludGVsX2NydGMgKmNydGMpCj4gQEAgLTgzLDkgKzg1LDc0IEBAIHZvaWQgaW50ZWxfZHNiX3B1
dChzdHJ1Y3QgaW50ZWxfZHNiICpkc2IpCj4gIAkJbXV0ZXhfdW5sb2NrKCZpOTE1LT5kcm0uc3Ry
dWN0X211dGV4KTsKPiAgCQlkc2ItPmNtZF9idWYgPSBOVUxMOwo+ICAJCWRzYi0+ZnJlZV9wb3Mg
PSAwOwo+ICsJCWRzYi0+aW5zX3N0YXJ0X29mZnNldCA9IDA7CgpUaGlzIGlzIG5vdCBlbm91Z2gg
dG8gYWRkcmVzcyB0aGUgc2VxdWVuY2UgSSBkZXNjcmliZWQuIFN1cmUsIHdlJ3JlIG5vdApoaXR0
aW5nIHRoZSBpc3N1ZSBub3csIGJ1dCBpdCdzIG5vdCBhIGJlbmlnbiB0aGluZy4KClNvIGltYWdp
bmUgeW91IGRvOgoKaW50ZWxfZHNiX2dldCgpCmludGVsX2RzYl9pbmRleGVkX3JlZ193cml0ZShk
c2IsIEZPTywgMCk7CmludGVsX2RzYl9pbmRleGVkX3JlZ193cml0ZShkc2IsIEZPTywgMCk7Cmlu
dGVsX2RzYl9yZWdfd3JpdGUoZHNiLCBCQVIsIDApOwppbnRlbF9kc2JfaW5kZXhlZF9yZWdfd3Jp
dGUoZHNiLCBGT08sIDApOwppbnRlbF9kc2JfY29tbWl0KCkKaW50ZWxfZHNiX3B1dCgpCgpEbyB5
b3Ugc2VlIHdoYXQgaGFwcGVucyBpbiB0aGUgbGFzdCBpbmRleGVkIHdyaXRlPyBJdCBsb29rcyBh
dCB0aGUKKmZpcnN0KiBpbmRleGVkIHdyaXRlcyBmb3Igd2hldGhlciB0aGlzIGlzIGEgY29udGlu
dWF0aW9uLCB1cGRhdGluZyB0aGUKc2l6ZSB0aGVyZSwgaWdub3JpbmcgdGhlIGZhY3QgdGhhdCB0
aGVyZSdzIHNvbWV0aGluZyBlbHNlIGluIGJldHdlZW4uCgpCUiwKSmFuaS4KCgo+ICAJfQo+ICB9
Cj4gIAo+ICt2b2lkIGludGVsX2RzYl9pbmRleGVkX3JlZ193cml0ZShzdHJ1Y3QgaW50ZWxfZHNi
ICpkc2IsIGk5MTVfcmVnX3QgcmVnLAo+ICsJCQkJIHUzMiB2YWwpCj4gK3sKPiArCXN0cnVjdCBp
bnRlbF9jcnRjICpjcnRjID0gY29udGFpbmVyX29mKGRzYiwgdHlwZW9mKCpjcnRjKSwgZHNiKTsK
PiArCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUoY3J0Yy0+YmFz
ZS5kZXYpOwo+ICsJdTMyICpidWYgPSBkc2ItPmNtZF9idWY7Cj4gKwl1MzIgcmVnX3ZhbDsKPiAr
Cj4gKwlpZiAoIWJ1Zikgewo+ICsJCUk5MTVfV1JJVEUocmVnLCB2YWwpOwo+ICsJCXJldHVybjsK
PiArCX0KPiArCj4gKwlpZiAoV0FSTl9PTihkc2ItPmZyZWVfcG9zID49IERTQl9CVUZfU0laRSkp
IHsKPiArCQlEUk1fREVCVUdfS01TKCJEU0IgYnVmZmVyIG92ZXJmbG93XG4iKTsKPiArCQlyZXR1
cm47Cj4gKwl9Cj4gKwo+ICsJLyoKPiArCSAqIEZvciBleGFtcGxlIHRoZSBidWZmZXIgd2lsbCBs
b29rIGxpa2UgYmVsb3cgZm9yIDMgZHdvcmRzIGZvciBhdXRvCj4gKwkgKiBpbmNyZW1lbnQgcmVn
aXN0ZXI6Cj4gKwkgKiArLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0rCj4gKwkgKiB8IHNpemUgPSAzIHwgb2Zmc2V0ICZ8IHZhbHVlMSB8IHZh
bHVlMiB8IHZhbHVlMyB8IHplcm8gICB8Cj4gKwkgKiB8ICAgICAgICAgIHwgb3Bjb2RlICB8ICAg
ICAgICB8ICAgICAgICB8ICAgICAgICB8ICAgICAgICB8Cj4gKwkgKiArLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0rCj4gKwkgKiArICAgICAg
ICAgICsgICAgICAgICArICAgICAgICArICAgICAgICArICAgICAgICArICAgICAgICArCj4gKwkg
KiAwICAgICAgICAgIDQgICAgICAgICA4ICAgICAgICAxMiAgICAgICAxNiAgICAgICAyMCAgICAg
ICAyNAo+ICsJICogQnl0ZQo+ICsJICoKPiArCSAqIEFzIGV2ZXJ5IGluc3RydWN0aW9uIGlzIDgg
Ynl0ZSBhbGlnbmVkIHRoZSBpbmRleCBvZiBkc2IgaW5zdHJ1Y3Rpb24KPiArCSAqIHdpbGwgc3Rh
cnQgYWx3YXlzIGZyb20gZXZlbiBudW1iZXIgd2hpbGUgZGVhbGluZyB3aXRoIHUzMiBhcnJheS4g
SWYKPiArCSAqIHdlIGFyZSB3cml0aW5nIG9kZCBubyBvZiBkd29yZHMsIFplcm9zIHdpbGwgYmUg
YWRkZWQgaW4gdGhlIGVuZCBmb3IKPiArCSAqIHBhZGRpbmcuCj4gKwkgKi8KPiArCXJlZ192YWwg
PSBidWZbZHNiLT5pbnNfc3RhcnRfb2Zmc2V0ICsgMV0gJiBEU0JfUkVHX1ZBTFVFX01BU0s7Cj4g
KwlpZiAocmVnX3ZhbCAhPSBpOTE1X21taW9fcmVnX29mZnNldChyZWcpKSB7Cj4gKwkJLyogRXZl
cnkgaW5zdHJ1Y3Rpb24gc2hvdWxkIGJlIDggYnl0ZSBhbGlnbmVkLiAqLwo+ICsJCWRzYi0+ZnJl
ZV9wb3MgPSBBTElHTihkc2ItPmZyZWVfcG9zLCAyKTsKPiArCj4gKwkJZHNiLT5pbnNfc3RhcnRf
b2Zmc2V0ID0gZHNiLT5mcmVlX3BvczsKPiArCj4gKwkJLyogVXBkYXRlIHRoZSBzaXplLiAqLwo+
ICsJCWJ1Zltkc2ItPmZyZWVfcG9zKytdID0gMTsKPiArCj4gKwkJLyogVXBkYXRlIHRoZSBvcGNv
ZGUgYW5kIHJlZy4gKi8KPiArCQlidWZbZHNiLT5mcmVlX3BvcysrXSA9IChEU0JfT1BDT0RFX0lO
REVYRURfV1JJVEUgIDw8Cj4gKwkJCQkJRFNCX09QQ09ERV9TSElGVCkgfAo+ICsJCQkJCWk5MTVf
bW1pb19yZWdfb2Zmc2V0KHJlZyk7Cj4gKwo+ICsJCS8qIFVwZGF0ZSB0aGUgdmFsdWUuICovCj4g
KwkJYnVmW2RzYi0+ZnJlZV9wb3MrK10gPSB2YWw7Cj4gKwl9IGVsc2Ugewo+ICsJCS8qIFVwZGF0
ZSB0aGUgbmV3IHZhbHVlLiAqLwo+ICsJCWJ1Zltkc2ItPmZyZWVfcG9zKytdID0gdmFsOwo+ICsK
PiArCQkvKiBVcGRhdGUgdGhlIHNpemUuICovCj4gKwkJYnVmW2RzYi0+aW5zX3N0YXJ0X29mZnNl
dF0rKzsKPiArCX0KPiArCj4gKwkvKiBpZiBudW1iZXIgb2YgZGF0YSB3b3JkcyBpcyBvZGQsIHRo
ZW4gdGhlIGxhc3QgZHdvcmQgc2hvdWxkIGJlIDAuKi8KPiArCWlmIChkc2ItPmZyZWVfcG9zICYg
MHgxKQo+ICsJCWJ1Zltkc2ItPmZyZWVfcG9zXSA9IDA7Cj4gK30KPiArCj4gIHZvaWQgaW50ZWxf
ZHNiX3JlZ193cml0ZShzdHJ1Y3QgaW50ZWxfZHNiICpkc2IsIGk5MTVfcmVnX3QgcmVnLCB1MzIg
dmFsKQo+ICB7Cj4gIAlzdHJ1Y3QgaW50ZWxfY3J0YyAqY3J0YyA9IGNvbnRhaW5lcl9vZihkc2Is
IHR5cGVvZigqY3J0YyksIGRzYik7Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1
L2Rpc3BsYXkvaW50ZWxfZHNiLmggYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNwbGF5L2ludGVs
X2RzYi5oCj4gaW5kZXggMDY4NmQ2N2IzNGQ1Li5kNmNlZDQ0MjI4MTQgMTAwNjQ0Cj4gLS0tIGEv
ZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pbnRlbF9kc2IuaAo+ICsrKyBiL2RyaXZlcnMv
Z3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxfZHNiLmgKPiBAQCAtMzAsMTEgKzMwLDE5IEBAIHN0
cnVjdCBpbnRlbF9kc2Igewo+ICAJICogYW5kIGhlbHAgaW4gY2FsY3VsYXRpbmcgdGFpbCBvZiBj
b21tYW5kIGJ1ZmZlci4KPiAgCSAqLwo+ICAJaW50IGZyZWVfcG9zOwo+ICsKPiArCS8qCj4gKwkg
KiBpbnNfc3RhcnRfb2Zmc2V0IHdpbGwgaGVscCB0byBzdG9yZSBzdGFydCBhZGRyZXNzCj4gKwkg
KiBvZiB0aGUgZHNiIGluc3R1Y3Rpb24gb2YgYXV0by1pbmNyZW1lbnQgcmVnaXN0ZXIuCj4gKwkg
Ki8KPiArCXUzMiBpbnNfc3RhcnRfb2Zmc2V0Owo+ICB9Owo+ICAKPiAgc3RydWN0IGludGVsX2Rz
YiAqCj4gIGludGVsX2RzYl9nZXQoc3RydWN0IGludGVsX2NydGMgKmNydGMpOwo+ICB2b2lkIGlu
dGVsX2RzYl9wdXQoc3RydWN0IGludGVsX2RzYiAqZHNiKTsKPiAgdm9pZCBpbnRlbF9kc2JfcmVn
X3dyaXRlKHN0cnVjdCBpbnRlbF9kc2IgKmRzYiwgaTkxNV9yZWdfdCByZWcsIHUzMiB2YWwpOwo+
ICt2b2lkIGludGVsX2RzYl9pbmRleGVkX3JlZ193cml0ZShzdHJ1Y3QgaW50ZWxfZHNiICpkc2Is
IGk5MTVfcmVnX3QgcmVnLAo+ICsJCQkJIHUzMiB2YWwpOwo+ICAKPiAgI2VuZGlmCgotLSAKSmFu
aSBOaWt1bGEsIEludGVsIE9wZW4gU291cmNlIEdyYXBoaWNzIENlbnRlcgpfX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0
CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3Rv
cC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZng=