From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 239D9C0650F for ; Tue, 30 Jul 2019 13:44:10 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EDC04206B8 for ; Tue, 30 Jul 2019 13:44:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EDC04206B8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:33054 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hsSQD-0001KX-9i for qemu-devel@archiver.kernel.org; Tue, 30 Jul 2019 09:44:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51688) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hsSPA-0008Oq-Vt for qemu-devel@nongnu.org; Tue, 30 Jul 2019 09:43:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hsSPA-00088H-4L for qemu-devel@nongnu.org; Tue, 30 Jul 2019 09:43:04 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49943) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hsSP9-00087s-Vn for qemu-devel@nongnu.org; Tue, 30 Jul 2019 09:43:04 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 54FF23084499 for ; Tue, 30 Jul 2019 13:43:03 +0000 (UTC) Received: from redhat.com (ovpn-116-30.ams2.redhat.com [10.36.116.30]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5790D5D6A7; Tue, 30 Jul 2019 13:43:00 +0000 (UTC) From: Juan Quintela To: "Dr. David Alan Gilbert \(git\)" In-Reply-To: <20190730093719.12958-2-dgilbert@redhat.com> (David Alan Gilbert's message of "Tue, 30 Jul 2019 10:37:18 +0100") References: <20190730093719.12958-1-dgilbert@redhat.com> <20190730093719.12958-2-dgilbert@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) Date: Tue, 30 Jul 2019 15:42:58 +0200 Message-ID: <87h873k599.fsf@trasno.org> MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.40]); Tue, 30 Jul 2019 13:43:03 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH 1/2] pcie_root_port: Allow ACS to be disabled X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: quintela@redhat.com Cc: qemu-devel@nongnu.org, ehabkost@redhat.com, mst@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" "Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > ACS was added in 4.0 unconditionally, this breaks migration > compatibility. > Allow ACS to be disabled by adding a property that's > checked by pcie_root_port. > > Unfortunately pcie-root-port doesn't have any instance data, > so there's no where for that flag to live, so stuff it into > PCIESlot. > > Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Juan Quintela