From mboxrd@z Thu Jan 1 00:00:00 1970 From: Petr Machata Date: Tue, 30 Jul 2019 12:19:38 +0000 Subject: Re: [PATCH][net-next][V2] mlxsw: spectrum_ptp: fix duplicated check on orig_egr_types Message-Id: <87h873zpd3.fsf@mellanox.com> List-Id: References: <20190730114752.24133-1-colin.king@canonical.com> In-Reply-To: <20190730114752.24133-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Colin King Cc: Jiri Pirko , Ido Schimmel , "David S . Miller" , "netdev@vger.kernel.org" , "kernel-janitors@vger.kernel.org" , "linux-kernel@vger.kernel.org" Colin King writes: > From: Colin Ian King > > Currently are duplicated checks on orig_egr_types which are > redundant, I believe this is a typo and should actually be > orig_ing_types || orig_egr_types instead of the expression > orig_egr_types || orig_egr_types. Fix these. > > Addresses-Coverity: ("Same on both sides") > Fixes: c6b36bdd04b5 ("mlxsw: spectrum_ptp: Increase parsing depth when PTP is enabled") > Signed-off-by: Colin Ian King Thank you, it looks good. But can you please direct this to "net", not "net-next"?