From: Markus Armbruster <armbru@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Damien Hedde <damien.hedde@greensocs.com>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [RFC] hw/core/bus.c: Only the main system bus can have no parent
Date: Thu, 23 May 2019 16:32:07 +0200 [thread overview]
Message-ID: <87h89ljl7c.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <CAFEAcA98zZ60fAWgu4s9aCdKjafNtZsCt8ieEfTWYdZx5D2aGw@mail.gmail.com> (Peter Maydell's message of "Thu, 23 May 2019 13:12:57 +0100")
Peter Maydell <peter.maydell@linaro.org> writes:
> On Thu, 23 May 2019 at 13:09, Markus Armbruster <armbru@redhat.com> wrote:
>> Registering qbus_reset_all_fn() in main() is kind of ugly, but it works.
>> There's a comment pointing out it's ugly. Right now it's a TODO
>> comment, which maybe expresses more hope for cleanup than there really
>> is. I'd leave it alone anyway.
>
> ...so after this long thread, are we at a conclusion?
> I think my view is that the patch-as-sent needs to be
> revised to also fix bus_unparent() but is otherwise OK.
Yup. You can add my
Reviewed-by: Markus Armbruster <armbru@redhat.com>
to it then
prev parent reply other threads:[~2019-05-23 14:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-14 17:15 [Qemu-devel] [RFC] hw/core/bus.c: Only the main system bus can have no parent Peter Maydell
2019-05-16 5:37 ` Markus Armbruster
2019-05-16 9:19 ` Peter Maydell
2019-05-20 9:39 ` Damien Hedde
2019-05-21 14:34 ` Markus Armbruster
2019-05-21 14:55 ` Peter Maydell
2019-05-23 6:39 ` Markus Armbruster
2019-05-23 8:54 ` Peter Maydell
2019-05-23 12:08 ` Markus Armbruster
2019-05-23 12:12 ` Peter Maydell
2019-05-23 13:27 ` Damien Hedde
2019-05-23 14:32 ` Markus Armbruster [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h89ljl7c.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=damien.hedde@greensocs.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.