From mboxrd@z Thu Jan 1 00:00:00 1970 From: anholt Subject: Re: [PATCH v8] drm: Add library for shmem backed GEM objects Date: Thu, 14 Mar 2019 12:06:25 -0700 Message-ID: <87h8c5xolq.fsf@anholt.net> References: <20190313004344.24169-1-robh@kernel.org> <87bm2etrwb.fsf@anholt.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0865395480==" Return-path: Received: from anholt.net (anholt.net [50.246.234.109]) by gabe.freedesktop.org (Postfix) with ESMTP id 0DF056E153 for ; Thu, 14 Mar 2019 19:06:29 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Rob Herring Cc: dri-devel List-Id: dri-devel@lists.freedesktop.org --===============0865395480== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Rob Herring writes: > On Wed, Mar 13, 2019 at 3:56 PM Eric Anholt wrote: >> >> Rob Herring writes: >> >> > From: Noralf Tr=C3=B8nnes >> > >> > This adds a library for shmem backed GEM objects. >> >> I read through the whole thing, and the only bit I didn't like >> (drm_gem_shmem_create_with_handle returns an unrefcounted object >> pointer) was a copy-and-paste from CMA that we should fix in both >> places, and has no downside in the current usage since the pointer value >> is unused. Just one question left: >> >> > v7: >> > - Use write-combine for mmap instead. This is the more common >> > case. (robher) >> >> I don't actually see this in the code. Wasn't there supposed to be a: >> >> vma->vm_page_prot =3D pgprot_writecombine(vm_get_page_prot(vma->v= m_flags)); > > That's the default if you trace drm_gem_mmap() -> drm_gem_mmap_obj(). > My wording here should have been more clear. Ah, there it is! Added review to the helpers, and I've pushed both patches now. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAlyKpjEACgkQtdYpNtH8 nuh9qA/8CcxxUj5VZyLEkygxN+2FrVs+Vj+YtsGdfDN7aIBGa2UGGKBt+QgK30OI vrhAGFtBwQiFoki2X1y82jKT6JRn1nEGigUJLqOpSju9QsdNirfcbCC9Z3Rjh7cS W1RJQBomAbHo78GfJtUsU7b33o85vvoPv0+l4QQ9YCZOti0QQPYV1FWUuOGSl+8V 2EQmwDNXsMRyRN3Fp5UDJ3UKa5MiT9w7o8bYcrsf1C9BPm8xG92FRtCYz/vzgini mQejNevZYefrDnOp/pqfgnQ7yit4d/EPYpE8fv69CTaghq2+NSgZy7x1AHVfLC8P 75Kbfyhxo+lAs/phXHPZHMKK3/qnQxxsvRPH7Le6P/NUtvJ+6XmoYB8euOgw+XAG aueJldvACt7CZTX6EBP8iZaZc9+tvJJ10RPdBDWPzfUV6cobhJ8WpceZ8Nl1eF8x y3GmO6pMsir949sEwdQLS67FR05QTKCmGIY5rFW7MMVV30yUZokphbmxEyVNuPT0 cWz3M6QudDsFq3xwyo3LrbLEae23erAOUJ0QqS20mf7VfzroKQxq4iouxTkAmFk1 0D49qaPZE6jY1PrFjSHx4a8jqS/9fkt/GCmsEdDaGHV/5rVF55Nw0Cd9FHaNqCKn LDAgLj5BagQ9sMoVR8D/TPcedbWm6zxObr+ecxiYvu0LNbgP6kE= =e2aJ -----END PGP SIGNATURE----- --=-=-=-- --===============0865395480== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs --===============0865395480==--