From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Kuoppala Subject: Re: [PATCH 1/3] drm/i915: Use intel_engine_stop_cs when stopping ringbuffer Date: Thu, 28 Feb 2019 18:10:20 +0200 Message-ID: <87h8cnvqqb.fsf@gaia.fi.intel.com> References: <20190228160133.819-1-mika.kuoppala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6A53789EB1 for ; Thu, 28 Feb 2019 16:10:48 +0000 (UTC) In-Reply-To: <20190228160133.819-1-mika.kuoppala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org TWlrYSBLdW9wcGFsYSA8bWlrYS5rdW9wcGFsYUBsaW51eC5pbnRlbC5jb20+IHdyaXRlczoKCj4g V2UgaGF2ZSBhbiBleHBvcnRlZCBmdW5jdGlvbiBmb3Igc3RvcHBpbmcgdGhlIGVuZ2luZSBiZWZv cmUKPiBkaXNhYmxpbmcgYSByaW5nYnVmZmVyLiBUYWtlIGl0IGludG8gdXNlLgo+Cj4gdjI6IHVz ZSBmdyBvbiBlbXB0eSBjaGVjawo+Cj4gQ2M6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2ls c29uLmNvLnVrPgo+IFNpZ25lZC1vZmYtYnk6IE1pa2EgS3VvcHBhbGEgPG1pa2Eua3VvcHBhbGFA bGludXguaW50ZWwuY29tPgo+IFJldmlld2VkLWJ5OiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlz LXdpbHNvbi5jby51az4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZW5naW5l X2NzLmMgIHwgIDMgKysKPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcmluZ2J1ZmZlci5j IHwgNDEgKysrKysrKysrKysrKystLS0tLS0tLS0tLQo+ICAyIGZpbGVzIGNoYW5nZWQsIDI2IGlu c2VydGlvbnMoKyksIDE4IGRlbGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX2VuZ2luZV9jcy5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf ZW5naW5lX2NzLmMKPiBpbmRleCBkZjhmODgxNDJmMWQuLmUzNWRjMDM4NmJmNiAxMDA2NDQKPiAt LS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9lbmdpbmVfY3MuYwo+ICsrKyBiL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX2VuZ2luZV9jcy5jCj4gQEAgLTg1Niw2ICs4NTYsOSBAQCB2 b2lkIGludGVsX2VuZ2luZV9jYW5jZWxfc3RvcF9jcyhzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICpl bmdpbmUpCj4gIHsKPiAgCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IGVuZ2lu ZS0+aTkxNTsKPiAgCj4gKwlpZiAoSU5URUxfR0VOKGRldl9wcml2KSA8IDMpCj4gKwkJcmV0dXJu Owo+ICsKPiAgCUdFTV9UUkFDRSgiJXNcbiIsIGVuZ2luZS0+bmFtZSk7Cj4gIAo+ICAJSTkxNV9X UklURV9GVyhSSU5HX01JX01PREUoZW5naW5lLT5tbWlvX2Jhc2UpLAo+IGRpZmYgLS1naXQgYS9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9yaW5nYnVmZmVyLmMgYi9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9yaW5nYnVmZmVyLmMKPiBpbmRleCAxYjk2YjA5NjBhZGMuLmQ3NDg2ZjlhMjlh OSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9yaW5nYnVmZmVyLmMK PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9yaW5nYnVmZmVyLmMKPiBAQCAtNjA0 LDI2ICs2MDQsMzIgQEAgc3RhdGljIHZvaWQgcmluZ19zZXR1cF9zdGF0dXNfcGFnZShzdHJ1Y3Qg aW50ZWxfZW5naW5lX2NzICplbmdpbmUpCj4gIAlmbHVzaF9jc190bGIoZW5naW5lKTsKPiAgfQo+ ICAKPiArc3RhdGljIGJvb2wgcmluZ19pc19lbXB0eShzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICpl bmdpbmUpCj4gK3sKPiArCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IGVuZ2lu ZS0+aTkxNTsKPiArCWNvbnN0IHUzMiBiYXNlID0gZW5naW5lLT5tbWlvX2Jhc2U7Cj4gKwo+ICsJ cmV0dXJuIChJOTE1X1JFQURfRlcoUklOR19IRUFEKGJhc2UpKSAmIEhFQURfQUREUikgPT0KPiAr CQkoSTkxNV9SRUFEX0ZXKFJJTkdfSEVBRChiYXNlKSkgJiBUQUlMX0FERFIpOwoKQVJnaCEKLU1p a2EKCj4gK30KPiArCj4gIHN0YXRpYyBib29sIHN0b3BfcmluZyhzdHJ1Y3QgaW50ZWxfZW5naW5l X2NzICplbmdpbmUpCj4gIHsKPiAgCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9 IGVuZ2luZS0+aTkxNTsKPiArCWludCByZXQ7Cj4gIAo+IC0JaWYgKElOVEVMX0dFTihkZXZfcHJp dikgPiAyKSB7Cj4gLQkJSTkxNV9XUklURV9NT0RFKGVuZ2luZSwgX01BU0tFRF9CSVRfRU5BQkxF KFNUT1BfUklORykpOwo+IC0JCWlmIChpbnRlbF93YWl0X2Zvcl9yZWdpc3RlcihkZXZfcHJpdiwK PiAtCQkJCQkgICAgUklOR19NSV9NT0RFKGVuZ2luZS0+bW1pb19iYXNlKSwKPiAtCQkJCQkgICAg TU9ERV9JRExFLAo+IC0JCQkJCSAgICBNT0RFX0lETEUsCj4gLQkJCQkJICAgIDEwMDApKSB7Cj4g LQkJCURSTV9FUlJPUigiJXMgOiB0aW1lZCBvdXQgdHJ5aW5nIHRvIHN0b3AgcmluZ1xuIiwKPiAt CQkJCSAgZW5naW5lLT5uYW1lKTsKPiAtCQkJLyogU29tZXRpbWVzIHdlIG9ic2VydmUgdGhhdCB0 aGUgaWRsZSBmbGFnIGlzIG5vdAo+IC0JCQkgKiBzZXQgZXZlbiB0aG91Z2ggdGhlIHJpbmcgaXMg ZW1wdHkuIFNvIGRvdWJsZQo+IC0JCQkgKiBjaGVjayBiZWZvcmUgZ2l2aW5nIHVwLgo+IC0JCQkg Ki8KPiAtCQkJaWYgKEk5MTVfUkVBRF9IRUFEKGVuZ2luZSkgIT0gSTkxNV9SRUFEX1RBSUwoZW5n aW5lKSkKPiAtCQkJCXJldHVybiBmYWxzZTsKPiAtCQl9Cj4gKwlyZXQgPSBpbnRlbF9lbmdpbmVf c3RvcF9jcyhlbmdpbmUpOwo+ICsJaWYgKHJldCA9PSAtRU5PREVWKQo+ICsJCXJldCA9IDA7Cj4g Kwo+ICsJaWYgKHJldCkgewo+ICsJCS8qCj4gKwkJICogU29tZXRpbWVzIHdlIG9ic2VydmUgdGhh dCB0aGUgaWRsZSBmbGFnIGlzIG5vdAo+ICsJCSAqIHNldCBldmVuIHRob3VnaCB0aGUgcmluZyBp cyBlbXB0eS4gU28gZG91YmxlCj4gKwkJICogY2hlY2sgYmVmb3JlIGdpdmluZyB1cC4KPiArCQkg Ki8KPiArCQlpZiAoIXJpbmdfaXNfZW1wdHkoZW5naW5lKSkKPiArCQkJcmV0dXJuIGZhbHNlOwo+ ICAJfQo+ICAKPiAgCUk5MTVfV1JJVEVfSEVBRChlbmdpbmUsIEk5MTVfUkVBRF9UQUlMKGVuZ2lu ZSkpOwo+IEBAIC03MTgsOCArNzI0LDcgQEAgc3RhdGljIGludCBpbml0X3JpbmdfY29tbW9uKHN0 cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2luZSkKPiAgCQlnb3RvIG91dDsKPiAgCX0KPiAgCj4g LQlpZiAoSU5URUxfR0VOKGRldl9wcml2KSA+IDIpCj4gLQkJSTkxNV9XUklURV9NT0RFKGVuZ2lu ZSwgX01BU0tFRF9CSVRfRElTQUJMRShTVE9QX1JJTkcpKTsKPiArCWludGVsX2VuZ2luZV9jYW5j ZWxfc3RvcF9jcyhlbmdpbmUpOwo+ICAKPiAgCS8qIE5vdyBhd2FrZSwgbGV0IGl0IGdldCBzdGFy dGVkICovCj4gIAlpZiAocmluZy0+dGFpbCAhPSByaW5nLT5oZWFkKSB7Cj4gLS0gCj4gMi4xNy4x Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdm eCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xp c3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeA==