From: Felipe Balbi <balbi@kernel.org>
To: Minas Harutyunyan <minas.harutyunyan@synopsys.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>Minas Harutyunyan
<minas.harutyunyan@synopsys.com>,
linux-usb@vger.kernel.org
Cc: John Youn <john.youn@synopsys.com>
Subject: usb: dwc2: gadget: Consider VBUS discharge time in disconnect flow
Date: Thu, 07 Feb 2019 13:15:38 +0200 [thread overview]
Message-ID: <87h8dfluhx.fsf@linux.intel.com> (raw)
Hi,
Minas Harutyunyan <minas.harutyunyan@synopsys.com> writes:
> diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c
> index 68ad75a7460d..eab1da4c0beb 100644
> --- a/drivers/usb/dwc2/gadget.c
> +++ b/drivers/usb/dwc2/gadget.c
> @@ -3689,6 +3689,14 @@ static irqreturn_t dwc2_hsotg_irq(int irq, void *pw)
> if (gintsts & GINTSTS_ERLYSUSP) {
> dev_dbg(hsotg->dev, "GINTSTS_ErlySusp\n");
> dwc2_writel(hsotg, GINTSTS_ERLYSUSP, GINTSTS);
> +
> + mdelay(hsotg->params.vbus_discharge_time);
<snip>
> + p->vbus_discharge_time = 1000;
A whole second?? Wow. Perhaps you need to rethink this patch a little.
next reply other threads:[~2019-02-07 11:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-07 11:15 Felipe Balbi [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-02-06 18:52 usb: dwc2: gadget: Consider VBUS discharge time in disconnect flow John Keeping
2019-02-05 8:08 Minas Harutyunyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h8dfluhx.fsf@linux.intel.com \
--to=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=john.youn@synopsys.com \
--cc=minas.harutyunyan@synopsys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.