From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH 1/5] drm/i915/crt: split out intel_crt_present() to platform specific setup Date: Tue, 22 Jan 2019 10:26:59 +0200 Message-ID: <87h8e13xnw.fsf@intel.com> References: <20190121142134.17434-1-jani.nikula@intel.com> <20190121193017.GQ20097@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 279286EBD9 for ; Tue, 22 Jan 2019 08:25:19 +0000 (UTC) In-Reply-To: <20190121193017.GQ20097@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville =?utf-8?B?U3lyasOkbMOk?= Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCAyMSBKYW4gMjAxOSwgVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4 LmludGVsLmNvbT4gd3JvdGU6Cj4gT24gTW9uLCBKYW4gMjEsIDIwMTkgYXQgMDQ6MjE6MzBQTSAr MDIwMCwgSmFuaSBOaWt1bGEgd3JvdGU6Cj4+IFdpdGggbmV3IHBsYXRmb3JtcyBub3QgaGF2aW5n IENSVCBzdXBwb3J0IGFuZCBtb3N0IGNvbmRpdGlvbnMgaW4KPj4gaW50ZWxfY3J0X3ByZXNlbnQo KSBiZWluZyBzcGVjaWZpYyB0byBEREksIHNwbGl0IG91dCB0aGUgQ1JUCj4+IGluaXRpYWxpemF0 aW9uIHRvIHBsYXRmb3JtIHNwZWNpZmljIGJsb2NrcyBpbiB0aGUgaWYgbGFkZGVyLiBBZGQgbmV3 Cj4+IFBpbmV2aWV3IGJsb2NrIGZvciB0aGlzLgo+PiAKPj4gVGhpcyBwdXRzIGludGVsX2NydF9p bml0KCkgbW9yZSBpbiBsaW5lIHdpdGggdGhlIHJlc3Qgb2YgdGhlIG91dHB1dHMsCj4+IGFuZCBt YWtlcyBpdCBzbGlnaHRseSBlYXNpZXIgZm9yIHRoZSB1bmluaXRpYXRlZCB0byBmaWd1cmUgb3V0 IHdoaWNoCj4+IHBsYXRmb3JtcyBhY3R1YWxseSBoYXZlIHdoYXQuCj4+IAo+PiBTaWduZWQtb2Zm LWJ5OiBKYW5pIE5pa3VsYSA8amFuaS5uaWt1bGFAaW50ZWwuY29tPgo+PiAtLS0KPj4gIGRyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyB8IDM3ICsrKysrKysrKysrKysrKysrKy0t LS0tLS0tLS0KPj4gIDEgZmlsZSBjaGFuZ2VkLCAyNCBpbnNlcnRpb25zKCspLCAxMyBkZWxldGlv bnMoLSkKPj4gCj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNw bGF5LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPj4gaW5kZXggMmZh OWY0YWVjMDhlLi5lOGJjMjk3YzYwYWIgMTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX2Rpc3BsYXkuYwo+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9k aXNwbGF5LmMKPj4gQEAgLTE0MjQ1LDIzICsxNDI0NSwxNyBAQCBzdGF0aWMgYm9vbCBoYXNfZWRw X2Eoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+PiAgCXJldHVybiB0cnVlOwo+ PiAgfQo+PiAgCj4+IC1zdGF0aWMgYm9vbCBpbnRlbF9jcnRfcHJlc2VudChzdHJ1Y3QgZHJtX2k5 MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4+ICtzdGF0aWMgYm9vbCBpbnRlbF9kZGlfY3J0X3ByZXNl bnQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+PiAgewo+PiAtCWlmIChJTlRF TF9HRU4oZGV2X3ByaXYpID49IDkpCj4+IC0JCXJldHVybiBmYWxzZTsKPgo+IFdlIHNob3VsZCBw cm9iYWJseSBrZWVwIHRoaXMgaW4gY2FzZSB0aGUgdmJ0IGlzIGJvbmtlcnMuCgpPaCwgZGVmaW5p dGVseSwgdGhhbmtzIGZvciBzcG90dGluZyEKCj4KPj4gLQo+PiAgCWlmIChJU19IU1dfVUxUKGRl dl9wcml2KSB8fCBJU19CRFdfVUxUKGRldl9wcml2KSkKPj4gIAkJcmV0dXJuIGZhbHNlOwo+PiAg Cj4+IC0JaWYgKElTX0NIRVJSWVZJRVcoZGV2X3ByaXYpKQo+PiAtCQlyZXR1cm4gZmFsc2U7Cj4+ IC0KPj4gIAlpZiAoSEFTX1BDSF9MUFRfSChkZXZfcHJpdikgJiYKPj4gIAkgICAgSTkxNV9SRUFE KFNGVVNFX1NUUkFQKSAmIFNGVVNFX1NUUkFQX0NSVF9ESVNBQkxFRCkKPj4gIAkJcmV0dXJuIGZh bHNlOwo+PiAgCj4+ICAJLyogRERJIEUgY2FuJ3QgYmUgdXNlZCBpZiBEREkgQSByZXF1aXJlcyA0 IGxhbmVzICovCj4+IC0JaWYgKEhBU19EREkoZGV2X3ByaXYpICYmIEk5MTVfUkVBRChERElfQlVG X0NUTChQT1JUX0EpKSAmIERESV9BXzRfTEFORVMpCj4+ICsJaWYgKEk5MTVfUkVBRChERElfQlVG X0NUTChQT1JUX0EpKSAmIERESV9BXzRfTEFORVMpCj4+ICAJCXJldHVybiBmYWxzZTsKPj4gIAo+ PiAgCWlmICghZGV2X3ByaXYtPnZidC5pbnRfY3J0X3N1cHBvcnQpCj4+IEBAIC0xNDMyMyw5ICsx NDMxNyw2IEBAIHN0YXRpYyB2b2lkIGludGVsX3NldHVwX291dHB1dHMoc3RydWN0IGRybV9pOTE1 X3ByaXZhdGUgKmRldl9wcml2KQo+PiAgCSAqLwo+PiAgCWludGVsX2x2ZHNfaW5pdChkZXZfcHJp dik7Cj4+ICAKPj4gLQlpZiAoaW50ZWxfY3J0X3ByZXNlbnQoZGV2X3ByaXYpKQo+PiAtCQlpbnRl bF9jcnRfaW5pdChkZXZfcHJpdik7Cj4+IC0KPj4gIAlpZiAoSVNfSUNFTEFLRShkZXZfcHJpdikp IHsKPj4gIAkJaW50ZWxfZGRpX2luaXQoZGV2X3ByaXYsIFBPUlRfQSk7Cj4+ICAJCWludGVsX2Rk aV9pbml0KGRldl9wcml2LCBQT1JUX0IpOwo+PiBAQCAtMTQzNTQsNiArMTQzNDUsOSBAQCBzdGF0 aWMgdm9pZCBpbnRlbF9zZXR1cF9vdXRwdXRzKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZf cHJpdikKPj4gIAl9IGVsc2UgaWYgKEhBU19EREkoZGV2X3ByaXYpKSB7Cj4+ICAJCWludCBmb3Vu ZDsKPj4gIAo+PiArCQlpZiAoaW50ZWxfZGRpX2NydF9wcmVzZW50KGRldl9wcml2KSkKPj4gKwkJ CWludGVsX2NydF9pbml0KGRldl9wcml2KTsKPj4gKwo+PiAgCQkvKgo+PiAgCQkgKiBIYXN3ZWxs IHVzZXMgRERJIGZ1bmN0aW9ucyB0byBkZXRlY3QgZGlnaXRhbCBvdXRwdXRzLgo+PiAgCQkgKiBP biBTS0wgcHJlLUQwIHRoZSBzdHJhcCBpc24ndCBjb25uZWN0ZWQsIHNvIHdlIGFzc3VtZQo+PiBA QCAtMTQzODUsNiArMTQzNzksMTAgQEAgc3RhdGljIHZvaWQgaW50ZWxfc2V0dXBfb3V0cHV0cyhz dHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4+ICAKPj4gIAl9IGVsc2UgaWYgKEhB U19QQ0hfU1BMSVQoZGV2X3ByaXYpKSB7Cj4+ICAJCWludCBmb3VuZDsKPj4gKwo+PiArCQlpZiAo ZGV2X3ByaXYtPnZidC5pbnRfY3J0X3N1cHBvcnQpCj4+ICsJCQlpbnRlbF9jcnRfaW5pdChkZXZf cHJpdik7Cj4+ICsKPj4gIAkJZHBkX2lzX2VkcCA9IGludGVsX2RwX2lzX3BvcnRfZWRwKGRldl9w cml2LCBQT1JUX0QpOwo+PiAgCj4+ICAJCWlmIChoYXNfZWRwX2EoZGV2X3ByaXYpKQo+PiBAQCAt MTQ0MTMsNiArMTQ0MTEsOSBAQCBzdGF0aWMgdm9pZCBpbnRlbF9zZXR1cF9vdXRwdXRzKHN0cnVj dCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPj4gIAl9IGVsc2UgaWYgKElTX1ZBTExFWVZJ RVcoZGV2X3ByaXYpIHx8IElTX0NIRVJSWVZJRVcoZGV2X3ByaXYpKSB7Cj4+ICAJCWJvb2wgaGFz X2VkcCwgaGFzX3BvcnQ7Cj4+ICAKPj4gKwkJaWYgKElTX1ZBTExFWVZJRVcoZGV2X3ByaXYpICYm IGRldl9wcml2LT52YnQuaW50X2NydF9zdXBwb3J0KQo+PiArCQkJaW50ZWxfY3J0X2luaXQoZGV2 X3ByaXYpOwo+PiArCj4+ICAJCS8qCj4+ICAJCSAqIFRoZSBEUF9ERVRFQ1RFRCBiaXQgaXMgdGhl IGxhdGNoZWQgc3RhdGUgb2YgdGhlIEREQwo+PiAgCQkgKiBTREEgcGluIGF0IGJvb3QuIEhvd2V2 ZXIgc2luY2UgZURQIGRvZXNuJ3QgcmVxdWlyZSBEREMKPj4gQEAgLTE0NDU1LDkgKzE0NDU2LDE1 IEBAIHN0YXRpYyB2b2lkIGludGVsX3NldHVwX291dHB1dHMoc3RydWN0IGRybV9pOTE1X3ByaXZh dGUgKmRldl9wcml2KQo+PiAgCQl9Cj4+ICAKPj4gIAkJdmx2X2RzaV9pbml0KGRldl9wcml2KTsK Pj4gLQl9IGVsc2UgaWYgKCFJU19HRU4oZGV2X3ByaXYsIDIpICYmICFJU19QSU5FVklFVyhkZXZf cHJpdikpIHsKPj4gKwl9IGVsc2UgaWYgKElTX1BJTkVWSUVXKGRldl9wcml2KSkgewo+PiArCQlp ZiAoZGV2X3ByaXYtPnZidC5pbnRfY3J0X3N1cHBvcnQpCj4+ICsJCQlpbnRlbF9jcnRfaW5pdChk ZXZfcHJpdik7Cj4+ICsJfSBlbHNlIGlmIChJU19HRU5fUkFOR0UoZGV2X3ByaXYsIDMsIDQpKSB7 Cj4+ICAJCWJvb2wgZm91bmQgPSBmYWxzZTsKPj4gIAo+PiArCQlpZiAoZGV2X3ByaXYtPnZidC5p bnRfY3J0X3N1cHBvcnQpCj4+ICsJCQlpbnRlbF9jcnRfaW5pdChkZXZfcHJpdik7Cj4+ICsKPj4g IAkJaWYgKEk5MTVfUkVBRChHRU4zX1NEVk9CKSAmIFNEVk9fREVURUNURUQpIHsKPj4gIAkJCURS TV9ERUJVR19LTVMoInByb2JpbmcgU0RWT0JcbiIpOwo+PiAgCQkJZm91bmQgPSBpbnRlbF9zZHZv X2luaXQoZGV2X3ByaXYsIEdFTjNfU0RWT0IsIFBPUlRfQik7Cj4+IEBAIC0xNDQ4OSw4ICsxNDQ5 NiwxMiBAQCBzdGF0aWMgdm9pZCBpbnRlbF9zZXR1cF9vdXRwdXRzKHN0cnVjdCBkcm1faTkxNV9w cml2YXRlICpkZXZfcHJpdikKPj4gIAo+PiAgCQlpZiAoSVNfRzRYKGRldl9wcml2KSAmJiAoSTkx NV9SRUFEKERQX0QpICYgRFBfREVURUNURUQpKQo+PiAgCQkJaW50ZWxfZHBfaW5pdChkZXZfcHJp diwgRFBfRCwgUE9SVF9EKTsKPj4gLQl9IGVsc2UgaWYgKElTX0dFTihkZXZfcHJpdiwgMikpCj4+ ICsJfSBlbHNlIGlmIChJU19HRU4oZGV2X3ByaXYsIDIpKSB7Cj4+ICsJCWlmIChkZXZfcHJpdi0+ dmJ0LmludF9jcnRfc3VwcG9ydCkKPj4gKwkJCWludGVsX2NydF9pbml0KGRldl9wcml2KTsKPgo+ IGludF9jcnRfc3VwcG9ydCBpcyBhbHdheXMgdHJ1ZSBmb3IgcHJlLXZsdi9wcmUtaHN3IHNvIHdl IGNvdWxkCj4gc2tpcCB0aGUgY2hlY2sgaW4gbW9zdCBvZiB0aGVzZSBjYXNlcy4gRWl0aGVyIHdh eSBpcyBmaW5lIGJ5IG1lLgoKSSBhZGRlZCB0aGF0IGNoYW5nZSBhcyBhIHNlcGFyYXRlIHBhdGNo IG9uIHRvcC4KCj4KPiBXaXRoIHRoZSBnZW45IHN0dWZmIHNvcnRlZCB0aGlzIGlzCj4gUmV2aWV3 ZWQtYnk6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+CgpU aGFua3MgZm9yIHRoZSByZXZpZXdzLCBuZXcgc2VyaWVzIG9uIHRoZSBsaXN0LgoKQlIsCkphbmku Cgo+Cj4+ICsKPj4gIAkJaW50ZWxfZHZvX2luaXQoZGV2X3ByaXYpOwo+PiArCX0KPj4gIAo+PiAg CWlmIChTVVBQT1JUU19UVihkZXZfcHJpdikpCj4+ICAJCWludGVsX3R2X2luaXQoZGV2X3ByaXYp Owo+PiAtLSAKPj4gMi4yMC4xCj4+IAo+PiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwo+PiBJbnRlbC1nZnggbWFpbGluZyBsaXN0Cj4+IEludGVsLWdmeEBs aXN0cy5mcmVlZGVza3RvcC5vcmcKPj4gaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFp bG1hbi9saXN0aW5mby9pbnRlbC1nZngKCi0tIApKYW5pIE5pa3VsYSwgSW50ZWwgT3BlbiBTb3Vy Y2UgR3JhcGhpY3MgQ2VudGVyCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNr dG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2lu dGVsLWdmeAo=