From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Kuoppala Subject: Re: [PATCH 18/23] drm/i915: Keep all partially allocated HWSP on a freelist Date: Fri, 18 Jan 2019 14:12:58 +0200 Message-ID: <87h8e6w4dx.fsf@gaia.fi.intel.com> References: <20190117143519.16086-1-chris@chris-wilson.co.uk> <20190117143519.16086-19-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id 131896F71B for ; Fri, 18 Jan 2019 12:14:48 +0000 (UTC) In-Reply-To: <20190117143519.16086-19-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Q2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+IHdyaXRlczoKCj4gS2VlcCB0 cmFjayBvZiBwYXJ0aWFsbHkgYWxsb2NhdGVkIHBhZ2VzIGZvciB1c2UgaW4gYWxsb2NhdGluZyBm dXR1cmUKPiB0aW1lbGluZSBIV1NQLiBUaGlzIGlzIHN0aWxsIHdpdGhvdXQgbWlncmF0aW9uLCBz byBpdCBpcyBwb3NzaWJsZSBmb3IKCnRpbWVsaW5lIGZyb20gSFdTUD8KCj4gdGhlIHN5c3RlbSB0 byBlbmQgdXAgd2l0aCBlYWNoIHRpbWVsaW5lIGluIGl0cyBvd24gcGFnZSwgYnV0IHdlIGVuc3Vy ZQo+IHRoYXQgbm8gbmV3IGFsbG9jYXRpb24gd291bGQgbmVlZGxlc3MgYWxsb2NhdGUgYSBmcmVz aCBwYWdlIQoKcy9uZWVkbGVzcy9uZWVkbGVzc2x5LgotTWlrYQoKPgo+IFNpZ25lZC1vZmYtYnk6 IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgo+IENjOiBKb2huIEhhcnJp c29uIDxKb2huLkMuSGFycmlzb25ASW50ZWwuY29tPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0v aTkxNS9pOTE1X2Rydi5oICAgICAgfCAgMyArLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1 X3RpbWVsaW5lLmMgfCA4MSArKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tCj4gIDIgZmlsZXMg Y2hhbmdlZCwgNTAgaW5zZXJ0aW9ucygrKSwgMzQgZGVsZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0 IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaCBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2k5MTVfZHJ2LmgKPiBpbmRleCBkNTkyMjhkYWJiNmUuLjBiZWJlZjQyOGYxZSAxMDA2NDQKPiAt LS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oCj4gKysrIGIvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaTkxNV9kcnYuaAo+IEBAIC0xOTgxLDggKzE5ODEsNyBAQCBzdHJ1Y3QgZHJtX2k5 MTVfcHJpdmF0ZSB7Cj4gIAo+ICAJCQkvKiBQYWNrIG11bHRpcGxlIHRpbWVsaW5lcycgc2Vxbm9z IGludG8gdGhlIHNhbWUgcGFnZSAqLwo+ICAJCQlzcGlubG9ja190IGh3c3BfbG9jazsKPiAtCQkJ c3RydWN0IGk5MTVfdm1hICpod3NwOwo+IC0JCQl1NjQgYml0bWFwOwo+ICsJCQlzdHJ1Y3QgbGlz dF9oZWFkIGh3c3A7Cj4gIAkJfSB0aW1lbGluZXM7Cj4gIAo+ICAJCXN0cnVjdCBsaXN0X2hlYWQg YWN0aXZlX3JpbmdzOwo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3Rp bWVsaW5lLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3RpbWVsaW5lLmMKPiBpbmRleCBl OTM5YTllMWE0YWIuLjY0YmIxY2UyNDMxOCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pOTE1X3RpbWVsaW5lLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3Rp bWVsaW5lLmMKPiBAQCAtOSw3NCArOSw5NCBAQAo+ICAjaW5jbHVkZSAiaTkxNV90aW1lbGluZS5o Igo+ICAjaW5jbHVkZSAiaTkxNV9zeW5jbWFwLmgiCj4gIAo+ICtzdHJ1Y3QgaTkxNV90aW1lbGlu ZV9od3NwIHsKPiArCXN0cnVjdCBsaXN0X2hlYWQgbGluazsKPiArCXN0cnVjdCBpOTE1X3ZtYSAq dm1hOwo+ICsJdTY0IGJpdG1hcDsKPiArfTsKPiArCj4gIHN0YXRpYyBpbnQgaHdzcF9hbGxvYyhz dHJ1Y3QgaTkxNV90aW1lbGluZSAqdGltZWxpbmUpCj4gIHsKPiAtI2RlZmluZSBOQklUUyBCSVRT X1BFUl9UWVBFKHR5cGVvZihndC0+Yml0bWFwKSkKPiAgCXN0cnVjdCBkcm1faTkxNV9wcml2YXRl ICppOTE1ID0gdGltZWxpbmUtPmk5MTU7Cj4gIAlzdHJ1Y3QgaTkxNV9ndF90aW1lbGluZXMgKmd0 ID0gJmk5MTUtPmd0LnRpbWVsaW5lczsKPiAtCXN0cnVjdCBpOTE1X3ZtYSAqdm1hOwo+ICsJc3Ry dWN0IGk5MTVfdGltZWxpbmVfaHdzcCAqaHdzcDsKPiAgCWludCBvZmZzZXQ7Cj4gIAo+ICAJc3Bp bl9sb2NrKCZndC0+aHdzcF9sb2NrKTsKPiAgCj4gLXJlc3RhcnQ6Cj4gLQlvZmZzZXQgPSBmaW5k X2ZpcnN0X2JpdCgodW5zaWduZWQgbG9uZyAqKSZndC0+Yml0bWFwLCBOQklUUyk7Cj4gLQlpZiAo b2Zmc2V0ID09IE5CSVRTICYmIGd0LT5od3NwKSB7Cj4gLQkJaTkxNV92bWFfcHV0KGd0LT5od3Nw KTsKPiAtCQlndC0+aHdzcCA9IE5VTEw7Cj4gLQl9Cj4gLQo+IC0Jdm1hID0gZ3QtPmh3c3A7Cj4g LQlpZiAoIXZtYSkgewo+ICsJaHdzcCA9IGxpc3RfZmlyc3RfZW50cnlfb3JfbnVsbCgmZ3QtPmh3 c3AsIHR5cGVvZigqaHdzcCksIGxpbmspOwo+ICsJaWYgKCFod3NwKSB7Cj4gIAkJc3RydWN0IGRy bV9pOTE1X2dlbV9vYmplY3QgKmJvOwo+ICsJCXN0cnVjdCBpOTE1X3ZtYSAqdm1hOwo+ICAKPiAg CQlzcGluX3VubG9jaygmZ3QtPmh3c3BfbG9jayk7Cj4gIAo+IC0JCUJVSUxEX0JVR19PTihOQklU UyAqIENBQ0hFTElORV9CWVRFUyA+IFBBR0VfU0laRSk7Cj4gKwkJaHdzcCA9IGttYWxsb2Moc2l6 ZW9mKCpod3NwKSwgR0ZQX0tFUk5FTCk7Cj4gKwkJaWYgKCFod3NwKQo+ICsJCQlyZXR1cm4gLUVO T01FTTsKPiArCj4gKwkJQlVJTERfQlVHX09OKEJJVFNfUEVSX1RZUEUoaHdzcC0+Yml0bWFwKSAq IENBQ0hFTElORV9CWVRFUyA+IFBBR0VfU0laRSk7Cj4gIAkJYm8gPSBpOTE1X2dlbV9vYmplY3Rf Y3JlYXRlX2ludGVybmFsKGk5MTUsIFBBR0VfU0laRSk7Cj4gLQkJaWYgKElTX0VSUihibykpCj4g KwkJaWYgKElTX0VSUihibykpIHsKPiArCQkJa2ZyZWUoaHdzcCk7Cj4gIAkJCXJldHVybiBQVFJf RVJSKGJvKTsKPiArCQl9Cj4gIAo+ICAJCWk5MTVfZ2VtX29iamVjdF9zZXRfY2FjaGVfbGV2ZWwo Ym8sIEk5MTVfQ0FDSEVfTExDKTsKPiAgCj4gIAkJdm1hID0gaTkxNV92bWFfaW5zdGFuY2UoYm8s ICZpOTE1LT5nZ3R0LnZtLCBOVUxMKTsKPiAgCQlpZiAoSVNfRVJSKHZtYSkpIHsKPiAgCQkJaTkx NV9nZW1fb2JqZWN0X3B1dChibyk7Cj4gKwkJCWtmcmVlKGh3c3ApOwo+ICAJCQlyZXR1cm4gUFRS X0VSUih2bWEpOwo+ICAJCX0KPiAgCj4gLQkJc3Bpbl9sb2NrKCZndC0+aHdzcF9sb2NrKTsKPiAt CQlpZiAoZ3QtPmh3c3ApIHsKPiAtCQkJaTkxNV9nZW1fb2JqZWN0X3B1dChibyk7Cj4gLQkJCWdv dG8gcmVzdGFydDsKPiAtCQl9Cj4gKwkJdm1hLT5wcml2YXRlID0gaHdzcDsKPiArCQlod3NwLT52 bWEgPSB2bWE7Cj4gKwkJaHdzcC0+Yml0bWFwID0gfjB1bGw7Cj4gIAo+IC0JCWd0LT5od3NwID0g dm1hOwo+IC0JCWd0LT5iaXRtYXAgPSB+MHVsbDsKPiAtCQlvZmZzZXQgPSAwOwo+ICsJCXNwaW5f bG9jaygmZ3QtPmh3c3BfbG9jayk7Cj4gKwkJbGlzdF9hZGQoJmh3c3AtPmxpbmssICZndC0+aHdz cCk7Cj4gIAl9Cj4gIAo+IC0JZ3QtPmJpdG1hcCAmPSB+QklUX1VMTChvZmZzZXQpOwo+ICsJR0VN X0JVR19PTighaHdzcC0+Yml0bWFwKTsKPiArCW9mZnNldCA9IF9fZmZzNjQoaHdzcC0+Yml0bWFw KTsKPiArCWh3c3AtPmJpdG1hcCAmPSB+QklUX1VMTChvZmZzZXQpOwo+ICsJaWYgKCFod3NwLT5i aXRtYXApCj4gKwkJbGlzdF9kZWwoJmh3c3AtPmxpbmspOwo+ICAKPiAgCXNwaW5fdW5sb2NrKCZn dC0+aHdzcF9sb2NrKTsKPiAgCj4gLQl0aW1lbGluZS0+aHdzcF9nZ3R0ID0gaTkxNV92bWFfZ2V0 KHZtYSk7Cj4gKwl0aW1lbGluZS0+aHdzcF9nZ3R0ID0gaTkxNV92bWFfZ2V0KGh3c3AtPnZtYSk7 Cj4gIAl0aW1lbGluZS0+aHdzcF9vZmZzZXQgPSBvZmZzZXQgKiBDQUNIRUxJTkVfQllURVM7Cj4g IAo+ICsJR0VNX0JVR19PTih0aW1lbGluZS0+aHdzcF9nZ3R0LT5wcml2YXRlICE9IGh3c3ApOwo+ ICsKPiAgCXJldHVybiAwOwo+IC0jdW5kZWYgTkJJVFMKPiAgfQo+ICAKPiAgc3RhdGljIHZvaWQg aHdzcF9mcmVlKHN0cnVjdCBpOTE1X3RpbWVsaW5lICp0aW1lbGluZSkKPiAgewo+ICAJc3RydWN0 IGk5MTVfZ3RfdGltZWxpbmVzICpndCA9ICZ0aW1lbGluZS0+aTkxNS0+Z3QudGltZWxpbmVzOwo+ ICsJc3RydWN0IGk5MTVfdGltZWxpbmVfaHdzcCAqaHdzcDsKPiAgCj4gLQlpZiAodGltZWxpbmUt Pmh3c3BfZ2d0dCAhPSBndC0+aHdzcCkKPiArCWh3c3AgPSB0aW1lbGluZS0+aHdzcF9nZ3R0LT5w cml2YXRlOwo+ICsJaWYgKCFod3NwKQo+ICAJCXJldHVybjsKPiAgCj4gIAlzcGluX2xvY2soJmd0 LT5od3NwX2xvY2spOwo+IC0JaWYgKHRpbWVsaW5lLT5od3NwX2dndHQgPT0gZ3QtPmh3c3ApCj4g LQkJZ3QtPmJpdG1hcCB8PSBCSVRfVUxMKHRpbWVsaW5lLT5od3NwX29mZnNldCAvIENBQ0hFTElO RV9CWVRFUyk7Cj4gKwo+ICsJaWYgKCFod3NwLT5iaXRtYXApCj4gKwkJbGlzdF9hZGRfdGFpbCgm aHdzcC0+bGluaywgJmd0LT5od3NwKTsKPiArCj4gKwlod3NwLT5iaXRtYXAgfD0gQklUX1VMTCh0 aW1lbGluZS0+aHdzcF9vZmZzZXQgLyBDQUNIRUxJTkVfQllURVMpOwo+ICsKPiArCWlmIChod3Nw LT5iaXRtYXAgPT0gfjB1bGwpIHsKPiArCQlpOTE1X3ZtYV9wdXQoaHdzcC0+dm1hKTsKPiArCQls aXN0X2RlbCgmaHdzcC0+bGluayk7Cj4gKwkJa2ZyZWUoaHdzcCk7Cj4gKwl9Cj4gKwo+ICAJc3Bp bl91bmxvY2soJmd0LT5od3NwX2xvY2spOwo+ICB9Cj4gIAo+IEBAIC0xNDgsNiArMTY4LDcgQEAg dm9pZCBpOTE1X3RpbWVsaW5lc19pbml0KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICppOTE1KQo+ ICAJSU5JVF9MSVNUX0hFQUQoJmd0LT5saXN0KTsKPiAgCj4gIAlzcGluX2xvY2tfaW5pdCgmZ3Qt Pmh3c3BfbG9jayk7Cj4gKwlJTklUX0xJU1RfSEVBRCgmZ3QtPmh3c3ApOwo+ICAKPiAgCS8qIHZp YSBpOTE1X2dlbV93YWl0X2Zvcl9pZGxlKCkgKi8KPiAgCWk5MTVfZ2VtX3Nocmlua2VyX3RhaW50 c19tdXRleChpOTE1LCAmZ3QtPm11dGV4KTsKPiBAQCAtMjY0LDEzICsyODUsOSBAQCB2b2lkIF9f aTkxNV90aW1lbGluZV9mcmVlKHN0cnVjdCBrcmVmICprcmVmKQo+ICB2b2lkIGk5MTVfdGltZWxp bmVzX2Zpbmkoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmk5MTUpCj4gIHsKPiAgCXN0cnVjdCBp OTE1X2d0X3RpbWVsaW5lcyAqZ3QgPSAmaTkxNS0+Z3QudGltZWxpbmVzOwo+IC0Jc3RydWN0IGk5 MTVfdm1hICp2bWE7Cj4gIAo+ICAJR0VNX0JVR19PTighbGlzdF9lbXB0eSgmZ3QtPmxpc3QpKTsK PiAtCj4gLQl2bWEgPSBmZXRjaF9hbmRfemVybygmaTkxNS0+Z3QudGltZWxpbmVzLmh3c3ApOwo+ IC0JaWYgKHZtYSkKPiAtCQlpOTE1X3ZtYV9wdXQodm1hKTsKPiArCUdFTV9CVUdfT04oIWxpc3Rf ZW1wdHkoJmd0LT5od3NwKSk7Cj4gIAo+ICAJbXV0ZXhfZGVzdHJveSgmZ3QtPm11dGV4KTsKPiAg fQo+IC0tIAo+IDIuMjAuMQo+Cj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KPiBJbnRlbC1nZnggbWFpbGluZyBsaXN0Cj4gSW50ZWwtZ2Z4QGxpc3RzLmZy ZWVkZXNrdG9wLm9yZwo+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlz dGluZm8vaW50ZWwtZ2Z4Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9w Lm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVs LWdmeAo=