From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jani Nikula <jani.nikula@linux.intel.com>
Subject: Re: [PATCH] drm/i915: Make CHICKEN_TRANS reg not depend
 on enum value
Date: Fri, 23 Nov 2018 14:03:18 +0200
Message-ID: <87h8g8c86x.fsf@intel.com>
References: <20181119163326.23743-1-imre.deak@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 56F0F6E12C
 for <intel-gfx@lists.freedesktop.org>; Fri, 23 Nov 2018 12:02:50 +0000 (UTC)
In-Reply-To: <20181119163326.23743-1-imre.deak@intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Imre Deak <imre.deak@intel.com>, intel-gfx@lists.freedesktop.org
Cc: Lucas De Marchi <lucas.demarchi@intel.com>
List-Id: intel-gfx@lists.freedesktop.org

T24gTW9uLCAxOSBOb3YgMjAxOCwgSW1yZSBEZWFrIDxpbXJlLmRlYWtAaW50ZWwuY29tPiB3cm90
ZToKPiBEZXBlbmRpbmcgb24gdGhlIHRyYW5zY29kZXIgZW51bSB2YWx1ZXMgdG8gdHJhbnNsYXRl
IGZyb20gdHJhbnNjb2RlciB0byB0aGUKPiBjb3JyZXNwb25kaW5nIENISUNLRU5fVFJBTlMgcmVn
aXN0ZXIgY2FuIGVhc2lseSBicmVhayBpZiB3ZSBhZGQgYSBuZXcKPiB0cmFuc2NvZGVyLiBBZGQg
YW4gZXhwbGljaXQgbWFwcGluZyBpbnN0ZWFkLCBieSB1c2luZyBoZWxwZXJzIHRvIGxvb2sgdXAg
dGhlCj4gcmVnaXN0ZXIgaW5zdGFuY2UgZWl0aGVyIGJ5IHRyYW5zY29kZXIgb3IgcG9ydCAoc2lu
Y2UgdW5jb252ZW5pZW50bHkgdGhlCj4gcmVnaXN0ZXJzIGhhdmUgYm90aCBwb3J0IGFuZCB0cmFu
c2NvZGVyIHNwZWNpZmljIGJpdHMpLgo+Cj4gV2hpbGUgYXQgaXQgYWxzbyBjaGVjayBmb3IgdGhl
IGNvcnJlY3RuZXNzIG9mIEdFTiwgcG9ydCwgdHJhbnNjb2Rlci4gSSB3YXNuJ3QKPiBzdXJlIGlm
IHBzcjJfZW5hYmxlZCBjYW4gb25seSBiZSBzZXQgZm9yIEdFTjkrLCBidXQgdGhhdCBzZWVtcyB0
byBiZSB0aGUgY2FzZQo+IGluZGVlZCAoc2VlIHNldHRpbmcgb2Ygc2lua19wc3IyX3N1cHBvcnQg
aW4gaW50ZWxfcHNyX2luaXRfZHBjZCgpKS4KPgo+IENjOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxl
LnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+IENjOiBMdWNhcyBEZSBNYXJjaGkgPGx1Y2FzLmRl
bWFyY2hpQGludGVsLmNvbT4KPiBDYzogTWlrYSBLYWhvbGEgPG1pa2Eua2Fob2xhQGludGVsLmNv
bT4KPiBTaWduZWQtb2ZmLWJ5OiBJbXJlIERlYWsgPGltcmUuZGVha0BpbnRlbC5jb20+Cj4gLS0t
Cj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcmVnLmggIHwgIDcgKysrLS0tCj4gIGRyaXZl
cnMvZ3B1L2RybS9pOTE1L2ludGVsX2RkaS5jIHwgNTMgKysrKysrKysrKysrKysrKysrKysrKysr
KysrKysrKy0tLS0tLS0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcnYuaCB8ICAy
ICsrCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Bzci5jIHwgIDYgKysrLS0KPiAgNCBm
aWxlcyBjaGFuZ2VkLCA1MSBpbnNlcnRpb25zKCspLCAxNyBkZWxldGlvbnMoLSkKPgo+IGRpZmYg
LS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3JlZy5oIGIvZHJpdmVycy9ncHUvZHJt
L2k5MTUvaTkxNV9yZWcuaAo+IGluZGV4IDI1YjA2OTE3NWMyYS4uMWJlZWQzOWRlMzAzIDEwMDY0
NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcmVnLmgKPiArKysgYi9kcml2ZXJz
L2dwdS9kcm0vaTkxNS9pOTE1X3JlZy5oCj4gQEAgLTczOTksOSArNzM5OSwxMCBAQCBlbnVtIHsK
PiAgI2RlZmluZSAgQkRXX0RQUlNfTUFTS19WQkxBTktfU1JECSgxIDw8IDApCj4gICNkZWZpbmUg
Q0hJQ0tFTl9QSVBFU0xfMShwaXBlKSBfTU1JT19QSVBFKHBpcGUsIF9DSElDS0VOX1BJUEVTTF8x
X0EsIF9DSElDS0VOX1BJUEVTTF8xX0IpCj4gIAo+IC0jZGVmaW5lIENISUNLRU5fVFJBTlNfQSAg
ICAgICAgIDB4NDIwYzAKPiAtI2RlZmluZSBDSElDS0VOX1RSQU5TX0IgICAgICAgICAweDQyMGM0
Cj4gLSNkZWZpbmUgQ0hJQ0tFTl9UUkFOUyh0cmFucykgX01NSU9fVFJBTlModHJhbnMsIENISUNL
RU5fVFJBTlNfQSwgQ0hJQ0tFTl9UUkFOU19CKQo+ICsjZGVmaW5lIENISUNLRU5fVFJBTlNfQQkJ
X01NSU8oMHg0MjBjMCkKPiArI2RlZmluZSBDSElDS0VOX1RSQU5TX0IJCV9NTUlPKDB4NDIwYzQp
Cj4gKyNkZWZpbmUgQ0hJQ0tFTl9UUkFOU19DCQlfTU1JTygweDQyMGM4KQo+ICsjZGVmaW5lIENI
SUNLRU5fVFJBTlNfRURQCV9NTUlPKDB4NDIwY2MpCj4gICNkZWZpbmUgIFZTQ19EQVRBX1NFTF9T
T0ZUV0FSRV9DT05UUk9MCSgxIDw8IDI1KSAvKiBHTEsgYW5kIENOTCsgKi8KPiAgI2RlZmluZSAg
RERJX1RSQUlOSU5HX09WRVJSSURFX0VOQUJMRQkoMSA8PCAxOSkKPiAgI2RlZmluZSAgRERJX1RS
QUlOSU5HX09WRVJSSURFX1ZBTFVFCSgxIDw8IDE4KQo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dw
dS9kcm0vaTkxNS9pbnRlbF9kZGkuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RkaS5j
Cj4gaW5kZXggMDQwNDgzYzk2MDI5Li4xMjZlNmFhYzMzNWQgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVy
cy9ncHUvZHJtL2k5MTUvaW50ZWxfZGRpLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p
bnRlbF9kZGkuYwo+IEBAIC0zMzgwLDYgKzMzODAsNDIgQEAgc3RhdGljIHZvaWQgaW50ZWxfZW5h
YmxlX2RkaV9kcChzdHJ1Y3QgaW50ZWxfZW5jb2RlciAqZW5jb2RlciwKPiAgCQlpbnRlbF9hdWRp
b19jb2RlY19lbmFibGUoZW5jb2RlciwgY3J0Y19zdGF0ZSwgY29ubl9zdGF0ZSk7Cj4gIH0KPiAg
Cj4gK2k5MTVfcmVnX3QgZ2VuOV9jaGlja2VuX3RyYW5zX3JlZyhzdHJ1Y3QgZHJtX2k5MTVfcHJp
dmF0ZSAqZGV2X3ByaXYsCj4gKwkJCQkgIGVudW0gdHJhbnNjb2RlciB0cmFucykKPiArewo+ICsJ
c3RhdGljIGNvbnN0IGk5MTVfcmVnX3QgcmVnc1tdID0gewo+ICsJCVtUUkFOU0NPREVSX0FdID0g
Q0hJQ0tFTl9UUkFOU19BLAo+ICsJCVtUUkFOU0NPREVSX0JdID0gQ0hJQ0tFTl9UUkFOU19CLAo+
ICsJCVtUUkFOU0NPREVSX0NdID0gQ0hJQ0tFTl9UUkFOU19DLAo+ICsJCVtUUkFOU0NPREVSX0VE
UF0gPSBDSElDS0VOX1RSQU5TX0VEUCwKPiArCX07Cj4gKwo+ICsJV0FSTl9PTihJTlRFTF9HRU4o
ZGV2X3ByaXYpIDwgOSk7Cj4gKwo+ICsJaWYgKFdBUk5fT04odHJhbnMgPj0gQVJSQVlfU0laRShy
ZWdzKSB8fCAhcmVnc1t0cmFuc10ucmVnKSkKPiArCQl0cmFucyA9IFRSQU5TQ09ERVJfQTsKPiAr
Cj4gKwlyZXR1cm4gcmVnc1t0cmFuc107Cj4gK30KCkknbSBsYXRlIHRvIHRoZSBwYXJ0eSwgYnV0
IGl0IGtpbmQgb2YgbWFrZXMgbWUgc2FkIHRoYXQgd2UncmUgbm93CmludHJvZHVjaW5nIHlldCBh
bm90aGVyIHdheSB0byBjaG9vc2UgcmVnaXN0ZXJzIGJhc2VkIG9uIHRyYW5zY29kZXIgKG9yCnNv
bWUgb3RoZXIgaW5kZXgpLiBBbmQgdGhpcyBvbmUgaXMgaGFuZC1yb2xsZWQsIHdpdGggbG9jYWwg
ZnVuY3Rpb25zCmluc3RlYWQgb2YgcHV0dGluZyBpdCB0byBpOTE1X3JlZy5oLgoKQlIsCkphbmku
CgoKPiArCj4gK3N0YXRpYyBpOTE1X3JlZ190Cj4gK2dlbjlfY2hpY2tlbl90cmFuc19yZWdfYnlf
cG9ydChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gKwkJCSAgICAgICBlbnVt
IHBvcnQgcG9ydCkKPiArewo+ICsJc3RhdGljIGNvbnN0IGVudW0gdHJhbnNjb2RlciBwb3J0X3Rv
X3RyYW5zY29kZXJbXSA9IHsKPiArCQlbUE9SVF9BXSA9IFRSQU5TQ09ERVJfRURQLAo+ICsJCVtQ
T1JUX0JdID0gVFJBTlNDT0RFUl9BLAo+ICsJCVtQT1JUX0NdID0gVFJBTlNDT0RFUl9CLAo+ICsJ
CVtQT1JUX0RdID0gVFJBTlNDT0RFUl9DLAo+ICsJCVtQT1JUX0VdID0gVFJBTlNDT0RFUl9BLAo+
ICsJfTsKPiArCj4gKwlpZiAoV0FSTl9PTihwb3J0IDwgUE9SVF9BIHx8IHBvcnQgPiBQT1JUX0Up
KQo+ICsJCXBvcnQgPSBQT1JUX0E7Cj4gKwo+ICsJcmV0dXJuIGdlbjlfY2hpY2tlbl90cmFuc19y
ZWcoZGV2X3ByaXYsIHBvcnRfdG9fdHJhbnNjb2Rlcltwb3J0XSk7Cj4gK30KPiArCj4gIHN0YXRp
YyB2b2lkIGludGVsX2VuYWJsZV9kZGlfaGRtaShzdHJ1Y3QgaW50ZWxfZW5jb2RlciAqZW5jb2Rl
ciwKPiAgCQkJCSAgY29uc3Qgc3RydWN0IGludGVsX2NydGNfc3RhdGUgKmNydGNfc3RhdGUsCj4g
IAkJCQkgIGNvbnN0IHN0cnVjdCBkcm1fY29ubmVjdG9yX3N0YXRlICpjb25uX3N0YXRlKQo+IEBA
IC0zNDAzLDE3ICszNDM5LDEwIEBAIHN0YXRpYyB2b2lkIGludGVsX2VuYWJsZV9kZGlfaGRtaShz
dHJ1Y3QgaW50ZWxfZW5jb2RlciAqZW5jb2RlciwKPiAgCQkgKiB0aGUgYml0cyBhZmZlY3QgYSBz
cGVjaWZpYyBEREkgcG9ydCByYXRoZXIgdGhhbgo+ICAJCSAqIGEgc3BlY2lmaWMgdHJhbnNjb2Rl
ci4KPiAgCQkgKi8KPiAtCQlzdGF0aWMgY29uc3QgZW51bSB0cmFuc2NvZGVyIHBvcnRfdG9fdHJh
bnNjb2RlcltdID0gewo+IC0JCQlbUE9SVF9BXSA9IFRSQU5TQ09ERVJfRURQLAo+IC0JCQlbUE9S
VF9CXSA9IFRSQU5TQ09ERVJfQSwKPiAtCQkJW1BPUlRfQ10gPSBUUkFOU0NPREVSX0IsCj4gLQkJ
CVtQT1JUX0RdID0gVFJBTlNDT0RFUl9DLAo+IC0JCQlbUE9SVF9FXSA9IFRSQU5TQ09ERVJfQSwK
PiAtCQl9Owo+IC0JCWVudW0gdHJhbnNjb2RlciB0cmFuc2NvZGVyID0gcG9ydF90b190cmFuc2Nv
ZGVyW3BvcnRdOwo+ICsJCWk5MTVfcmVnX3QgcmVnID0gZ2VuOV9jaGlja2VuX3RyYW5zX3JlZ19i
eV9wb3J0KGRldl9wcml2LCBwb3J0KTsKPiAgCQl1MzIgdmFsOwo+ICAKPiAtCQl2YWwgPSBJOTE1
X1JFQUQoQ0hJQ0tFTl9UUkFOUyh0cmFuc2NvZGVyKSk7Cj4gKwkJdmFsID0gSTkxNV9SRUFEKHJl
Zyk7Cj4gIAo+ICAJCWlmIChwb3J0ID09IFBPUlRfRSkKPiAgCQkJdmFsIHw9IERESUVfVFJBSU5J
TkdfT1ZFUlJJREVfRU5BQkxFIHwKPiBAQCAtMzQyMiw4ICszNDUxLDggQEAgc3RhdGljIHZvaWQg
aW50ZWxfZW5hYmxlX2RkaV9oZG1pKHN0cnVjdCBpbnRlbF9lbmNvZGVyICplbmNvZGVyLAo+ICAJ
CQl2YWwgfD0gRERJX1RSQUlOSU5HX09WRVJSSURFX0VOQUJMRSB8Cj4gIAkJCQlERElfVFJBSU5J
TkdfT1ZFUlJJREVfVkFMVUU7Cj4gIAo+IC0JCUk5MTVfV1JJVEUoQ0hJQ0tFTl9UUkFOUyh0cmFu
c2NvZGVyKSwgdmFsKTsKPiAtCQlQT1NUSU5HX1JFQUQoQ0hJQ0tFTl9UUkFOUyh0cmFuc2NvZGVy
KSk7Cj4gKwkJSTkxNV9XUklURShyZWcsIHZhbCk7Cj4gKwkJUE9TVElOR19SRUFEKHJlZyk7Cj4g
IAo+ICAJCXVkZWxheSgxKTsKPiAgCj4gQEAgLTM0MzQsNyArMzQ2Myw3IEBAIHN0YXRpYyB2b2lk
IGludGVsX2VuYWJsZV9kZGlfaGRtaShzdHJ1Y3QgaW50ZWxfZW5jb2RlciAqZW5jb2RlciwKPiAg
CQkJdmFsICY9IH4oRERJX1RSQUlOSU5HX09WRVJSSURFX0VOQUJMRSB8Cj4gIAkJCQkgRERJX1RS
QUlOSU5HX09WRVJSSURFX1ZBTFVFKTsKPiAgCj4gLQkJSTkxNV9XUklURShDSElDS0VOX1RSQU5T
KHRyYW5zY29kZXIpLCB2YWwpOwo+ICsJCUk5MTVfV1JJVEUocmVnLCB2YWwpOwo+ICAJfQo+ICAK
PiAgCS8qIEluIEhETUkvRFZJIG1vZGUsIHRoZSBwb3J0IHdpZHRoLCBhbmQgc3dpbmcvZW1waGFz
aXMgdmFsdWVzCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5o
IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmgKPiBpbmRleCBmNTc1YmEyYTU5ZGEu
LjBkMDY0YjcxMDAyYiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9k
cnYuaAo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5oCj4gQEAgLTE1MjYs
NiArMTUyNiw4IEBAIHZvaWQgaWNsX3Nhbml0aXplX2VuY29kZXJfcGxsX21hcHBpbmcoc3RydWN0
IGludGVsX2VuY29kZXIgKmVuY29kZXIpOwo+ICAKPiAgdW5zaWduZWQgaW50IGludGVsX2ZiX2Fs
aWduX2hlaWdodChjb25zdCBzdHJ1Y3QgZHJtX2ZyYW1lYnVmZmVyICpmYiwKPiAgCQkJCSAgIGlu
dCBjb2xvcl9wbGFuZSwgdW5zaWduZWQgaW50IGhlaWdodCk7Cj4gK2k5MTVfcmVnX3QgZ2VuOV9j
aGlja2VuX3RyYW5zX3JlZyhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gKwkJ
CQkgIGVudW0gdHJhbnNjb2RlciB0cmFucyk7Cj4gIAo+ICAvKiBpbnRlbF9hdWRpby5jICovCj4g
IHZvaWQgaW50ZWxfaW5pdF9hdWRpb19ob29rcyhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2
X3ByaXYpOwo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wc3IuYyBi
L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Bzci5jCj4gaW5kZXggNWZkYzJmMTk2MDQ1Li5i
NGQ4MTFjNjI0NzMgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcHNy
LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wc3IuYwo+IEBAIC02MDYsNyAr
NjA2LDkgQEAgc3RhdGljIHZvaWQgaW50ZWxfcHNyX2VuYWJsZV9zb3VyY2Uoc3RydWN0IGludGVs
X2RwICppbnRlbF9kcCwKPiAgCQloc3dfcHNyX3NldHVwX2F1eChpbnRlbF9kcCk7Cj4gIAo+ICAJ
aWYgKGRldl9wcml2LT5wc3IucHNyMl9lbmFibGVkKSB7Cj4gLQkJdTMyIGNoaWNrZW4gPSBJOTE1
X1JFQUQoQ0hJQ0tFTl9UUkFOUyhjcHVfdHJhbnNjb2RlcikpOwo+ICsJCWk5MTVfcmVnX3QgcmVn
ID0gZ2VuOV9jaGlja2VuX3RyYW5zX3JlZyhkZXZfcHJpdiwKPiArCQkJCQkJCWNwdV90cmFuc2Nv
ZGVyKTsKPiArCQl1MzIgY2hpY2tlbiA9IEk5MTVfUkVBRChyZWcpOwo+ICAKPiAgCQlpZiAoSVNf
R0VOOShkZXZfcHJpdikgJiYgIUlTX0dFTUlOSUxBS0UoZGV2X3ByaXYpKQo+ICAJCQljaGlja2Vu
IHw9IChQU1IyX1ZTQ19FTkFCTEVfUFJPR19IRUFERVIKPiBAQCAtNjE0LDcgKzYxNiw3IEBAIHN0
YXRpYyB2b2lkIGludGVsX3Bzcl9lbmFibGVfc291cmNlKHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxf
ZHAsCj4gIAo+ICAJCWVsc2UKPiAgCQkJY2hpY2tlbiAmPSB+VlNDX0RBVEFfU0VMX1NPRlRXQVJF
X0NPTlRST0w7Cj4gLQkJSTkxNV9XUklURShDSElDS0VOX1RSQU5TKGNwdV90cmFuc2NvZGVyKSwg
Y2hpY2tlbik7Cj4gKwkJSTkxNV9XUklURShyZWcsIGNoaWNrZW4pOwo+ICAJfQo+ICAKPiAgCS8q
CgotLSAKSmFuaSBOaWt1bGEsIEludGVsIE9wZW4gU291cmNlIEdyYXBoaWNzIENlbnRlcgpfX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFp
bGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5m
cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK