From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Kuoppala Subject: Re: [PATCH 12/31] drm/i915: Reduce spinlock hold time during notify_ring() interrupt Date: Wed, 27 Jun 2018 16:08:34 +0300 Message-ID: <87h8lov0kt.fsf@gaia.fi.intel.com> References: <20180625094842.8499-1-chris@chris-wilson.co.uk> <20180625094842.8499-12-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1810A6E908 for ; Wed, 27 Jun 2018 13:09:21 +0000 (UTC) In-Reply-To: <20180625094842.8499-12-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Q2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+IHdyaXRlczoKCj4gQnkgdGFr aW5nIGFkdmFudGFnZSBvZiB0aGUgUkNVIHByb3RlY3Rpb24gb2YgdGhlIHRhc2sgc3RydWN0LCB3 ZSBjYW4gZmluZAo+IHRoZSBhcHByb3ByaWF0ZSBzaWduYWxlciB1bmRlciB0aGUgc3BpbmxvY2sg YW5kIHRoZW4gcmVsZWFzZSB0aGUgc3BpbmxvY2sKPiBiZWZvcmUgd2FraW5nIHRoZSB0YXNrIGFu ZCBzaWduYWxpbmcgdGhlIGZlbmNlLgo+Cj4gU2lnbmVkLW9mZi1ieTogQ2hyaXMgV2lsc29uIDxj aHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5 MTVfaXJxLmMgfCAzMyArKysrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0KPiAgMSBmaWxl IGNoYW5nZWQsIDIyIGluc2VydGlvbnMoKyksIDExIGRlbGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdp dCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfaXJxLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pOTE1X2lycS5jCj4gaW5kZXggMzE2ZDBiMDhkNDBmLi41M2RhZDQ4ZjkyY2UgMTAwNjQ0Cj4g LS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9pcnEuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2k5MTVfaXJxLmMKPiBAQCAtMTE0NSwyMSArMTE0NSwyMyBAQCBzdGF0aWMgdm9p ZCBpcm9ubGFrZV9ycHNfY2hhbmdlX2lycV9oYW5kbGVyKHN0cnVjdCBkcm1faTkxNV9wcml2YXRl ICpkZXZfcHJpdikKPiAgCj4gIHN0YXRpYyB2b2lkIG5vdGlmeV9yaW5nKHN0cnVjdCBpbnRlbF9l bmdpbmVfY3MgKmVuZ2luZSkKPiAgewo+ICsJY29uc3QgdTMyIHNlcW5vID0gaW50ZWxfZW5naW5l X2dldF9zZXFubyhlbmdpbmUpOwo+ICAJc3RydWN0IGk5MTVfcmVxdWVzdCAqcnEgPSBOVUxMOwo+ ICsJc3RydWN0IHRhc2tfc3RydWN0ICp0c2sgPSBOVUxMOwo+ICAJc3RydWN0IGludGVsX3dhaXQg KndhaXQ7Cj4gIAo+IC0JaWYgKCFlbmdpbmUtPmJyZWFkY3J1bWJzLmlycV9hcm1lZCkKPiArCWlm ICh1bmxpa2VseSghZW5naW5lLT5icmVhZGNydW1icy5pcnFfYXJtZWQpKQo+ICAJCXJldHVybjsK PgoKT2ssIHNvIGR1ZSB0byB1bmxpa2VsaW5lc3MsIHlvdSBnZXQgdGhlIHNlcW5vIGVhcmx5LgoK PiAgCWF0b21pY19pbmMoJmVuZ2luZS0+aXJxX2NvdW50KTsKPiAtCXNldF9iaXQoRU5HSU5FX0lS UV9CUkVBRENSVU1CLCAmZW5naW5lLT5pcnFfcG9zdGVkKTsKPiArCj4gKwlyY3VfcmVhZF9sb2Nr KCk7CgpBcyBJIHVuZGVyc3RhbmQgZnJvbSBpcmMgZGlzY3Vzc2lvbiwgd2UgaGF2ZSBvdXIgb3du IGNvbnN0Cm9yIHN0YWJsZSBjb3B5IG9mIHRhc2sgc3RydWN0IGZyb20gbm93IG9uLgo+ICAKPiAg CXNwaW5fbG9jaygmZW5naW5lLT5icmVhZGNydW1icy5pcnFfbG9jayk7Cj4gIAl3YWl0ID0gZW5n aW5lLT5icmVhZGNydW1icy5pcnFfd2FpdDsKPiAgCWlmICh3YWl0KSB7Cj4gLQkJYm9vbCB3YWtl dXAgPSBlbmdpbmUtPmlycV9zZXFub19iYXJyaWVyOwo+IC0KPiAtCQkvKiBXZSB1c2UgYSBjYWxs YmFjayBmcm9tIHRoZSBkbWEtZmVuY2UgdG8gc3VibWl0Cj4gKwkJLyoKPiArCQkgKiBXZSB1c2Ug YSBjYWxsYmFjayBmcm9tIHRoZSBkbWEtZmVuY2UgdG8gc3VibWl0Cj4gIAkJICogcmVxdWVzdHMg YWZ0ZXIgd2FpdGluZyBvbiBvdXIgb3duIHJlcXVlc3RzLiBUbwo+ICAJCSAqIGVuc3VyZSBtaW5p bXVtIGRlbGF5IGluIHF1ZXVpbmcgdGhlIG5leHQgcmVxdWVzdCB0bwo+ICAJCSAqIGhhcmR3YXJl LCBzaWduYWwgdGhlIGZlbmNlIG5vdyByYXRoZXIgdGhhbiB3YWl0IGZvcgo+IEBAIC0xMTcwLDE5 ICsxMTcyLDIzIEBAIHN0YXRpYyB2b2lkIG5vdGlmeV9yaW5nKHN0cnVjdCBpbnRlbF9lbmdpbmVf Y3MgKmVuZ2luZSkKPiAgCQkgKiBhbmQgdG8gaGFuZGxlIGNvYWxlc2Npbmcgb2YgbXVsdGlwbGUg c2Vxbm8gdXBkYXRlcwo+ICAJCSAqIGFuZCBtYW55IHdhaXRlcnMuCj4gIAkJICovCj4gLQkJaWYg KGk5MTVfc2Vxbm9fcGFzc2VkKGludGVsX2VuZ2luZV9nZXRfc2Vxbm8oZW5naW5lKSwKPiAtCQkJ CSAgICAgIHdhaXQtPnNlcW5vKSkgewo+ICsJCWlmIChpOTE1X3NlcW5vX3Bhc3NlZChzZXFubywg d2FpdC0+c2Vxbm8pKSB7Cj4gIAkJCXN0cnVjdCBpOTE1X3JlcXVlc3QgKndhaXRlciA9IHdhaXQt PnJlcXVlc3Q7Cj4gIAo+IC0JCQl3YWtldXAgPSB0cnVlOwo+ICAJCQlpZiAoIXRlc3RfYml0KERN QV9GRU5DRV9GTEFHX1NJR05BTEVEX0JJVCwKPiAgCQkJCSAgICAgICZ3YWl0ZXItPmZlbmNlLmZs YWdzKSAmJgo+ICAJCQkgICAgaW50ZWxfd2FpdF9jaGVja19yZXF1ZXN0KHdhaXQsIHdhaXRlcikp Cj4gIAkJCQlycSA9IGk5MTVfcmVxdWVzdF9nZXQod2FpdGVyKTsKPiAtCQl9Cj4gIAo+IC0JCWlm ICh3YWtldXApCj4gLQkJCXdha2VfdXBfcHJvY2Vzcyh3YWl0LT50c2spOwo+ICsJCQl0c2sgPSB3 YWl0LT50c2s7Cj4gKwkJfSBlbHNlIHsKPiArCQkJaWYgKGVuZ2luZS0+aXJxX3NlcW5vX2JhcnJp ZXIgJiYKPiArCQkJICAgIGk5MTVfc2Vxbm9fcGFzc2VkKHNlcW5vLCB3YWl0LT5zZXFubyAtIDEp KSB7Cj4gKwkJCQlzZXRfYml0KEVOR0lORV9JUlFfQlJFQURDUlVNQiwKPiArCQkJCQkmZW5naW5l LT5pcnFfcG9zdGVkKTsKPiArCQkJCXRzayA9IHdhaXQtPnRzazsKCkhtbSwgeW91IGFyZSBvcHRp bWlzdGljIHRoYXQgdGhlIGxhdGVuY3kgb2Ygd2FrZXVwIHdpbGwgYmUgb24gcGFyCm9yIGdyZWF0 ZXIgdGhhbiB0aGUgbmV4dCByZXF1ZXN0IGNvbXBsZXRpb24/CgpBbmQgd2FpdCBzaWRlIG5vdGlj ZXMgdG9vIHRoYXQgd2UgYXJlIGNsb3NlIGFuZCBzcGlucywKaW5zdGVhZCBvZiBnb2luZyBiYWNr IHRvIHNsZWVwPwoKPiArCQkJfQo+ICsJCX0KPiAgCX0gZWxzZSB7Cj4gIAkJaWYgKGVuZ2luZS0+ YnJlYWRjcnVtYnMuaXJxX2FybWVkKQo+ICAJCQlfX2ludGVsX2VuZ2luZV9kaXNhcm1fYnJlYWRj cnVtYnMoZW5naW5lKTsKPiBAQCAtMTE5NSw2ICsxMjAxLDExIEBAIHN0YXRpYyB2b2lkIG5vdGlm eV9yaW5nKHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2luZSkKPiAgCQlpOTE1X3JlcXVlc3Rf cHV0KHJxKTsKPiAgCX0KPiAgCj4gKwlpZiAodHNrICYmIHRzay0+c3RhdGUgJiBUQVNLX05PUk1B TCkKPiArCQl3YWtlX3VwX3Byb2Nlc3ModHNrKTsKPiArCgpXaHkgdGhlIFRBU0tfTk9STUFMIGNo ZWNrPwoKLU1pa2EKCj4gKwlyY3VfcmVhZF91bmxvY2soKTsKPiArCj4gIAl0cmFjZV9pbnRlbF9l bmdpbmVfbm90aWZ5KGVuZ2luZSwgd2FpdCk7Cj4gIH0KPiAgCj4gLS0gCj4gMi4xOC4wCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWls aW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZy ZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=