From: Jani Nikula <jani.nikula@linux.intel.com>
To: Daniel Vetter <daniel@ffwll.ch>,
Lucas De Marchi <lucas.de.marchi@gmail.com>
Cc: Lucas De Marchi <lucas.demarchi@intel.com>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
intel-gfx@lists.freedesktop.org, dim-tools@lists.freedesktop.org,
Daniel Vetter <daniel.vetter@intel.com>
Subject: Re: [PATCH] dim: replace pipe commands with single sed
Date: Thu, 17 May 2018 12:13:34 +0300 [thread overview]
Message-ID: <87h8n6zltt.fsf@intel.com> (raw)
In-Reply-To: <20180512194443.GY28661@phenom.ffwll.local>
On Sat, 12 May 2018, Daniel Vetter <daniel@ffwll.ch> wrote:
> On Wed, May 09, 2018 at 04:32:53PM -0700, Lucas De Marchi wrote:
>> Now CC the right mailing list. The way dim sets up the repository you
>> can't have individual git configs, e.g. to set a different
>> sendemail.to for dim-tools :(
>>
>> Lucas De Marchi
>>
>> On Wed, May 9, 2018 at 2:28 PM, Lucas De Marchi
>> <lucas.demarchi@intel.com> wrote:
>> > A single sed can do the job of taking the second line after a match and
>> > it looks simpler.
>> >
>> > Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
>> > ---
>> >
>> > I noticed this while reviewing "[PATCH 2/4] dim: shut up sed broken pipe
>> > noise in apply-pull".
>
> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Thanks, pushed.
>
>> >
>> > dim | 2 +-
>> > 1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > diff --git a/dim b/dim
>> > index 6b684ba5308c..f7cf255db3e1 100755
>> > --- a/dim
>> > +++ b/dim
>> > @@ -924,7 +924,7 @@ function dim_apply_pull
>> >
>> > cat > $file
>> >
>> > - pull_branch=$(sed -e '0,/[gG]it repository at:$/d' $file | head -n 2 | tail -n 1)
>> > + pull_branch=$(sed -ne '/[gG]it repository at:$/{n;n;p}' $file)
>> >
>> > if [[ -z "$pull_branch" ]] ; then
>> > echoerr "no pull request found"
>> > --
>> > 2.17.0
>> >
>> > _______________________________________________
>> > Intel-gfx mailing list
>> > Intel-gfx@lists.freedesktop.org
>> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
>>
>>
>>
>> --
>> Lucas De Marchi
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2018-05-17 9:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-09 21:28 [PATCH] dim: replace pipe commands with single sed Lucas De Marchi
2018-05-09 23:32 ` Lucas De Marchi
2018-05-12 19:44 ` Daniel Vetter
2018-05-17 9:13 ` Jani Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h8n6zltt.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=daniel@ffwll.ch \
--cc=dim-tools@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=lucas.de.marchi@gmail.com \
--cc=lucas.demarchi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.