Re: [PATCH 5/5] wcn36xx: pass information elements in scan requests

[Kalle Valo <kvalo@codeaurora.org>]

Daniel Mack <daniel@zonque.org> writes:

> On Monday, April 16, 2018 04:03 PM, Kalle Valo wrote:
>> Daniel Mack <daniel@zonque.org> writes:
>> 
>>> When the ieee8022 core passes IE elements in the scan request, append
>> 
>> You mean mac80211?
>> 
>> And yeah, the ieee80211_ prefix is confusing. Many many years I
>> started to change that to mac80211_ but gave up :(
>
> Ah, yeah. I was just referring to the wifi core driver stack.

We call the components mac80211 and cfg80211, please don't invent new
names for them.

>>> them to the firmware message. The driver currently tells the core that
>>> it is capable of attaching up to WCN36XX_MAX_SCAN_IE_LEN octets, but
>>> doesn't actually pass them to the the hardware.
>>>
>>> Some defines were moved around to avoid cyclic include dependencies.
>> 
>> Does this fix anything or change functionality somehow? You should
>> document that also in the commit log.
>
> I don't have a test case for this, no. But as the change was pretty much
> straight forward, I sent it anyway.

Ok, but you should still explain that in the commit log. In other words,
you should always answer the question "Why?" in the commit log.

> I can resend with some more information on this if you like.

No need to resend because of this, I can edit the commit log.

-- 
Kalle Valo