From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Lars Schneider" <larsxschneider@gmail.com>,
"Duy Nguyen" <pclouds@gmail.com>,
"Lars Schneider" <lars.schneider@autodesk.com>,
"Git Mailing List" <git@vger.kernel.org>,
"Torsten Bögershausen" <tboegi@web.de>,
"Johannes Sixt" <j6t@kdbg.org>,
"Eric Sunshine" <sunshine@sunshineco.com>,
"Jeff King" <peff@peff.net>,
"Ramsay Jones" <ramsay@ramsayjones.plus.com>,
"Johannes Schindelin" <Johannes.Schindelin@gmx.de>
Subject: Re: [PATCH v10 3/9] strbuf: add a case insensitive starts_with()
Date: Fri, 09 Mar 2018 20:06:05 +0100 [thread overview]
Message-ID: <87h8ppqdb6.fsf@evledraar.gmail.com> (raw)
In-Reply-To: <xmqqmuzh6u8g.fsf@gitster-ct.c.googlers.com>
On Fri, Mar 09 2018, Junio C. Hamano jotted:
> Lars Schneider <larsxschneider@gmail.com> writes:
>
>> I think following the boost lib makes most sense. Therefore,
>> I would like to go with "istarts_with". OK with you?
>
> I don't care too deeply; if we took starts_with() from there, where
> what we now want is defined as istarts_with(), then that sounds like
> a good thing to do.
I don't care either, but just a note that we had this exact discussion
around this time last year when I added a starts_with_icase() [1][2]
which eventually got dropped.
1. https://public-inbox.org/git/xmqqpohao2hw.fsf@gitster.mtv.corp.google.com/
2. https://public-inbox.org/git/20170326121654.22035-4-avarab@gmail.com/
next prev parent reply other threads:[~2018-03-09 19:06 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-07 17:30 [PATCH v10 0/9] convert: add support for different encodings lars.schneider
2018-03-07 17:30 ` [PATCH v10 1/9] strbuf: remove unnecessary NUL assignment in xstrdup_tolower() lars.schneider
2018-03-07 17:30 ` [PATCH v10 2/9] strbuf: add xstrdup_toupper() lars.schneider
2018-03-07 17:30 ` [PATCH v10 3/9] strbuf: add a case insensitive starts_with() lars.schneider
2018-03-08 0:31 ` Duy Nguyen
2018-03-08 23:12 ` Junio C Hamano
2018-03-09 15:54 ` Lars Schneider
2018-03-09 17:20 ` Junio C Hamano
2018-03-09 19:06 ` Ævar Arnfjörð Bjarmason [this message]
2018-03-07 17:30 ` [PATCH v10 4/9] utf8: add function to detect prohibited UTF-16/32 BOM lars.schneider
2018-03-07 17:30 ` [PATCH v10 5/9] utf8: add function to detect a missing " lars.schneider
2018-03-07 17:30 ` [PATCH v10 6/9] convert: add 'working-tree-encoding' attribute lars.schneider
2018-03-07 17:54 ` Eric Sunshine
2018-03-07 22:56 ` Lars Schneider
2018-03-07 22:57 ` Junio C Hamano
2018-03-07 19:35 ` Junio C Hamano
2018-03-07 17:30 ` [PATCH v10 7/9] convert: check for detectable errors in UTF encodings lars.schneider
2018-03-07 18:04 ` Eric Sunshine
2018-03-09 17:02 ` Lars Schneider
2018-03-07 19:49 ` Junio C Hamano
2018-03-07 22:12 ` Lars Schneider
2018-03-07 22:32 ` Junio C Hamano
2018-03-07 22:49 ` Lars Schneider
2018-03-07 22:57 ` Junio C Hamano
2018-03-07 23:19 ` Lars Schneider
2018-03-07 23:34 ` Junio C Hamano
2018-03-07 17:30 ` [PATCH v10 8/9] convert: add tracing for 'working-tree-encoding' attribute lars.schneider
2018-03-07 17:30 ` [PATCH v10 9/9] convert: add round trip check based on 'core.checkRoundtripEncoding' lars.schneider
2018-03-07 19:59 ` Junio C Hamano
2018-03-07 22:44 ` Lars Schneider
2018-03-07 22:52 ` Junio C Hamano
2018-03-07 22:58 ` Lars Schneider
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h8ppqdb6.fsf@evledraar.gmail.com \
--to=avarab@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j6t@kdbg.org \
--cc=lars.schneider@autodesk.com \
--cc=larsxschneider@gmail.com \
--cc=pclouds@gmail.com \
--cc=peff@peff.net \
--cc=ramsay@ramsayjones.plus.com \
--cc=sunshine@sunshineco.com \
--cc=tboegi@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.