From: Jani Nikula <jani.nikula@linux.intel.com>
To: Alex Ivanov <gnidorah@ya.ru>, Daniel Vetter <daniel@ffwll.ch>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm: Add DPMS ioctl
Date: Wed, 11 Oct 2017 18:58:14 +0300 [thread overview]
Message-ID: <87h8v5ptgp.fsf@intel.com> (raw)
In-Reply-To: <43e65672-0fe3-28c4-95c9-77b5be6408c1@ya.ru>
On Wed, 11 Oct 2017, Alex Ivanov <gnidorah@ya.ru> wrote:
> On 11.10.2017 12:04, Daniel Vetter wrote:
>>
>> Why exactly is the existing dpms ioctl not good enough? it's implemented
>> as the "DPMS" property attached to connectors, but that's the only
>> difference compared to your code here.
>>
>> Also, that one doesn't have any XXX about atomic like yours.
>>
>> I also have no idea how this fixes any of your above problems.
>> -Daniel
> It's not good enough because it will only succeed if caller is current
> DRM master. Which means it will work only in console, since X.Org
> and Wayland hold DRM_MASTER.
As said elsewhere in the thread, this is a feature, not a bug.
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2017-10-11 15:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-11 7:46 [PATCH] drm: Add DPMS ioctl Alex Ivanov
2017-10-11 9:04 ` Daniel Vetter
2017-10-11 10:58 ` Alex Ivanov
2017-10-11 15:58 ` Jani Nikula [this message]
2017-10-11 10:13 ` Daniel Stone
2017-10-11 11:22 ` Alex Ivanov
2017-10-11 11:56 ` Daniel Stone
2017-10-11 13:47 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h8v5ptgp.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=gnidorah@ya.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.