From: Andreas Schwab <schwab@linux-m68k.org>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: git@vger.kernel.org, "Junio C Hamano" <gitster@pobox.com>,
"David Coppa" <dcoppa@openbsd.org>, "René Scharfe" <l.s.r@web.de>
Subject: Re: [PATCH] tests: don't give unportable ">" to "test" built-in, use -gt
Date: Mon, 07 Aug 2017 20:06:28 +0200 [thread overview]
Message-ID: <87h8xjfe1n.fsf@linux-m68k.org> (raw)
In-Reply-To: <20170806233850.14711-1-avarab@gmail.com> ("Ævar Arnfjörð Bjarmason"'s message of "Sun, 6 Aug 2017 23:38:50 +0000")
On Aug 06 2017, Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:
> diff --git a/t/t7004-tag.sh b/t/t7004-tag.sh
> index 0ef7b94394..0e2e57aa3d 100755
> --- a/t/t7004-tag.sh
> +++ b/t/t7004-tag.sh
> @@ -1887,7 +1887,7 @@ EOF"
> run_with_limited_stack git tag --contains HEAD >actual &&
> test_cmp expect actual &&
> run_with_limited_stack git tag --no-contains HEAD >actual &&
> - test_line_count ">" 10 actual
> + test_line_count "-gt" 10 actual
Maybe also remove the quotes, they are no longer needed.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
prev parent reply other threads:[~2017-08-07 18:06 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-06 23:38 [PATCH] tests: don't give unportable ">" to "test" built-in, use -gt Ævar Arnfjörð Bjarmason
2017-08-07 1:18 ` brian m. carlson
2017-08-07 10:17 ` René Scharfe
2017-08-07 10:59 ` Ævar Arnfjörð Bjarmason
2017-08-07 11:04 ` [PATCH] t0001: skip test with restrictive permissions if getpwd(3) respects them René Scharfe
2021-06-01 0:38 ` [PATCH] t0001: fix broken not-quite getcwd(3) test in bed67874e2 Ævar Arnfjörð Bjarmason
2021-06-01 16:15 ` René Scharfe
2021-06-01 21:20 ` Junio C Hamano
2021-06-07 11:29 ` Ævar Arnfjörð Bjarmason
2021-06-07 11:24 ` Ævar Arnfjörð Bjarmason
2021-06-07 15:26 ` René Scharfe
2021-06-07 15:38 ` Ævar Arnfjörð Bjarmason
2021-07-30 16:18 ` [PATCH v2] " Ævar Arnfjörð Bjarmason
2021-07-30 17:16 ` Junio C Hamano
2017-08-07 1:33 ` [PATCH] tests: don't give unportable ">" to "test" built-in, use -gt Junio C Hamano
2017-08-07 17:32 ` Junio C Hamano
2017-08-07 18:06 ` Andreas Schwab [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h8xjfe1n.fsf@linux-m68k.org \
--to=schwab@linux-m68k.org \
--cc=avarab@gmail.com \
--cc=dcoppa@openbsd.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=l.s.r@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.