From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f200.google.com (mail-pf0-f200.google.com [209.85.192.200]) by kanga.kvack.org (Postfix) with ESMTP id 8115F6B02F3 for ; Tue, 25 Jul 2017 21:30:30 -0400 (EDT) Received: by mail-pf0-f200.google.com with SMTP id k72so69564387pfj.1 for ; Tue, 25 Jul 2017 18:30:30 -0700 (PDT) Received: from mga09.intel.com (mga09.intel.com. [134.134.136.24]) by mx.google.com with ESMTPS id q10si9430020pli.45.2017.07.25.18.30.29 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 25 Jul 2017 18:30:29 -0700 (PDT) From: "Huang\, Ying" Subject: Re: [PATCH -mm -v3 1/6] mm, swap: Add swap cache statistics sysfs interface References: <20170725015151.19502-1-ying.huang@intel.com> <20170725015151.19502-2-ying.huang@intel.com> <1501016754.26846.22.camel@redhat.com> Date: Wed, 26 Jul 2017 09:30:26 +0800 In-Reply-To: <1501016754.26846.22.camel@redhat.com> (Rik van Riel's message of "Tue, 25 Jul 2017 17:05:54 -0400") Message-ID: <87h8y0gf2l.fsf@yhuang-dev.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: owner-linux-mm@kvack.org List-ID: To: Rik van Riel Cc: "Huang, Ying" , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Johannes Weiner , Minchan Kim , Shaohua Li , Hugh Dickins , Fengguang Wu , Tim Chen , Dave Hansen Hi, Rik, Rik van Riel writes: > On Tue, 2017-07-25 at 09:51 +0800, Huang, Ying wrote: >> From: Huang Ying >> >> The swap cache stats could be gotten only via sysrq, which isn't >> convenient in some situation.A A So the sysfs interface of swap cache >> stats is added for that.A A The added sysfs directories/files are as >> follow, >> >> /sys/kernel/mm/swap >> /sys/kernel/mm/swap/cache_find_total >> /sys/kernel/mm/swap/cache_find_success >> /sys/kernel/mm/swap/cache_add >> /sys/kernel/mm/swap/cache_del >> /sys/kernel/mm/swap/cache_pages >> > What is the advantage of this vs new fields in > /proc/vmstat, which is where most of the VM > statistics seem to live? As proposed by Andrew, will use debugfs for them, because they are mostly developer related. Best Regards, Huang, Ying -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751852AbdGZBab (ORCPT ); Tue, 25 Jul 2017 21:30:31 -0400 Received: from mga06.intel.com ([134.134.136.31]:60201 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751826AbdGZBa3 (ORCPT ); Tue, 25 Jul 2017 21:30:29 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,413,1496127600"; d="scan'208";a="131912423" From: "Huang\, Ying" To: Rik van Riel Cc: "Huang\, Ying" , Andrew Morton , , , Johannes Weiner , Minchan Kim , Shaohua Li , Hugh Dickins , Fengguang Wu , Tim Chen , Dave Hansen Subject: Re: [PATCH -mm -v3 1/6] mm, swap: Add swap cache statistics sysfs interface References: <20170725015151.19502-1-ying.huang@intel.com> <20170725015151.19502-2-ying.huang@intel.com> <1501016754.26846.22.camel@redhat.com> Date: Wed, 26 Jul 2017 09:30:26 +0800 In-Reply-To: <1501016754.26846.22.camel@redhat.com> (Rik van Riel's message of "Tue, 25 Jul 2017 17:05:54 -0400") Message-ID: <87h8y0gf2l.fsf@yhuang-dev.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Rik, Rik van Riel writes: > On Tue, 2017-07-25 at 09:51 +0800, Huang, Ying wrote: >> From: Huang Ying >> >> The swap cache stats could be gotten only via sysrq, which isn't >> convenient in some situation.  So the sysfs interface of swap cache >> stats is added for that.  The added sysfs directories/files are as >> follow, >> >> /sys/kernel/mm/swap >> /sys/kernel/mm/swap/cache_find_total >> /sys/kernel/mm/swap/cache_find_success >> /sys/kernel/mm/swap/cache_add >> /sys/kernel/mm/swap/cache_del >> /sys/kernel/mm/swap/cache_pages >> > What is the advantage of this vs new fields in > /proc/vmstat, which is where most of the VM > statistics seem to live? As proposed by Andrew, will use debugfs for them, because they are mostly developer related. Best Regards, Huang, Ying