From: Juan Quintela <quintela@redhat.com>
To: Peter Xu <peterx@redhat.com>
Cc: qemu-devel@nongnu.org, Eduardo Habkost <ehabkost@redhat.com>,
Laurent Vivier <lvivier@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 09/11] migration: provide migrate_caps_check()
Date: Mon, 17 Jul 2017 21:03:47 +0200 [thread overview]
Message-ID: <87h8yanawc.fsf@secure.laptop> (raw)
In-Reply-To: <1500279971-13875-10-git-send-email-peterx@redhat.com> (Peter Xu's message of "Mon, 17 Jul 2017 16:26:09 +0800")
Peter Xu <peterx@redhat.com> wrote:
> Abstract helper function to check migration capabilities (from the old
> qmp_migrate_set_capabilities). Prepare to be used somewhere else.
>
> There is side effect on the change: when applying the capabilities, we
> were skipping the invalid ones, but still applying the valid ones (if
> they are provided in the same QMP request). After this refactoring,
> we'll ignore all the capabilities if we detected invalid setup along the
> way. However, I don't think it is a problem since general users should
> not provide anything invalid after all.
>
> Signed-off-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
I think that the "caveat" that we used to set the valid capabilities in
one message is just undefined behaviour. I preffer the new semmantics
anyways.
next prev parent reply other threads:[~2017-07-17 19:03 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-17 8:26 [Qemu-devel] [PATCH v2 00/11] migration: export cap/params to qdev props Peter Xu
2017-07-17 8:26 ` [Qemu-devel] [PATCH v2 01/11] qdev: provide DEFINE_PROP_INT64() Peter Xu
2017-07-17 8:30 ` Marcel Apfelbaum
2017-07-17 16:24 ` Juan Quintela
2017-07-17 16:30 ` Eric Blake
2017-07-18 1:25 ` Peter Xu
2017-07-17 17:49 ` Eduardo Habkost
2017-07-17 8:26 ` [Qemu-devel] [PATCH v2 02/11] migration: export parameters to props Peter Xu
2017-07-17 16:30 ` Juan Quintela
2017-07-17 8:26 ` [Qemu-devel] [PATCH v2 03/11] migration: export capabilities " Peter Xu
2017-07-17 16:58 ` Juan Quintela
2017-07-18 1:34 ` Peter Xu
2017-07-17 17:52 ` Eduardo Habkost
2017-07-18 1:00 ` Peter Xu
2017-07-17 8:26 ` [Qemu-devel] [PATCH v2 04/11] qom: call parent first on post_init() Peter Xu
2017-07-17 18:02 ` Eduardo Habkost
2017-07-17 8:26 ` [Qemu-devel] [PATCH v2 05/11] migration: introduce migrate_params_check() Peter Xu
2017-07-17 17:04 ` Juan Quintela
2017-07-17 8:26 ` [Qemu-devel] [PATCH v2 06/11] migration: provide migrate_params_apply() Peter Xu
2017-07-17 19:01 ` Juan Quintela
2017-07-17 8:26 ` [Qemu-devel] [PATCH v2 07/11] migration: check global params for validity Peter Xu
2017-07-17 17:50 ` Juan Quintela
2017-07-17 18:25 ` Eduardo Habkost
2017-07-18 1:56 ` Peter Xu
2017-07-18 2:33 ` Eduardo Habkost
2017-07-18 2:41 ` Peter Xu
2017-07-17 8:26 ` [Qemu-devel] [PATCH v2 08/11] migration: remove check against colo support Peter Xu
2017-07-17 17:07 ` Juan Quintela
2017-07-18 7:13 ` Zhang Chen
2017-07-17 8:26 ` [Qemu-devel] [PATCH v2 09/11] migration: provide migrate_caps_check() Peter Xu
2017-07-17 19:03 ` Juan Quintela [this message]
2017-07-17 8:26 ` [Qemu-devel] [PATCH v2 10/11] migration: provide migrate_cap_add() Peter Xu
2017-07-17 17:14 ` Juan Quintela
2017-07-18 3:10 ` Peter Xu
2017-07-17 8:26 ` [Qemu-devel] [PATCH v2 11/11] migration: check global caps for validity Peter Xu
2017-07-17 19:48 ` Juan Quintela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h8yanawc.fsf@secure.laptop \
--to=quintela@redhat.com \
--cc=armbru@redhat.com \
--cc=dgilbert@redhat.com \
--cc=ehabkost@redhat.com \
--cc=lvivier@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.