From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [RFC PATCH 7/7] drm/i915: add DisplayPort CEC-Tunneling-over-AUX support Date: Fri, 26 May 2017 13:13:02 +0300 Message-ID: <87h908lydt.fsf@intel.com> References: <20170525150626.29748-1-hverkuil@xs4all.nl> <20170525150626.29748-8-hverkuil@xs4all.nl> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20170525150626.29748-8-hverkuil@xs4all.nl> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Hans Verkuil , linux-media@vger.kernel.org Cc: intel-gfx@lists.freedesktop.org, Hans Verkuil , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCAyNSBNYXkgMjAxNywgSGFucyBWZXJrdWlsIDxodmVya3VpbEB4czRhbGwubmw+IHdy b3RlOgo+IEBAIC00MTc5LDYgKzQxODEsMzMgQEAgaW50ZWxfZHBfY2hlY2tfbXN0X3N0YXR1cyhz dHJ1Y3QgaW50ZWxfZHAgKmludGVsX2RwKQo+ICAJcmV0dXJuIC1FSU5WQUw7Cj4gIH0KPiAgCj4g K3N0YXRpYyBib29sCj4gK2ludGVsX2RwX2NoZWNrX2NlY19zdGF0dXMoc3RydWN0IGludGVsX2Rw ICppbnRlbF9kcCkKPiArewo+ICsJYm9vbCBoYW5kbGVkID0gZmFsc2U7Cj4gKwo+ICsJZm9yICg7 Oykgewo+ICsJCXU4IGNlY19pcnE7Cj4gKwkJaW50IHJldDsKPiArCj4gKwkJcmV0ID0gZHJtX2Rw X2RwY2RfcmVhZGIoJmludGVsX2RwLT5hdXgsCj4gKwkJCQkJRFBfREVWSUNFX1NFUlZJQ0VfSVJR X1ZFQ1RPUl9FU0kxLAo+ICsJCQkJCSZjZWNfaXJxKTsKPiArCQlpZiAocmV0IDwgMCB8fCAhKGNl Y19pcnEgJiBEUF9DRUNfSVJRKSkKPiArCQkJcmV0dXJuIGhhbmRsZWQ7Cj4gKwo+ICsJCWNlY19p cnEgJj0gfkRQX0NFQ19JUlE7Cj4gKwkJZHJtX2RwX2NlY19pcnEoJmludGVsX2RwLT5hdXgpOwo+ ICsJCWhhbmRsZWQgPSB0cnVlOwo+ICsKPiArCQlyZXQgPSBkcm1fZHBfZHBjZF93cml0ZWIoJmlu dGVsX2RwLT5hdXgsCj4gKwkJCQkJIERQX0RFVklDRV9TRVJWSUNFX0lSUV9WRUNUT1JfRVNJMSwK PiArCQkJCQkgY2VjX2lycSk7Cj4gKwkJaWYgKHJldCA8IDApCj4gKwkJCXJldHVybiBoYW5kbGVk Owo+ICsJfQoKRFAgc2lua3Mgc3Vjay4gUGxlYXNlIGFkZCBhIGxpbWl0IHRvIHRoZSBsb29wLgoK QlIsCkphbmkuCgoKLS0gCkphbmkgTmlrdWxhLCBJbnRlbCBPcGVuIFNvdXJjZSBUZWNobm9sb2d5 IENlbnRlcgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJ bnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0 cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mga01.intel.com ([192.55.52.88]:1372 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S971067AbdEZKJj (ORCPT ); Fri, 26 May 2017 06:09:39 -0400 From: Jani Nikula To: Hans Verkuil , linux-media@vger.kernel.org Cc: dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, Clint Taylor , Daniel Vetter , Hans Verkuil Subject: Re: [RFC PATCH 7/7] drm/i915: add DisplayPort CEC-Tunneling-over-AUX support In-Reply-To: <20170525150626.29748-8-hverkuil@xs4all.nl> References: <20170525150626.29748-1-hverkuil@xs4all.nl> <20170525150626.29748-8-hverkuil@xs4all.nl> Date: Fri, 26 May 2017 13:13:02 +0300 Message-ID: <87h908lydt.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-media-owner@vger.kernel.org List-ID: On Thu, 25 May 2017, Hans Verkuil wrote: > @@ -4179,6 +4181,33 @@ intel_dp_check_mst_status(struct intel_dp *intel_dp) > return -EINVAL; > } > > +static bool > +intel_dp_check_cec_status(struct intel_dp *intel_dp) > +{ > + bool handled = false; > + > + for (;;) { > + u8 cec_irq; > + int ret; > + > + ret = drm_dp_dpcd_readb(&intel_dp->aux, > + DP_DEVICE_SERVICE_IRQ_VECTOR_ESI1, > + &cec_irq); > + if (ret < 0 || !(cec_irq & DP_CEC_IRQ)) > + return handled; > + > + cec_irq &= ~DP_CEC_IRQ; > + drm_dp_cec_irq(&intel_dp->aux); > + handled = true; > + > + ret = drm_dp_dpcd_writeb(&intel_dp->aux, > + DP_DEVICE_SERVICE_IRQ_VECTOR_ESI1, > + cec_irq); > + if (ret < 0) > + return handled; > + } DP sinks suck. Please add a limit to the loop. BR, Jani. -- Jani Nikula, Intel Open Source Technology Center