Re: [V3,1/3] ata: ahci_tegra: Add AHCI support for tegra210

[Vagrant Cascadian <vagrant@debian.org>]

[-- Attachment #1: Type: text/plain, Size: 1854 bytes --]

On 2017-05-12, PREETHAM RAMACHANDRA wrote:
> From: Preetham Chandru R <pchandru@nvidia.com>
>
> 1. Move tegra124 specifics to tegra124_ahci_init.
> 2. Separate the regulators needed for tegra124 and tegra210.
> 3. Disable DIPM and Devslp for t210 and t124 as there are known issues

When building with this patch applied on 4.11, I got the following
warnings/errors:

../../../drivers/ata/ahci_tegra.c: In function
‘tegra_ahci_controller_init’:
../../../drivers/ata/ahci_tegra.c:433:2: error: implicit declaration of
function ‘tegra_ahci_handle_quirks’ [-Werror=i\
mplicit-function-declaration]
  tegra_ahci_handle_quirks(hpriv);
  ^~~~~~~~~~~~~~~~~~~~~~~~
../../../drivers/ata/ahci_tegra.c: At top level:
../../../drivers/ata/ahci_tegra.c:483:13: warning: conflicting types for
‘tegra_ahci_handle_quirks’
 static void tegra_ahci_handle_quirks(struct ahci_host_priv *hpriv)
             ^~~~~~~~~~~~~~~~~~~~~~~~
../../../drivers/ata/ahci_tegra.c:483:13: error: static declaration of
‘tegra_ahci_handle_quirks’ follows non-static d\
eclaration
../../../drivers/ata/ahci_tegra.c:433:2: note: previous implicit
declaration of ‘tegra_ahci_handle_quirks’ was here
  tegra_ahci_handle_quirks(hpriv);
  ^~~~~~~~~~~~~~~~~~~~~~~~
../../../drivers/ata/ahci_tegra.c:483:13: warning:
‘tegra_ahci_handle_quirks’ defined but not used [-Wunused-function]
 static void tegra_ahci_handle_quirks(struct ahci_host_priv *hpriv)
             ^~~~~~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
/<<PKGBUILDDIR>>/scripts/Makefile.build:305: recipe for target
'drivers/ata/ahci_tegra.o' failed
make[7]: *** [drivers/ata/ahci_tegra.o] Error 1


Full build log:

  https://www.aikidev.net/~vagrant/jetson-tx1/linux_4.11-1~exp3~20170522~1_arm64-2017-05-22T17:54:19Z.build


live well,
  vagrant

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]