From: Kalle Valo <kvalo@codeaurora.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Eugene Krasnikov <k.eugene.e@gmail.com>,
Eyal Ilsar <c_eilsar@qti.qualcomm.com>,
wcn36xx@lists.infradead.org, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH] wcn36xx: Close SMD channel on device removal
Date: Tue, 09 May 2017 09:17:05 +0300 [thread overview]
Message-ID: <87h90u3672.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <20170509043637.28179-1-bjorn.andersson@linaro.org> (Bjorn Andersson's message of "Mon, 8 May 2017 21:36:37 -0700")
Bjorn Andersson <bjorn.andersson@linaro.org> writes:
> The SMD channel is not the primary WCNSS channel and must explicitly be
> closed as the device is removed, or the channel will already by open on
> a subsequent probe call in e.g. the case of reloading the kernel module.
>
> This issue was introduced because I simplified the underlying SMD
> implementation while the SMD adaptions of the driver sat on the mailing
> list, but missed to update these patches. The patch does however only
> apply back to the transition to rpmsg, hence the limited Fixes.
>
> Fixes: 5052de8deff5 ("soc: qcom: smd: Transition client drivers from smd to rpmsg")
> Reported-by: Eyal Ilsar <c_eilsar@qti.qualcomm.com>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
As this is a regression I'll queue this to 4.12.
But if this is an older bug (didn't quite understand your description
though) should there be a separate patch for stable releases?
--
Kalle Valo
next prev parent reply other threads:[~2017-05-09 6:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-09 4:36 [PATCH] wcn36xx: Close SMD channel on device removal Bjorn Andersson
2017-05-09 6:17 ` Kalle Valo [this message]
2017-05-09 23:03 ` Bjorn Andersson
2017-05-10 7:27 ` Arend van Spriel
2017-05-10 17:52 ` Bjorn Andersson
2017-05-11 12:11 ` Kalle Valo
2017-05-23 15:23 ` Kalle Valo
2017-05-23 15:23 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h90u3672.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=c_eilsar@qti.qualcomm.com \
--cc=k.eugene.e@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=wcn36xx@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.